[RESOLVED] php script killing me

deccypher

Hi i Have been pulling my hair out over this for days and i was told the best php programmers are here so i hope someone can help me

i have this static code (works fine)

<?php
//this includes an external file with a script to dispaly this pages output as a pdf
include ('class.ezpdf.php');
//function to let the script know its a new pdf file and not an adition to an existing one
$pdf =& new Cezpdf();
//define the font to be used in the pdf
$pdf->selectFont('./fonts/Helvetica.afm');
//adds text with defined size on the pdf
$pdf->ezText(' personlized catalouge',12);
//a cheap way to add a new line :=)
$pdf->ezText(' ',12);
//this adds a table on to the pdf output the first value sets the coloum headder and then the value to be displayed in that coloum
$data =array(
array('id'=>'1','ptno'=>'111','Title'=>'sample titel','Description'=>'description here')
,array('id'=>'2','ptno'=>'112','Title'=>'sample titel','Description'=>'description here')
,array('id'=>'3','ptno'=>'113','Title'=>'sample titel','Description'=>'description here')
,array('id'=>'4','ptno'=>'114','Title'=>'sample titel','Description'=>'description here')
,array('id'=>'5','ptno'=>'115','Title'=>'sample titel','Description'=>'description here')
,array('id'=>'6','ptno'=>'116','Title'=>'sample titel','Description'=>'description here')
,array('id'=>'7','ptno'=>'117','Title'=>'sample titel','Description'=>'description here')
,array('id'=>'8','ptno'=>'118','Title'=>'sample titel','Description'=>'description here')
,array('id'=>'9','ptno'=>'119','Title'=>'sample titel','Description'=>'description here')
);

// lets the script know that the variable data contains the data fro the table generator for the pdf
$pdf->ezTable($data);
//command to submit and close the pdf creation document and display the output 
$pdf->ezStream();
?>

however im trying to get the array to be pulled from a database
this is what i have tried

<?php

//includes the database connection information
include ('../include/database/config.php');
include ('../include/database/opendb.php');
//the sql query 
$sql5 = "SELECT * FROM `products` LIMIT 1,5000"; 
//check the query works if not thouw up an error
$result5 = mysql_query($sql5) or die('Query 5 failed. ' . mysql_error()); 
//this includes an external file with a script to dispaly this pages output as a pdf
include ('class.ezpdf.php');

//function to let the script know its a new pdf file and not an adition to an existing one
$pdf =& new Cezpdf();
//define the font to be used in the pdf
$pdf->selectFont('./fonts/Helvetica.afm');
//adds text with defined size on the pdf
$pdf->ezText(' personlized catalouge',12);
//a cheap way to add a new line :=)
$pdf->ezText(' ',12);
//adding the first fixed line to get over the problem of not needing a , on the first aray item iknow ists a cheap way of gettign around this
$data =array(
array('id'=>'1','ptno'=>'111','Title'=>'sample titel','Description'=>'description here')

// the database query output  durign the while statment it will get all the products and input the values needing into the aray
		 while($r5 = mysql_fetch_array($result5))
		  {
$id5=$r5["id"];
$ptno5=$r5["ptno"];
$title5=$r5["title"];
$fulldesc5=$r5["fulldesc"];
,array('id'=>'$id5','ptno'=>'$ptno5','Title'=>'$title5','Description'=>'$fulldesc5')

              }

//close the array
);


// lets the script know that the variable data contains the data fro the table generator for the pdf
$pdf->ezTable($data);
//command to submit and close the pdf creation document and display the output 
$pdf->ezStream();
?>

this give me an error.. i realize that the coding is wrong i just dont see the right way to do it .. any help with this will be appreciated

***edited to add the comment tags as suggested

illzz

When defining $data, try this instead...

<?php
$data   = array();
$data[] = array('id'=>'1','ptno'=>'111','Title'=>'sample titel','Description'=>'description here');

while ($r5 = mysql_fetch_array($result5)) {
    $id5       = $r5["id"];
    $ptno5     = $r5["ptno"];
    $title5    = $r5["title"];
    $fulldesc5 = $r5["fulldesc"];
    $data[]    = array('id'=>$id5, 'ptno'=>$ptno5, 'Title'=>$title5, 'Description'=>$fulldesc5);
}
?>

Basically:
1. Define your Main Array
2. Add your initial entry
3. Create an array from each row and append it to the main array
4. Remove the single quotes surrounding your variables because the variables will be added literally.

illzz

Here is another way to do this, by modifying the query so we know which columns we are retrieving...

<?php
$sql5 = "SELECT id, ptno, Title, Description FROM `products` LIMIT 1,5000";

$result5 = mysql_query($sql5) or die('Query 5 failed. ' . mysql_error());

$data   = array();
$data[] = array('id'=>'1','ptno'=>'111','Title'=>'sample titel','Description'=>'description here');

while ($r5 = mysql_fetch_array($result5, MYSQL_ASSOC)) {
//    $data[] = array($r5);
//    oops!  no need to put $r5 into an array because it already is one...
    $data[] = $r5;
}
?>

deccypher

thank you .. that worked like a charm..

ill be sure to post any helpful comments for things i can help on too 🙂

illzz

no problem... don't forget to mark this thread as resolved.

cahva

Adding to illzz code you can take your little "hack" away(initializing the first row of data). Also use mysql_fetch_assoc instead of mysql_fetch_array.

It would be also good to just select the fields you need straight in your query:

// First the query
$sql5 = "SELECT  id,ptno,title Title,fulldesc Description FROM `products` LIMIT 1,5000";

// .. and later in the code you only do like this

$data = array();

while($r5 = mysql_fetch_assoc($result5)) {
    $data[] = $r5;
}

$pdf->ezTable($data);

illzz

cahva, thanks for catching that the little hack isn't needed. When I first looked the code, the comments weren't in there so I just assumed that the first row was wanted...

also, like cahva was getting at, it is a good practice to specify the fields you want when you structure your queries rather than doing a "select *".

I also found and fixed a typo in my second example after looking at cahva's code.... we were basically doing the exact same thing.

deccypher

thanks all for the help

deccypher

hi another problem with the same script here thanks for the help with this one and if you feel like it jump over see if your expert tips can help me again