feof, and fread question.

fatepower

I checked my site log and saw this in to it:

[11-Jul-2008 13:34:10] PHP Warning: fread(): supplied argument is not a valid stream resource in /home/bits/public_html/imdb_config.php on line 120
[11-Jul-2008 13:34:10] PHP Warning: feof(): supplied argument is not a valid stream resource in /home/bits/public_html/imdb_config.php on line 119

The lines in imdb_config.php is:

    /** Get the Response body
     * @method getResponseBody
     */
    function getResponseBody(){
      $page = "";
      while (!feof ($this->fpopened)) {
        $page .= fread ($this->fpopened, 1024);
      }
      return $page;
    }

Why do i see this error? I only see it in the error_log at the server.

Server info:

Apache version 2.0.61
PHP version 4.4.7
MySQL version 4.1.22-standard
Architecture i686
Operating system Linux

Thanks in advance

bpat1434

It means that $this->fpopened isn't a valid result resource from an [man]fopen/man call. It's kind of self explanatory.

NogDog

The immediate cause would appear to be that $this->fpopened is not a valid resource. The root cause though will have to be determined by finding out where/how that variable gets set. My guess would be that it's intended to be a handle to a remote web resource and the connection is failing, but that's pure guesswork at this point. (If so, then probably some additional error-handling needs to be added somewhere to detect and more gracefully handle such a problem.)

fatepower

Yes i think you have right NogDog, The script is ment to connect to IMDB and get all info about a movie ect ect.. If a user post a wrongly url, it do not have the possibility to connect to that url. Then the error would appear. I didn't think about that, i thiked it was a script related error.

Anyway the whole imdb_config.php looks like this:

<?php
 #############################################################################
 # IMDBPHP                              (c) Giorgos Giagas & Itzchak Rehberg #
 # written by Giorgos Giagas                                                 #
 # extended & maintained by Itzchak Rehberg <izzysoft@qumran.org>            #
 # http://www.qumran.org/homes/izzy/                                         #
 # ------------------------------------------------------------------------- #
 # This program is free software; you can redistribute and/or modify it      #
 # under the terms of the GNU General Public License (see doc/LICENSE)       #
 #############################################################################

 /* $Id: imdb_config.php,v 1.3 2007/02/26 22:44:14 izzy Exp $ */

// the proxy to use for connections to imdb.
// leave it empty for no proxy.
// this is only supported with PEAR. 
define ('PROXY', "");
define ('PROXY_PORT', "");

// set to false to use the old browseremulator.
$PEAR = false;

/** Configuration part of the IMDB classes
 * @package Api
 * @class imdb_config
 */
class imdb_config {
  var $imdbsite;
  var $cachedir;
  var $usecache;
  var $storecache;
  var $cache_expire;
  var $photodir;
  var $photoroot;

  /** Constructor and only method of this base class.
   *  There's no need to call this yourself - you should just place your
   *  configuration data here.
   * @constructor imdb_config
   */
  function imdb_config(){
    // the imdb server to use.
    // choices are us.imdb.com uk.imdb.com german.imdb.com and italian.imdb.com
    // the localized ones (i.e. italian and german) are only qualified to find
    // the movies IMDB ID -- but parsing for the details will fail at the moment.
    $this->imdbsite = "us.imdb.com";
    // cachedir should be writable by the webserver. This doesn't need to be
    // under documentroot.
    $this->cachedir = './cache/imdb/';
    //whether to use a cached page to retrieve the information if available.
    $this->usecache = false;
    //whether to store the pages retrieved for later use.
    $this->storecache = false;
    // automatically delete cached files older than X secs
    $this->cache_expire = 600;
    // images are stored here after calling photo_localurl()
    // this needs to be under documentroot to be able to display them on your pages.
    $this->photodir = './images/imdb/';
    // this is the URL to the images, i.e. start at your servers DOCUMENT_ROOT
    // when specifying absolute path
    $this->photoroot = './images/imdb/';
    // TWEAKING OPTIONS:
    // limit the result set to X movies (0 to disable, comment out to use default of 20)
    $this->maxresults = 20;
    // search variants. Valid options are "sevec" and "moonface". Comment out
    // (or set to empty string) to use the default
    $this->searchvariant = "";
  }

}

// Don't edit below this line if you don't know exactly what you're doing :)

if ( $PEAR ){
// Use the HTTP_Request class from the PEAR project.
  require_once ("HTTP/Request.php");

  class IMDB_Request extends HTTP_Request{
    function IMDB_Request($url){
      $this->HTTP_Request($url);
      if ( PROXY != ""){
        $this->setProxy(PROXY, PROXY_PORT);
      }
      $this->_allowRedirects = false;
      $this->addHeader("User-Agent", "Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1)");
    }	
  }
}else{
// Use the browseremu class
  require_once ("browseremulator.class.php");

  /** The request class
   *  Here we emulate a browser accessing the IMDB site. You don't need to
   *  call any of its method directly - they are rather used by the IMDB classes.
   * @package Api
   * @class IMDB_Request
   */
  class IMDB_Request extends BrowserEmulator{
    var $maxsize = 100000;
    /** Constructor: Initialize the BrowserEmulator
     *  No need to call this.
     * @constructor IMDB_Request
     */
    function IMDB_Request($url){
      $this->BrowserEmulator();
      $this->urltoopen = $url;
    }
    /** Send a request to the IMDB site
     * @method sendRequest
     */
    function sendRequest(){
      $this->fpopened = $this->fopen($this->urltoopen);
    }
    /** Get the Response body
     * @method getResponseBody
     */
    function getResponseBody(){
      $page = "";
      while (!feof ($this->fpopened)) {
        $page .= fread ($this->fpopened, 1024);
      }
      return $page;
    }
    /** Set the URL we need to parse
     * @method setURL
     */
    function setURL($url){
      $this->urltoopen = $url;
    }
    /** Obtain the response body
     * @method getresponseheader
     * @param optional string header
     */
    function getresponseheader($header = false){
      $headers = $this->getLastResponseHeaders();
      foreach ($headers as $head){
        if ( is_integer(strpos ($head, $header) )){
          $hstart = strpos ($head, ": ");
          $head = trim(substr($head,$hstart+2,100));
          return $head;
        }
      }
    }
  }
}		

?>

NogDog

You might want to add something to the getResponseBody method to handle this problem. Where I added the "return false;", you could change that to return some sort of error text that you want displayed when the connection fails, instead.

/** Get the Response body
* @method getResponseBody
*/
function getResponseBody(){
   if(!is_resource($this->fpopened)) {
      return false;
   }
   $page = "";
   while (!feof ($this->fpopened)) {
      $page .= fread ($this->fpopened, 1024);
   }
   return $page;
}

fatepower

Well how can i add,
a error message text with:

$ERROR_MSG = 'Error, Could not connect to IMDB, Please update the IMDB URL.<br>';
$error = $ERROR_MSG;

block_begin();
err_msg($error);
block_end();

Instead of a resturn false,

Something like this right:

/** Get the Response body
* @method getResponseBody
*/
function getResponseBody(){
   if(!is_resource($this->fpopened)) {

$ERROR_MSG = 'Error, Could not connect to IMDB, Please update the IMDB URL.<br>';
$error = $ERROR_MSG;

block_begin();
err_msg($error);
block_end();
   }
   $page = "";
   while (!feof ($this->fpopened)) {
      $page .= fread ($this->fpopened, 1024);
   }
   return $page;
}

Ohh, one more thing, shouldn't you have a "else" tag also above $page = "";

Cheers

NogDog

fatepower wrote:
...

Ohh, one more thing, shouldn't you have a "else" tag also above $page = "";

Cheers

With the return there in the if clause, an else is not needed since if the return is executed then the following code in the function will be ignored. However, it would not hurt anything to wrap the rest in an else block if you find that easier for you to read and follow the flow.

fatepower

Naah its okey mate. I will add this code into the imdb_config.php 😃

/** Get the Response body
* @method getResponseBody
*/
function getResponseBody(){
   if(!is_resource($this->fpopened)) {

$ERROR_MSG = 'Error, Could not connect to IMDB, Please update the IMDB URL.<br>';
$error = $ERROR_MSG;

block_begin();
err_msg($error);
block_end();
   }
   $page = "";
   while (!feof ($this->fpopened)) {
      $page .= fread ($this->fpopened, 1024);
   }
   return $page;
}

but in someway the error msg will not been shown anyway because this is just a config and the showingcode is in the details.php. Another PHP file. So i could just have return false. What do u think?

Cheers