[RESOLVED] Help Needed - PHP Coding Problem.

Anise_Verona

I have a very simple script as below and when I run this, I get empty page on browser. I notice that the problem is on this line :

"AND account.Login_id='$mylogin_id'";

If I replace '$mylogin_id' with the login_id for example (123847290) in my database, the whole script works well.

Could someone tell me what I am missing in the script?

<?php
session_start();
$connect=mysql_connect("localhost","root","123")
or die("Check your server connection.");

mysql_select_db("UserBalance");

$bal="SELECT account.Balance, ownerdetails.Name " .
	"FROM account, ownerdetails " .
	"WHERE account.Login_id=ownerdetails.Login_id " .
	"AND account.Login_id='$mylogin_id'";
$result=mysql_query($bal)
or die (mysql_error());


while ($row=mysql_fetch_assoc($result))
{
extract($row);
echo $Balance;
echo "<br>";
echo $Name;
echo "<br>";
}
?>

NogDog

Where does $mylogin_id get set? Does it have a value (try echoing it out)?

My guess is that your script is depending on the (deprecated) [man]register_globals[/man] setting being turned on, but your host (correctly) has it turned off. Assuming that's the case, you probably need to change that variable to use the applicable super-global array, e.g.:

"AND account.Login_id='" . $_SESSION['mylogin_id'] . "'";

Replace $_SESSION with $POST, $GET, or $_COOKIE as appropriate for wherever that value is supposed to be coming from. To take it to the next step, you then also need to add some sort of filtering to avoid SQL injection problems (whether malicious or accidental).

Anise_Verona

NogDog wrote:
Where does $mylogin_id get set? Does it have a value (try echoing it out)?

My guess is that your script is depending on the (deprecated) [man]register_globals[/man] setting being turned on, but your host (correctly) has it turned off. Assuming that's the case, you probably need to change that variable to use the applicable super-global array, e.g.:
"AND account.Login_id='" . $_SESSION['mylogin_id'] . "'";
Replace $_SESSION with $POST, $GET, or $_COOKIE as appropriate for wherever that value is supposed to be coming from. To take it to the next step, you then also need to add some sort of filtering to avoid SQL injection problems (whether malicious or accidental).

Yes, $mylogin_id has value and I did echo it out to ensure it.
Btw, your code works 🙂
and I have added the code for avoiding SQL injection problems.
Thank you for your help and time.

Regards,
Anise

NogDog

Just to clarify, did that fix your problem, or are you still not getting any output? If not, you might want to ensure all errors are being output to help debug:

<?php
ini_set('display_errors', 1);
error_reporting(E_ALL);

If it did fix it, then don't forget to mark this thread resolved ("Thread Tools" link at top of thread).

Anise_Verona

It did fix my problem.