[RESOLVED] Create Mysql Tables with Include

daveclose

I Have two files...

The first, a file containing database information

<?php
$mysqlhost = 'localhost';
$mysqlname = 'basename';
$mysqluser = 'uname';
$mysqlpass = '';
$conn = mysql_connect($mysqlhost, $mysqluser, $mysqlpass)
or die ('Cant Conect to MySQL server');

$db = mysql_select_db($mysqlname, $conn)
or die ('Cant Select Database'); 
?>

and the second, where it tries to create the database tables using the information form the first file.

<?php
include('../other/base.php');
$query = "name varchar(15),";
$query = "post varchar(255),";
$query = "ip varchar(15),";

$sql =  "($query)";
$db = mysql_query ($sql)
or die ("cant create tables");
echo ("Done");
?>

All I get from the above is echoing cant create tables 😕
Any ideas?

dagon

if you echo $sql you will see its not a valid query

daveclose

when i echo $sql it just gives me (ip varchar(15),)
😕 am i missing something

dagon

daveclose;10877612 wrote:
when i echo $sql it just gives me (ip varchar(15),)
😕 am i missing something

your missing a lot actully,

start by getting the mysql syntax correct:
http://dev.mysql.com/doc/refman/5.0/en/create-table.html

daveclose

:eek:😕

bradgrafelman

At any rate, you seem to believe that successive lines of "$var =" will append values to this variable, when in fact it will not. Instead, what you're doing is overwriting the value of the variable with a new value each time.

Try visiting this manual page: [man]language.operators.string[/man][EDIT: link corrected]. There you will see various methods of concatenation (that is, joining strings together).

Also, note that the most common method of debugging SQL queries is done like so:

$query = "SELECT foo FROM bar..." // store query string in a variable
$exec = mysql_query($query) or die('MySQL error: ' . mysql_error() . "<hr>Query: $query");

daveclose

I was simply following a tutorial in a book on how to add to tables. i assume from following the book that a full stop after the variable would fix the alleged append problem?

the link you have given refers me to "Sorry, but the function language.operators.strings is not in the online manual"

Might i also add i am posting in the "newbies" section and i am not believeing anything, i am learning this language and assumed that the script would do something clever being as i have referred to an mysql function.

dagon

the script is missing large chunks of what it requires to actully work.

bradgrafelman

Woops, sorry about the link, I've fixed it now.

And yes, ".=" is a different operator which will append the string on the right of the operator onto the one on the left.

dagon

to slow😃

daveclose

dagon;10877637 wrote:
the script is missing large chunks of what it requires to actully work.

I have fix the problem now it was due to the lack of double quotes in the first file
it should of been

$conn = mysql_connect("$mysqlhost", "$mysqluser", "$mysqlpass")

🆒

Hardly "large chunks"

and in the end i used.. (instead of the variable thing)

mysql_query("CREATE TABLE dbname (
fieldname VARCHAR(255));"

dagon

There was no CREATE function in your original post - I consider that a large chunk maybe not in number of characters but in terms of importance kind of vital.

daveclose

Well maybe next time you can post some help in this help forum, after all it is "newbies" and some people learn best from working examples which they then figure out. May I suggest that you appear to be missing large chunks of sanity.