switch...case works in some cases, not in others

rokchik

Hi.
I am using a switch...case statement to display either a one-line form or a table, depending on the user's actions. However, while the 'list', 'display1', 'describe1' and 'drop1' cases work, the 'display2' and 'describe2' cases are never called. The action is being passed from the form well enough but never picked up by the case😕.

The switch...case statement is here:

class tableAdmin {
	// member variables
	var $database;
	var $linkid;
	var $sqlstmt;
	var $rc;

// constructor
function tableAdmin ($database, $linkid) {
	$this -> database = $database;
	$this -> linkid = $linkid;
}

......................

switch ($userinfo[action]) {
	case 'list': {
		$tablelistarray = $myTableAdmin -> listTables();
		displayArray ("Tables", $tablelistarray);
		break;
	}
	case 'describe1': {
		displayOneLineForm ('chapter5_tableAdmin.php', 'Table Name', 'in_table', 'describe2', 'Describe Table');
		break;
	}
	case 'describe2': {
		$descriptionlist = $myTableAdmin -> describeTable ($table);
		displayResultSet ($descriptionlist);
		break;
	}
	case 'drop1': {
		displayOneLineForm ('chapter5_tableAdmin.php','Table Name','in_table','drop2','Drop Table');
		break;
	}
	case 'drop2': {
		$rc = $myTableAdmin -> dropTable ($userinfo[in_table]);
		echo "<br><br>\n<center>\n";
		if ($rc == TRUE) {
			echo "Table ".$userinfo[in_table]." was dropped.";
		} else {
			echo "Table ".$userinfo[in_table]." could not be dropped.";
		}
		echo "</center>\n";
		break;
	}
	case 'display1': {
		displayOneLineForm ('chapter5_tableAdmin.php','Table Name', 'in_table', 'display2', 'Display Table');
		break;
	}
	case 'display2': {
		echo "display2!";
		$tableresults = $myTableAdmin -> displayTable ($userinfo[in_table]);

	displayResultSet ($resultset);
	break;
}

}

It refers to the following:

function displayResultSet ($resultset) {
	echo "function displayResultset called<br>\n";
	// Indicate if the resultset is empty
	echo "resultset: $resultset";
	foreach ($resultset as $k => $v) {
		echo "$k: $v";
	}
	if (empty($resultset)) {
		echo "<center>\n";
		echo "<br>";
		echo "Action returned no rows!";
		echo "</center>";
		return ;
	} else {

	echo "<br>\n";
	echo "<center>\n";
	echo "<table cellspacing = 5 cellpadding = 5 border = 3 bordercolor = \"0000FF\" >\n";
	echo "<thead>\n";
	echo "<tr>\n";

	$keycount = 0;
	// Output each key as a column heading
	while (list($key, $value) = each ($resultset[0])) {
		$keycount++;
		echo "<th>";
		echo $key;
		echo "</th>\n";

	}
	echo "</tr>\n";
	echo "</thead>\n";

	// Output each value as elements of a table starting a new row 
	// each time the key number of columns is reached
	$rowcount = sizeof ($resultset);
	for ($rowCounter = 0; $rowCounter < $rowcount; $rowCounter++) {
		$valuesarray = array_values($resultset[$rowCounter]);
		echo "<tr>\n";
		for ($colCounter = 0; $colCounter < $keycount; $colCounter++) {
			echo "<td>\n";
			echo "&nbsp;";
			echo $valuesarray[$colCounter];
			echo "&nbsp;";
			echo "</td>\n";			
		}
	}
	echo "</tr>\n";
	echo "</table>\n";
	echo "</center>\n";
	echo "<br>\n";
}
}

Any help would be appreciated.
TIA.

blckspder

First try removing the { } brackets from your case statements, these are not needed in php: your switch statement should look similar to this:

switch ($userinfo[action]) {
    case 'list':
        $tablelistarray = $myTableAdmin -> listTables();
        displayArray ("Tables", $tablelistarray);
        break;

case 'describe1':
    displayOneLineForm ('chapter5_tableAdmin.php', 'Table Name', 'in_table', 'describe2', 'Describe Table');
    break;

case 'describe2':
    $descriptionlist = $myTableAdmin -> describeTable ($table);
    displayResultSet ($descriptionlist);
    break;

case 'drop1':
    displayOneLineForm ('chapter5_tableAdmin.php','Table Name','in_table','drop2','Drop Table');
    break;

case 'drop2':
    $rc = $myTableAdmin -> dropTable ($userinfo[in_table]);
    echo "<br><br>\n<center>\n";
    if ($rc == TRUE) {
        echo "Table ".$userinfo[in_table]." was dropped.";
    } else {
        echo "Table ".$userinfo[in_table]." could not be dropped.";
    }
    echo "</center>\n";
    break;

case 'display1':
    displayOneLineForm ('chapter5_tableAdmin.php','Table Name', 'in_table', 'display2', 'Display Table');
    break;

case 'display2':
    echo "display2!";
    $tableresults = $myTableAdmin -> displayTable ($userinfo[in_table]);

    displayResultSet ($resultset);
    break;
}

you can find more info on switch statements here:
http://us3.php.net/switch

rokchik

I have removed the superfluous braces, but the response hasn't improved any.
Thanks anyway, blckspder.

NogDog

(Note: I just noticed I left out the parens at the end of the debug_backtrace() function. It's now fixed.)

Try debugging by adding a default to the end of the switch to see what the value of the switch variable really is when it falls through:

switch($userinfo[action]) {
// various cases, then...
   default:
      echo "<pre>DEBUG: \$userinfo[action] = ".$userinfo[action]."\n";
      print_r(debug_backtrace());
      echo "</pre>";
}

You can add other stuff you want output, such as perhaps a print_r($_POST); etc. (And of course you'll want something a lot more "graceful" for the production version, but this should at least help you now to figure out what is happening.)

rokchik

Thanks, NogDog, your suggestion gave me this output:
DEBUG: $userinfo[action] = describe2
debug_backtrace

I had already put a couple of echo statements in after the switch...case and this is their output:
action: describe2
userinfo[in_table]: user

and I have an echo as soon as displayResultSet() is called, and another in

case 'describe2': {
$descriptionlist = $myTableAdmin -> describeTable ($table);
displayResultSet ($descriptionlist);
break;
}

Neither of the two echoes show anything up.

mikell

Try trimming $userinfo[action] to make sure no spaces are getting added to the end of it.

$action = trim($userinfo[action]);
//replace every occurrence of $userinfo[action] with $action

If that doesn't fix it, then try the following and tell me what output you get:
1. Remove all debugging stuff that you've added and undo the stuff I mentioned above.
2. Add the following right before the switch statement begins:
echo 'action:' . $userinfo[action] . '<br>';
3. change your case 'describe2': code to the following:

    case 'describe2':
    	echo '1<br>';
    	$descriptionlist = $myTableAdmin -> describeTable ($table);
    	echo '2<br>';
    	displayResultSet ($descriptionlist);
    	echo '3<br>';
        die('finished...');
    	break;

4. Submit the form with 'describe2' as your action and tell me what output you get.

NogDog

rokchik;10877760 wrote:
Thanks, NogDog, your suggestion gave me this output:
DEBUG: $userinfo[action] = describe2
debug_backtrace

I had already put a couple of echo statements in after the switch...case and this is their output:
action: describe2
userinfo[in_table]: user

and I have an echo as soon as displayResultSet() is called, and another in

Neither of the two echoes show anything up.

Note that I left out the parens at the end of the debug_backtrace() function call. I've fixed it in my previous reply.

Also, if the issue could be extra white-space around a value, you can check that via var_dump($variable_name).

rokchik

I've got the following echoes:

case 'describe2': 
		echo "case: describe2 successfully called.";
		$descriptionlist = $myTableAdmin -> describeTable ($table);
		echo "variable descriptionlist = myTableAdmin -> describeTable(table) successful: $descriptionlist<br>\n";
		$rc = displayResultSet ($descriptionlist);
		echo "function displayResultSet called: $rc<br>\n";
		break;

.................

case 'display2': 
		echo "display2 successfully called!";
		$tableresults = $myTableAdmin -> displayTable ($userinfo[in_table]);
		echo "variable tableresults assigned successfully<br>\n";
		displayResultSet ($resultset);
		echo "displayResultSet successfully called";
		break;

default:
  echo "<pre>DEBUG: \$userinfo[action] = ".$userinfo[action]."\n";
  print_r(debug_backtrace());
  echo "</pre>";

}
echo "action: $action";
echo "<br>";
echo "userinfo[in_table]: $userinfo[in_table]";
echo "<br>\n";

I'm getting the following output:

DEBUG: $userinfo[action] = display2
Array
(
)

action: display2
userinfo[in_table]: user

So I'm pretty sure the case 'describe2' is never being picked up. I've checked for extra space around the action.