problem with dropdown list

[romeomussluv]

Can some body help me with this drop down list function?

I'm new to PHP and any help is greatly appreciated.
i created a function to pull data from mySQL and then create a drop down box to display it. for some reason, the options are not in the drop down, they are text outside of the dropdown.

Below is the script that i use.

/**************

function displayUsersDropDown($Where){
global $database;
$q = "SELECT username "
."FROM ".TBL_USERS;

$q = $q." ".$Where." ORDER BY userlevel DESC,username";
$result = $database->query($q);
/ Error occurred, return given name by default /
$num_rows = mysql_numrows($result);
if(!$result || ($num_rows < 0)){
echo "<option value=\"Error displaying info\">Error displaying info</option>";
return;
}
if($num_rows == 0){
echo "<option value=\"Database table empty\">Database table empty</option>";
return;
}
echo "<select>";
/ Display table contents /
for($i=0; $i<$num_rows; $i++){
$uname = mysql_result($result,$i,"username");
echo "<option value=\"".$uname."\">$uname</option>";
}
echo "</select>";
}
**************/

the text come out like this
<select name="deluser"><option value="[e-mail]">[e-mail]</option><option value="[e-mail]">[e-mail]</option><option value="[e-mail]">[e-mail]</option></select><input type="hidden" name="subdeluser" value="1">

i tried other editor and the options show up in the dropdown while my page does not show them int he dropdown. Am I doing something wrong?

Thank you for your help in advance.

[bretticus]

Strange....your text that comes out is formatted correctly: option tags inside a select tag. the only way I can see things popping out of the select tag is in your if statements where checking for errors. But even then, you have a return which would prevent the empty select tag from appearing at the bottom.

I should mention a few things:

if you are going to use the if statements, you should wrap the option tags in select tags if you want to see them in your browser as drop-downs with the error message.

mysql_result is inefficient for multiple records. I would consider using mysql_fetch_assoc.

Finally, as a matter of brevity in your code...PHP supports "combined" assignment operators. Meaning instead of doing this...

$q = $q." ".$Where." ORDER BY userlevel DESC,username";

You can do this (which is far more common in PHP code)...

$q .= $Where." ORDER BY userlevel DESC,username";

[romeomussluv]

Thank you for the reply.

i changed it to use mysql_fetch_assoc and it works just like the old one. however, i'm still having a problem with the dropdown. If i don't have the <select> then it works fine, the options fall into the drop down list. however, if i have the <select>, then it breaks. I need the <select> there for the name and id attribute to retrieve the selected value in the post back. do you have any suggestions for the work around?

Any suggestion or hint would be appreciated. Thanks.

[NogDog]

Maybe there's a missing or extra HTML tag elsewhere that's messing things up? Try running the page's output through the HTML Validator to see if it turns up anything "interesting."