file upload code not working

[brisykes]

Hello everyone i need some help with this code its a multiple file upload code max amount of files is 10 but it wont even upload one i just get the database info added about 500,000 times. Code is below

 $query = mysql_query("INSERT INTO `listings` (state,name,location,price,typeofhome,bathrooms,bedrooms,basement,garage,features,remarks,lotsize,mlsid,hot) VALUES ('$status','$_POST[title]','$_POST[location]','$_POST[price]','$_POST[typeofhome]','$_POST[bathrooms]','$_POST[bedrooms]','$_POST[basment]','$_POST[garage]','$_POST[features]','$_POST[remarks]','$_POST[lot]','$_POST[mls]','$ishot')") or die("Failed because of ".mysql_error());
                        if ($query==TRUE) {
								$id = mysql_insert_id();
								$tmp = md5(rand());
								$upload_dir = "pics/";
								mysql_query("UPDATE `listings` SET `imgloco` = '$upload_dir' WHERE `id` = '$id'");
								$num = $_POST['picnum'];
								$i = 1;
								while ($i>=$num) {
									$file_tmp = $_FILES['pic'.$i]['tmp_name'];
									$file_name = $_FILES['pic'.$i]['name'];
									$loco = $upload_dir.$tmp;
									move_uploaded_file($file_tmp,$loco);
									mysql_query("INSERT INTO `list_images` (lid,location) VALUES ('$id','$loco')");
									$i++;
								}
                                redirect("templates/dellisting.php");
                        } else {
                                redirect("templates/addlisting.php");
                        } 

[bradgrafelman]

I would suggest that you get rid of the 'picnum' element and instead use an array of FILE elements. Example:

File 1: <input type="file" name="pic[]"><br>
File 2: <input type="file" name="pic[]"><br>
<!-- etc. for all files -->

Then, in PHP, you could process all uploads like so:

for($i = 0; isset($_FILES['pic']['name'][$i]); $i++) {
    //handle file here
}

Here's an example of what the $_FILES array would look like using this method:

Array
(
    [pic] => Array
        (
            [name] => Array
                (
                    [0] => filter1.enc
                    [1] => default.reg
                )

        [type] => Array
            (
                [0] => application/octet-stream
                [1] => application/octet-stream
            )

        [tmp_name] => Array
            (
                [0] => X:\apache\tmp\php\upload\php7D3.tmp
                [1] => X:\apache\tmp\php\upload\php7D4.tmp
            )

        [error] => Array
            (
                [0] => 0
                [1] => 0
            )

        [size] => Array
            (
                [0] => 354
                [1] => 459
            )

    )

)

[brisykes]

Awesome thanks so much for the help.

[brisykes]

Hey guys thanks for the help on this btw, the files upload perfectly now and everything works fine except i cant get this thing to update certain fields in the mysql db and the field names correspond to the file index array. see below (the line that has mysql_query("UPDATE listings SET pic$i = '$loco' WHERE id = '$id'");

if ($query==TRUE) {
								$id = mysql_insert_id();
								$tmp = md5(rand());
								$upload_dir = "pics/$tmp/";
								mkdir($upload_dir);
								chmod($upload_dir, 0777);
								mysql_query("UPDATE `listings` SET `imgloco` = '$upload_dir' WHERE `id` = '$id'");
								for($i = 0; isset($_FILES['pic']['name'][$i]); $i++) { 
									$file_tmp = $_FILES['pic']['tmp_name'][$i];
									$file_name = $_FILES['pic']['name'][$i];
									$loco = $upload_dir.$file_name;
									if ($file_tmp != "" && $file_name != "") {
										move_uploaded_file($file_tmp,$loco);
										mysql_query("UPDATE `listings` SET `pic$i` = '$loco' WHERE id = '$id'");
									}
								}
                                redirect("templates/dellisting.php");
                        } else {
                                redirect("templates/addlisting.php");
                        }