Including partial scripts

tyhoerr

Hello, I've been trying to show/hide content based on certain variables. Originally I had it coded like the following and it worked fine:

<?php  if ($login==admin) { ?><a  href="index.php?Category=<?php echo "$Category"; ?>&amp;ID=<?php echo "$ID" ?>&amp;edit=yes">Edit</a><?php } ?>

So basically if the variable $login is equal to admin then show the stuff. (in the real thing there's more variables than just $login==admin, I only included that once for simplicity)

But when I tried to put it into a separate file (permissions.php) like the following...

<?php include_once("permissions.php"); ?><a  href="index.php?Category=<?php echo "$Category"; ?>&amp;ID=<?php echo "$ID" ?>&amp;edit=yes">Edit</a><?php } ?>

permissions.php:

<?php if ($login==admin) { ?>

Then it errors: Parse error: syntax error, unexpected '}' in /home/thoerr/public_html/attempt2/index.php on line 48 (line 48 is what I'm showing).

I thought the include function drops the code in before it executes the page? if that's the case, it should be providing the { to make the ending } valid -- just like before I split it into a separate file when it was working. Am I missing something?

nrg_alpha

For me personally, I am not a fan of mixing PHP and XHTML like you have done.. I would keep it all in a block of php code (that could be a separte include file)...

<?php
if($login == admin){
   echo '<a href=\'index.php?Category=' .  $Category . '&amp;ID=' . $SID . '&amp;edit=yes\'>Edit</a>';
}
?>

Would this not work?

Cheers,

NRG

P.S when you are inserting PHP code into your post, first hit the 'PHP' button found along the top... this will insert [ PHP] and [/ PHP] into the post.. then simply dump your PHP code inbetween those tags.. this will format the coode nice and pretty like in the post, making it easier to read 🙂

lazzerous

You could take it a step farther with the ternary operator

<?php
echo (isset($login) && $login == admin) ? "<a href=\"index.php?Category={$Category}&amp;ID={$SID}&amp;edit=yes\">Edit</a>" : '';
?>

nrg_alpha

That would work too 🙂

(We both forgot the dollar sign for the admin variable...oops)

Cheers,

NRG

tyhoerr

Thanks for the replies guys! The only problem is, I use the code in multiple places around different code I want to execute or disable (depending on the permissions).

In the example I've given the Edit link is only displayed if the Session is set to Administrator (which defines $login = 'admin' earlier in the code).

But, I use the same permissions code ($login==admin) on the edit page to bring up and error if the session is not set to Administrator. The purpose of using an include is so that I only have to change the permissions (which will change quite frequently) on one page and it will affect all instances, no matter what it's around. That way I don't have to manually go in and paste the new permissions on every page.

The actual permissions are much longer and subject to change and get more complicated (especially when I start adding permission on individual articles rather than categories- you can see why I'd prefer to keep it all in one location 🙂 ). Currently are as follows:

 if (
	$login==admin 				// ADMINISTRATOR -- No Restrictions
 || (
	$login==registered&&			// REGISTERED -- Can Only Edit Services Pages
		$Category==Services
		)
 || (
	$login==marketing&&			// MARKETING -- Can Only Edit Products
		$Category==Products
		)
 || (
	$login==hr&&					// HUMAN_RESOURCES -- Can Only Edit Employment Pages
		$Category==Employment
		)
) {

Any suggestions or why what I was trying in my first post isn't working? Thanks again

nrg_alpha

Ok.. well, let's step back and re-examin your output:

<a  href="index.php?Category=<?php echo "$Category"; ?>&amp;ID=<?php echo "$ID" ?>&amp;edit=yes">Edit</a>

What we have in this is example is that there is going to be category variable and an ID variable, right? So why not have an include file that php checks for certain situations and plugs the end results into the code above? (I am assuming Admin, Servies, Product etc.. are constants due to lack of $)...

so for example:

loginCheck.php (this would be your include file):

 if ($login == Admin){   // ADMINISTRATOR -- No Restrictions
   $category = 'All' && $SID = 'a'; // just using hypothetical varaibles and values here...
} else if ($login == Registered && $categoryMod == Services){ // REGISTERED -- Can Only Edit Services Pages 
   $category == Services && $SID = 'b'; 
 } else if ($login == Marketing && $categoryMod == Products){  // MARKETING -- Can Only Edit Products 
   $category == Products && $SID = 'c'; 
} else if ($login == hr && $categoryMod == Employment){ // HUMAN_RESOURCES -- Can Only Edit Employment Pages 
   $category == Hr && $SID = 'd'; 
}

Then in your page:

 echo '<a href=\'index.php?Category=' .  $category . '&amp;ID=' . $SID . '&amp;edit=yes\'>Edit</a>';

This way, if you need to make modifications to the login and category checks, you simply modify the loginCheck.php and the rest just plugs in.. would that work?

Cheers,

NRG

tyhoerr

Sorry, I should have explained everything more clearly. 🙁

The way I have it set up, each page(or article) has a Category and ID number. Example:

index.php?Category=Home&ID=1 // Home Page
index.php?Category=About_Us&ID=1 // First Article in About_Us category - So happens to be "History"
index.php?Category=About_Us&ID=2 // Second Article in About_Us - "Civic Involvement"
index.php?Category=Services&ID=1 // First Article in Services category

So on an so forth. The index.php calls the content from a table in my mysql database using the category and ID to find it. For this reason, the ID # must remain in tact. If the category or ID is not set, I have instructed the the category to default to Home and ID to default to 1, that way there will always be a category and ID for every page.

Since I had this identification system implemented, I just used the same variables. For example - according the the permissions.php, registered users have the edit button displayed if the session is set to Registered AND $Category is equal to Services. The $category will only equal services when they are viewing an article in the services category (obviously).

(This is the code at the top to check if the session is set to registered: )

if (isset($_SESSION['registered'])
   || $_SESSION['registered'] == true) {
$login = registered;
}

I should have fully explained everything before posting- apologies! Thanks again for your help, It is much appreciated

nrg_alpha

tyhoerr;10879428 wrote:

if (isset($_SESSION['registered'])
   || $_SESSION['registered'] == true) {
$login = registered;
}

I'll have to brain storm this a little later and see what I come up with.. but with regards to that last snippet.. be careful... you are in essence saying: if $SESSION['registered'] is set, OR $SESSION['registered'] is true...

If $_SESSION['registered'] is true, then it is set.. in cannot be true yet not set..
so you can simply do this:

if (isset($_SESSION['registered'])){
   $login = registered;
}

Granted, at this point, there is no additional conditional checks as to what that variable is.. so if it needs to be set AND true, simply do this:

if (isset($_SESSION['registered']) && $_SESSION['registered'] == true){
   $login = registered;
}

This works because $SESSION['registered'] can be set, yet flagged as false:

$_SESSION['registered'] == false;

tyhoerr

Ah, I suppose that doesn't make much sense the way I have it! Who knows what I was thinking 🙂 Thanks for the suggestion, I'll change it.

I'll continue trying to resolve the problem too, thanks for taking the time to help me out. I anxiously await your thoughts/solution

tyhoerr

Any luck? I still haven't found a solution.

nrg_alpha

Sorry dude.. I havn't found a solution either 🙁

Keep hammering at it.. A solution is bound to come up (be it by you or another forum member). I have found myself stuck for a week at a time from time to time. Don't give up.

Cheers,

NRG