[RESOLVED] static method not seeing global array

jdc44

Cheers all.

I have a class (php5) which uses an array of names. This array is declared at the top of the script outside of the class. In a public static method I check to see if a name being passed in is in the array. I'm getting an error that tells me the second argument to my in_array() must be an array. Apparently the code is not seeing my array.

I'm hoping someone can tell me why. If I move the array to the method, it works, but I thought it should work the first way.

<?php
$team_names = array('John','Bill','Bob','Ted','Jim');

class web_team{
  // some class code here //

   public static function is_team_member($name){
      global $team_names
      return in_array($name, $team_names);
   }

}

Thanks for any tips!!

m_tt

I ran this with no problems.. there is a syntax error in your code above (after $team_names) but that would not cause your in_array error. Hm...

$team_names = array('John','Bill','Bob','Ted','Jim');

class web_team{
  // some class code here //

   public static function is_team_member($name){
      global $team_names;
      return in_array($name, $team_names);
   }

}

$o = new web_team;
echo ( $o->is_team_member( 'Bob' ) ? "True" : "False" );

NogDog

Works OK for me, too, once the missing ";" is inserted. However, my "tip" would be: don't use globals. 🙂 (The use of "global" like that is completely antithetical to the loose-coupling objectives of object-oriented coding.)

jdc44

Thanks for the help.

In my code, the missing ';' is there. The typo is a product of copy/paste.

I've opted to put the array in the static function. I had visions of possibly using the array in other functions and that is why I hoped to declare it globably.

Note: I tried to declare the array inside the class using public static $team_name = arrar(...) and private static $team_names=... All to no avail.

Thanks for the help though. I'm good.

laserlight

I had visions of possibly using the array in other functions and that is why I hoped to declare it globably.

Have the array passed to your functions. Use pass by reference if necessary.