Feedback on News class

Jason_Batten

Hey all,

I would just like to grab a few opinions, a bit of feedback on the following class structure, is it any good? 😕 I know it is basic but is it a good base for extending? I plan to have a News_Validator class as well for screening input.

The - in_news_title etc. indicate method arguments.

Class:

News_Manager

no attributes
no set constructor

create_news()
- in_news_title
- in_news_category
- in_news_content

return true

update_news()
- in_news_id
- in_news_title
- in_news_category
- in_news_content

return true

delete_news()
- in_news_id

return true

get_news_article()
- in_news_id

return array()

get_all_news()
return array()

NogDog

I'd probably consider having a NewsItem class which would be instantiated for each item, then the NewsManager class might be used to coordinate multiple NewsItem objects.

Jason_Batten

Okay I have converted it to use the CRUD model, What about something like this?

Class Module_CRUD
{
	public $data = '';
	public $db_structure = '';
	public $db_table_name = '';

public function create
(
	$in_data
)
{
	$qry_data = compile_data_rtrim($in_data);

	$qry_columns = compile_columns_rtrim($this->db_structure);

	$qry = "INSERT INTO $this->db_table_name ($qry_columns) VALUES $qry_data";

	return $qry;
}
}

Class News_Manager extends Module_CRUD
{
	public $db_structure = array('news_title', 'news_category', 'news_content');
	public $db_table_name = 'news';
}

Class News
{
	public $news_title;
	public $news_category;
	public $news_content;
	public $news_array;

public function __construct
(
	$in_news_title,
	$in_news_category,
	$in_news_content
)
{
	$this->news_title = $in_news_title;
	$this->news_category = $in_news_category;
	$this->news_content = $in_news_content;

	$this->news_array = array($in_news_title, $in_news_category, $in_news_content);
}

public function create_news()
{
	$create = new News_Manager();

	return $create->create($this->news_array);
}
}

$news = new News('test', '1', 'testing the news');

echo $news->create_news();