[RESOLVED] Undefined Variable Q

[closer2u2]

This function gives me related videos

$ch=explode(" ",$list[2]);



if(count($ch)>1)for($i=1;$i<count($ch);$i++)$chnl.="or keyword like '%$ch[$i]%'";

$sql="SELECT VID from video where type='public' $active and (keyword like '%$ch[0]%' $chnl) order by VID asc";

This function works properly, but gives me a notive in my error log:

PHP Notice: Undefined variable: chnl in /var/www/....../video.php on line 445

where line 445 corresponds with

if(count($ch)>1)for($i=1;$i<count($ch);$i++)$chnl.="or keyword like '%$ch[$i]%'";

I can't seem to see how else I should make $chnl a defined var to start with?
Any pointers would be appreciated!

[NogDog]

The ".=" operator appends to an existing string. If $chnl is not yet defined/used in the script, just use "=" instead of ".=".

[sneakyimp]

that notice is not a big deal. a notice is just there as a bit of coaching to tell you that you forgot to create the variable before you try to concatenate something onto it. i'm guessing that line represents the very first time this script has referred to $chnl. If so, try putting this line right before that line:

$chnl = '';

You can also turn off the notice by editing your PHP.ini file and setting error_reporting like this:

error_reporting = E_ALL & ~E_NOTICE

or, alternatively, you can set the error level with [man]error_reporting[/man]:

// Report all errors except E_NOTICE
// This is the default value set in php.ini
error_reporting(E_ALL ^ E_NOTICE);

[NogDog]

sneakyimp;10880974 wrote:

...You can also turn off the notice by editing your PHP.ini file and setting error_reporting like this:

error_reporting = E_ALL & ~E_NOTICE

or, alternatively, you can set the error level with [man]error_reporting[/man]:

// Report all errors except E_NOTICE
// This is the default value set in php.ini
error_reporting(E_ALL ^ E_NOTICE);

But I'd much rather see you fix the code than just ignore it. :p

[closer2u2]

NogDog, I agree, I much more prefer a clean code.

When I just launched the whole site, it gave me 27MB on PHP notices (!) per day
I got most of them corrected, as they were straight forward to understand, but I'm still on 5MB now

$chnl was not yet defined so I changed the ".=" to "="

Will check my error logs to see if this was the issue, thanks again NogDog

[bradgrafelman]

closer2u2 wrote:

I changed the ".=" to "="

Note that this was not the fix, and will negate the point of having a loop.

The point NogDog was trying to make was that on the first iteration of the loop, $chnl hadn't been initialized/created yet, so the concatenating operator (".=") was trying to append to a non-existant variable.

The solution was to initialize the variable before the loop began, e.g. putting $chnl = ''; before the for() statement.

[NogDog]

Heh...I didn't even see that it was within a loop -- the danger of using one-liners. 😉