IP to country problem

[saud]

Whenever I run this script I get wrong results for country.
all the database and files can be downloaded from http://software77.net/cgi-bin/ip-country/geo-ip.pl
But the Perl script gives the correct result. All the files are listed there.

If i change the $addr to "213.6.49.205" it shows wrong results and should show Norway.

<?php 

// Get the surfer's ip address 
$addr = getenv("REMOTE_ADDR"); 
echo "Your IP, IPv4: " . $addr . "
\n"; 

$ip = sprintf("%010u", ip2long($addr)); 
echo "Your IP, numerical: " . $ip . "

\n"; 

// Initiate the timer 
$time_start = microtime_float(); 

// Open the csv file for reading 
$handle = fopen("IpToCountry.csv", "r"); 

// Load array with start ips 
$row = 1; 
while (($buffer = fgets($handle, 9096)) !== FALSE) { 
  $array[$row] = $buffer; 
  $row++; 
} 

// Time loading 
$time_end = microtime_float(); 
$time = substr($time_end - $time_start, 0, 7); 
echo "Array with " . $row . " start ips loaded in $time seconds

\n"; 

// Locate the row with our ip using bisection 
$row_lower = '0'; 
$row_upper = $row; 
while (($row_upper - $row_lower) > 1) { 
  $row_midpt = (int) (($row_upper + $row_lower) / 2); 
  $buffer = $array[$row_midpt]; 
  $start_ip = sprintf("%010u", substr($buffer, 1, strpos($buffer, ",") - 1)); 
  if ($ip >= $start_ip) { 
    $row_lower = $row_midpt; 
  } else { 
    $row_upper = $row_midpt; 
  } 
} 

// Time locating 
$time_end = microtime_float(); 
$time = substr($time_end - $time_start, 0, 7); 
echo "Row with your ip (# " . $row_lower . ") located after $time seconds

\n"; 

// Read the row with our ip 
$buffer = $array[$row_lower]; 
$buffer = str_replace("\"", "", $buffer); 
$ipdata = explode(",", $buffer); 
echo "Data retrieved from the csv file:
\n"; 
echo "ipstart = " . sprintf("%010u", $ipdata[0]) . "
\n"; 
echo "ipend = " . sprintf("%010u", $ipdata[1]) . "
\n"; 
echo "registry = " . $ipdata[2] . "
\n"; 
echo "assigned = " . date('j.n.Y', $ipdata[3]) . "
\n"; 
echo "iso2 = " . $ipdata[4] . "
\n"; 
echo "iso3 = " . $ipdata[5] . "
\n"; 
echo "country = " . $ipdata[6] . "

\n"; 

// Close the csv file 
fclose($handle); 

// Total execution time 
$time_end = microtime_float(); 
$time = substr($time_end - $time_start, 0, 7); 
echo "Executing the whole script took $time seconds\n"; 

function microtime_float() 
{ 
   list($usec, $sec) = explode(" ", microtime()); 
   return ((float)$usec + (float)$sec); 
} 

?>

The thing is that IP is correctly mentioned in the database, just the PHP script is not reading the database correctly, while the CGI script is doing it correctly. DO a test yourself by downloading both the files, they are free too.
http://webnet77.com/scripts/geo-ip/IP-country-FREE.zip

Database download: http://software77.net/cgi-bin/ip-cou...ction=download

Main website: http://software77.net/cgi-bin/ip-country/geo-ip.pl

[Ashley_Sheridan]

Saud, you could probably really benefit from putting the IP2Country flatfile database into a MySQL or other relational type database. The SQL query would handle most of the legwork for you, without the need for slow file access and lookups, especially for a flat file as large as the IP2Country one is. I'm using it on my site at the moment to track visitors, and the code is like this:

$ip=$_SERVER['REMOTE_ADDR'];
$ipnum = ip2long($ip);

$query = "SELECT * FROM `origin` WHERE $ipnum >= `start` AND $ipnum <= `end`";
$result = mysql_query($query);

[Piranha]

Ashley, that query won't work if you store the ip address as numerical, ie 192.168.1.1. There is a problem when you don't have 3 numbers in each part. As an example, let's say that I have ip 192.168.150.1 and you have two rows in the database:

From                To
192.168.0.0     192.168.3.0
192.168.150.0 192.168.150.255

Now both the rows would be true with that query. You need either to force every part of the IP to 3 numbers or store the binary/numerical representation.

[Ashley_Sheridan]

Yeah, that's why you want the database storing the IP addresses as IP numbers instead. The queries are much faster. For example, the IP address 169.6.7.20 becomes the IP number 2835744532. Now MySQL is able to treat the value as a number and perform less than and greater than operations on it. You need to use complex string matching queries if you want to match the IP address in it's dotted decimal notation, which just isn't programatically efficient.