[RESOLVED] Faster Conversion Code?

[mramonster]

I have a form to submit information to database. One of the fields is States (the abbreviations) from a drop-down menu that for display purposes I need to Convert from "ST" to "State Name (ST)". I am using the following code, however it takes the script a lot longer to go through each "if" statement. Is there a faster way to do this?

//Convert State from "ST" to "State (ST)"
if ( $e_state == "AL" ) {
$e_state_long = "Alamaba (AL)";
	}
if ( $e_state == "AK" ) {
$e_state_long = "Alaska (AK)";
	}
if ( $e_state == "AZ" ) {
$e_state_long = "Arizona (AZ)";
	}
if ( $e_state == "AR" ) {
$e_state_long = "Arkansas (AR)";
	}

etc.....

[mramonster]

Would it be faster to add a else statement after each one?

[NogDog]

A [man]switch[/man] might be faster. Another option would be to define an array where each element's key is the abbreviation and the value is the long name.

[mramonster]

Ahh! that would work a lot better!

Would this be the correct way to do it?

switch ($e_state){
	case "AL":
		Alamaba (AL);
	case "AK":
		Alaska (AK);
	case "AZ":
		Arizona (AZ);

or

switch ($e_state){
	case "AL":
		"Alamaba (AL)";
	case "AK":
		"Alaska (AK)";
	case "AZ":
		"Arizona (AZ)";

I am trying to insert this into a database like that to where I have 2 state rows - ST and State Name (ST). I figured this would be more efficient that doing an include for each time I need to do the State Conversion.

[mramonster]

Is this array version right?

$e_state_conv = array("states" =>
array (
    AL=> "Alabama (AL)",
    AK=> "Alaska (AK)",
    AR=> "Arizona (AR)"),
);

$e_state_long = $e_state_conv[states]['$e_state'];

[leatherback]

you need quotes around the keys:
'al'=>'alabama'

[NogDog]

mramonster;10881547 wrote:

Is this array version right?

$e_state_conv = array("states" =>
array (
    AL=> "Alabama (AL)",
    AK=> "Alaska (AK)",
    AR=> "Arizona (AR)"),
);

$e_state_long = $e_state_conv[states]['$e_state'];

Yes, something along that lines is probably what I'd do, though the extra array dimension would seem unnecessary:

$states = array(
   'AL' => "Alabama (AL)",
   'AK' => "Alaska (AK)",
   'AR' => "Arizona (AR)"
);
if(isset($states[$e_state]))
{
   $e_state_long = $states[$e_state];
}
else
{
   // invalid value received
}

[__ins0__]

the fastest measured variation is the ternaer operator.... 😉

Bsp.: Single If:

($e_state == "AL")? $e_state_long = "Alamaba (AL)" : NULL; 
($e_state == "AK")? $e_state_long = "Alaska (AK)" : NULL; 
($e_state == "AZ")? $e_state_long = "Arizona (AZ)" : NULL; 
($e_state == "AR")? $e_state_long = "Arkansas (AR)" : NULL; 

Bsp.: If else:

($e_state == "AL")? $e_state_long = "Alamaba (AL)": 
	($e_state == "AK")? $e_state_long = "Alaska (AK)": 
		($e_state == "AZ")? $e_state_long = "Arizona (AZ)": 
			($e_state == "AR")? $e_state_long = "Arkansas (AR)" : NULL; 

greez ins0!

[laserlight]

The insignificant speed gain you get by the use of nested ternary operators (if there is such a gain in the first place) is completely outweighed by the code obfuscation that results.

[Weedpacket]

Not only that, but

($e_state == "AL")? $e_state_long = "Alamaba (AL)":
    ($e_state == "AK")? $e_state_long = "Alaska (AK)":
        ($e_state == "AZ")? $e_state_long = "Arizona (AZ)":
            ($e_state == "AR")? $e_state_long = "Arkansas (AR)" : NULL; 

doesn't even work.

[__ins0__]

ah my mistake, the tenär operator is new for me

....and something new learned xD

sry

[mramonster]

Thanks NogDog! I was able to get it to work and tested it with an echo of $e_state_long

//Convert State from "ST" to "State (ST)"
$states = array ( 
	'AL' => "Alabama (AL)",
	'AK' => "Alaska (AK)",
	'AZ' => "Arizona (AZ)",
	'AR' => "Arkansas (AR)",
	'CA' => "California(CA)",
	'CO' => "Colorado (CO)",
	'CT' => "Connecticut (CT)",
	'DC' => "Washington D.C. (DC)",
	'DE' => "Delaware (DE)",
	'FL' => "Florida (FL)",
	'GA' => "Georgia (GA)",
	'HI' => "Hawaii (HI)",
	'ID' => "Idaho (ID)",
	'IL' => "Illinois (IL)",
	'IN' => "Indiana (IN)",
	'IA' => "Iowa (IA)",
	'KS' => "Kansas (KS)",
	'KY' => "Kentucky (KY)",
	'LA' => "Louisiana (LA)",
	'ME' => "Maine (ME)",
	'MD' => "Maryland (MD)",
	'MA' => "Massachusetts (MA)",
	'MI' => "Michigan (MI)",
	'MN' => "Minnesota (MN)",
	'MS' => "Mississippi (MS)",
	'MO' => "Missouri (MO)",
	'MT' => "Montana (MT)",
	'NE' => "Nebraska (NE)",
	'NV' => "Nevada (NV)",
	'NH' => "New Hampshire (NH)",
	'NJ' => "New Jersey (NJ)",
	'NM' => "New Mexico (NM)",
	'NY' => "New York (NY)",
	'NC' => "North Carolina (NC)",
	'ND' => "North Dakota (ND)",
	'OH' => "Ohio (OH)",
	'OK' => "Oklahoma (OK)",
	'OR' => "Oregon (OR)",
	'PA' => "Pennsylvania (PA)",
	'RI' => "Rhode Island (RI)",
	'SC' => "South Carolina (SC)",
	'SD' => "South Dakota (SD)",
	'TN' => "Tennessee (TN)",
	'TX' => "Texas (TX)",
	'UT' => "Utah (UT)",
	'VT' => "Vermont (VT)",
	'VA' => "Virginia (VA)",
	'WA' => "Washington (WA)",
	'WV' => "West Virginia (WV)",
	'WI' => "Wisconsin (WI)",
	'WY' => "Wyoming (WY)"
);
if(isset($states[$e_state]))
{
   $e_state_long = $states[$e_state];
} else {
   // invalid value received
}