[RESOLVED] Dropdown

[TheCase]

Hi,

This is my code

$lesscurrentpoints = $currentpoints - 1;

$fetchmorepoints = "SELECT * FROM aacl_team WHERE $ladder='0' AND $currentpointsp < $lesscurrentpoints" or trigger_error("Query: $fetchmorepoints\n<br />MySQL Error: ". mysql_error());
$fetchmorepoints2 = mysql_query ($fetchmorepoints);
while ($fetchmorepoints3 = mysql_fetch_assoc($fetchmorepoints2)) {
$morepointteam = $fetchmorepoints3['teamname']; 
$morepointteamid = $fetchmorepoints3['id']; 

$morecurrentpoints = $currentpoints + 1;

$fetchlesspoints = "SELECT * FROM aacl_team WHERE $ladder='0' AND $currentpointsp > $morecurrentpoints" or trigger_error("Query: $fetchlesspoints\n<br />MySQL Error: ". mysql_error());
$fetchlesspoints2 = mysql_query ($fetchlesspoints);
while ($fetchlesspoints3 = mysql_fetch_assoc($fetchlesspoints2)) {
$lesspointteam = $fetchlesspoints3['teamname']; 
$lesspointteamid = $fetchlesspoints3['id']; 

<select name=\"cteam\">
<option value=\"$morepointteamid\">$morepointteam</option>
<option value=\"$lesspointteamid\">$lesspointteam</option>
</select>

I think im doing it wrong because when there is no team for more than or less than the drop down doesnt show if the team had the most points or the least I should just show the one team. Any ideas on how to fix this

Thanks

[Krik]

Guess I have a couple thoughts

I am thinking there is some information missing that may fill inthe picture but here is what I have.

First, whatever column $ladder is referencing is it set to "0" if none of them are no records will be retured.

Second, is $currentpointsp spelled right the "p" on the end may not belong. Of course that may be the way the variable is spelled but as we do not see it anywere there is no way to tell.

Third, on

<select name="cteam\">

you escaped the last quotation mark in the name but not the first.

Other than that it looks all good. Maybe make sure "teamname" and "id" are spelled right and capitlize if needs be.

[TheCase]

The 0 represents the value 0 ... as if it was set to 1 then the team would be unavailable to play so its not what you thought.

Secondly $currentpointsp there is ment to be a p

Thirdly, your right thats a typo. The dropdown is displaying correct though if the team points is 5 and there is a team with lower and higher points it only when there is no team with higher or lower points instead of just display one team like the higher, if there was no lower it displays nothing. Is this clear?

Thanks

[Krik]

I think im doing it wrong because when there is no team for more than or less than the drop down doesnt show if the team had the most points or the least I should just show the one team.

So you are wanting to dispaly the teams that equal the amount that was submited.

I think I found your problem then

Ok lets brake it down a bit..

So if $currentpoints is 5 (the user submited value) that would make $lesscurrentpoints 4 and therby $currentpointsp has to equal 3 or lower. For a record to be called.

So your logic looks to be backwards

As well there is an easier way to get the records without some of the math

Change the AND like so

$fetchmorepoints = "SELECT * FROM aacl_team WHERE $ladder='0' AND $currentpointsp <= $currentpoints" or trigger_error("Query: $fetchmorepoints\n<br />MySQL Error: ". mysql_error()); 

The <= will make it so $currentpointsp comes back true if it is less than (<) or equal to (=) $currentpoints

And now you can get rid of this line of code

$lesscurrentpoints = $currentpoints - 1;

hope that helps

[TheCase]

Great that optimised the code but theres an error.

If $currentpoints is 5 and there is only a team with 6 points I would like just one team displayed in the drop down but as I have coded the dropdown badly if it cannot get 2 teams out of the db it returns blank how can I fix this

<select name=\"cteam\">
<option value=\"$morepointteamid\">$morepointteam</option>
<option value=\"$lesspointteamid\">$lesspointteam</option>
</select>

Thanks

[Krik]

I am not sure were that is being called in the code

The

<select name="cteam\">

needs to be before the while loops.

And the

<option value=\"$morepointteamid\">$morepointteam</option>

needs to be in the in the $fetchmorepoints while loop.

And then the

<option value=\"$lesspointteamid\">$lesspointteam</option>

needs to be in the $fetchlesspoints while loop.

with the </select> being caled after the while loops close.

Really no place should be running the select like you you have it displayed.

One way to test if you are getting the results is to just echo out the value of each piece of data in the while loops and see what it gives. If data is missing something it wrong in the loop or the query. The trick is to work your way backwards eliminating pieces of code till you are down to a real simple query that just outputs raw data. And if it still doesn't work the query is likely the source of the issue.

My main reason for suggesting you do it that way is I suspect large segments of code are not being show and there may be an issue in some of that so striping it down to the basics getting it to work and then adding pieces back in will find the problem.

[TheCase]

Thanks for that. Let me rephrase the problem slightly so I have

$morepointteam
$lesspointteam

Now each of the variables when echoed out will display a team. How would you put it in a drop down so that if one variable happends to be blank it still shows the dropdown but with just one selection. The id has to be

$morepointteamid
$lesspointteamid

Thanks 🙂

[Krik]

So you are wanting the teams that are above and below the submited value?

[TheCase]

Yeah. I want them in a dropdown. See the code above for the dropdown I made its not right because if one variable is blank it doesnt show the dropdown with just one variable. Hope this is clear.

Thanks

[Krik]

Oh. I assumed that the only one of the the 2 queries ran based on some other part of the code and you only need one of them at a time.

I am not sure why if one was empty the other wouldn't run. I guess it could be possible that if the second while loop is inside the first that if the first is empty causing it to report false it may not run the second. The only other reason they wouldn't run is if there is another loop or if that is dictating when the queries run or if their is a loop or if that is generating the <option>'s.

I am going to merge all your code the way I would do it and see if there is a differnce

<select name="cteam">
<?php
$fetchmorepoints = "SELECT * FROM aacl_team WHERE $ladder='0' AND $currentpointsp <= $currentpoints" or trigger_error("Query: $fetchmorepoints\n<br />MySQL Error: ". mysql_error()); 
$fetchmorepoints2 = mysql_query ($fetchmorepoints); 
    while ($fetchmorepoints3 = mysql_fetch_assoc($fetchmorepoints2)) { 
    $morepointteam = $fetchmorepoints3['teamname']; 
    $morepointteamid = $fetchmorepoints3['id']; 

echo "<option value='" . $morepointteamid . "'>" . $morepointteam . "</option>";

}
$fetchlesspoints = "SELECT * FROM aacl_team WHERE $ladder='0' AND $currentpointsp >= $currentpoints" or trigger_error("Query: $fetchlesspoints\n<br />MySQL Error: ". mysql_error()); 
$fetchlesspoints2 = mysql_query ($fetchlesspoints); 
    while ($fetchlesspoints3 = mysql_fetch_assoc($fetchlesspoints2)) { 
    $lesspointteam = $fetchlesspoints3['teamname']; 
    $lesspointteamid = $fetchlesspoints3['id'];

echo "<option value='" . $lesspointteamid . "'>" . $lesspointteam . "</option>";

}
?>
</select>

That is all based on the very little that I know of your code. Like I said before I suspect other code is not present and if so the above will work on its own but with other code it may or may not break.

[TheCase]

Works great thanks

[Weedpacket]

I'm looking at this and feeling a bit dim. How is that different from simply selecting all of the records where $ladder='0' and maybe sorting them in order of decreasing $currentpoints? Except for the fact that any records where $currentpointsp==$currentpoints would appear twice?

PS. Are you really specifying column names from supplied values, or is "$ladder" a typo for "ladder" and "$currentpointsp" a typo for "currentpointsp"?

[Krik]

I'm looking at this and feeling a bit dim. How is that different from simply selecting all of the records where $ladder='0' and maybe sorting them in order of decreasing $currentpoints? Except for the fact that any records where $currentpointsp==$currentpoints would appear twice?

PS. Are you really specifying column names from supplied values, or is "$ladder" a typo for "ladder" and "$currentpointsp" a typo for "currentpointsp"?

I have too agree. As I was writing that last submition I kept wanting to make the appropriate changes but I was not sure about some of the other code that maybe being incorporated. If you notice his first post of code the ending } is missing for both the while loops. I conluded that meant what I was seeing was edited and hence stuck to the general layout. As well I had to resist several other optimizations that could have been incorperated as I did not wish to cause confusion should he have to work this into other existing code.

But your are right if that code is runing with out any modifcations It could be made into about 5 or 6 lines of code at most.

[TheCase]

The code posted is a small part of the full code. $ladder is actually a field name in the db pick edby the users selection on a dropdown

Hope this is clear

[Weedpacket]

Well, that answers the "PS" (though it seems strange to parameterise a query on a column name).