Gallery Wont Display and Dosnt error out Can someone look at this?

psionicwrath

Ok I am making a gallery page for a website of mine and it wont echo out the $gallery var like it should code is below any help anyone can provide is awesome!

<?php
//Set Requires
require("db_connect.php");
// Lets Start The Fun!
$item_list=$_GET['itemlist'];
if($item_list=""){
	$QUERY = "SELECT * FROM `Gallery` ORDER BY Sequence ASC";
	$V=MYSQL_QUERY($QUERY) or die("An Error Occured <br />".mysql_error());
	$row=mysql_fetch_array($V);
	$count=mysql_num_rows($V);
	if($count > 0){
	while($row=mysql_fetch_array($V)){
    $gallery="
			<div class='black-box'>
					<h2><em>".$row['Gallery_Name']."</em> collection</h2>
					<p><img src='".$row['Gallery_Image']."' width='120' height='105' alt='Gallery Images!' /></p>
					<p>".$row['Gallery_Info'].".</p>
					<p class='more'>> > <a href='gallery.php?itemlist=".$row['Gallery_ID']."'>More</a></p>
				</div>		
	";
	      }
		  }
	      else
	      {
		$gallery="The website manager has not added any <b>Galleries</b> to this page, Please try back at a later time.";
	      }

      }	 

  else{
	  $sql_query="SELECT * FROM `Gallery_Items` WHERE `Gallery_ID` ='$item_list' ORDER BY `Gallery_ID` ASC";
	  $Rez=mysql_query($sql_query) or die("An Error Occured <br />".mysql_error());
	  $item=mysql_fetch_array($Rez);
	  $count=mysql_num_rows($Rez);
	  if($count > 0){
	   while($item=mysql_fetch_array($Rez)){
	$gallery = "<h3>We currently have ".$item['amt_stock']." ".$row['Gallery_Name']." in stock!</h3><br><img src='gallery_images/".$item['Item_Image']."' width='100' height='100'> ".$item['Item_Info']." ";
                    }
                    }
                    else
					{
					$gallery="The website manager has not added any items to this gallery yet, Please try back at a later time.";
					}
                }


?>

Echo Statement:

	<?php
   echo($gallery);
	?>

Thank you for your help!
Brian Flores CEO,
NimbusGames,llc

Krik

Well I will just list things I see as I look though it

1) MYSQL_QUERY in the first query can not be capitalized. PHP is case sensetive

2) I see this in several places

src='".$row['Gallery_Image']."'

the single quotes ( ' ) in $row['Gallery_Image'] will cause all sorts of problems escape out those quotes. This problem is all over your code.

3) this don't look right <p class='more'>> > while not the issue still may need fixing

Weell try fixing especially the first 2 problems and see if that helps

NogDog

Krik;10882348 wrote:
Well I will just list things I see as I look though it

1) MYSQL_QUERY in the first query can not be capitalized. PHP is case sensetive

Actually, function names are not case-sensitive (although I used to be under that impression, too).

2) I see this in several places
src='".$row['Gallery_Image']."'
the single quotes ( ' ) in $row['Gallery_Image'] will cause all sorts of problems escape out those quotes. This problem is all over your code.

The quotes should not be a problem there, as the code exits out of string literal mode at the first double quote, does concatenation of the array variable, then goes back into string literal mode with the second double quote.

NogDog

To help us read the code, I've re-indented it and am posting it here within the forum's handy [noparse]

...

[/noparse] tags:

<?php
//Set Requires
require("db_connect.php");
// Lets Start The Fun!
$item_list=$_GET['itemlist'];
if($item_list="")
{
   $QUERY = "SELECT * FROM `Gallery` ORDER BY Sequence ASC";
   $V=MYSQL_QUERY($QUERY) or die("An Error Occured <br />".mysql_error());
   $row=mysql_fetch_array($V);
   $count=mysql_num_rows($V);
   if($count > 0)
   {
      while($row=mysql_fetch_array($V))
      {
         $gallery="
         <div class='black-box'>
         <h2><em>".$row['Gallery_Name']."</em> collection</h2>
         <p><img src='".$row['Gallery_Image']."' width='120' height='105' alt='Gallery Images!' /></p>
         <p>".$row['Gallery_Info'].".</p>
         <p class='more'>> > <a href='gallery.php?itemlist=".$row['Gallery_ID']."'>More</a></p>
         </div>		
         ";
      }
   }
   else
   {
      $gallery="The website manager has not added any <b>Galleries</b> to this page, Please try back at a later time.";
   }
}
else
{
   $sql_query="SELECT * FROM `Gallery_Items` WHERE `Gallery_ID` ='$item_list' ORDER BY `Gallery_ID` ASC";
   $Rez=mysql_query($sql_query) or die("An Error Occured <br />".mysql_error());
   $item=mysql_fetch_array($Rez);
   $count=mysql_num_rows($Rez);
   if($count > 0)
   {
      while($item=mysql_fetch_array($Rez))
      {
         $gallery = "<h3>We currently have ".$item['amt_stock']." ".$row['Gallery_Name']." in stock!</h3><br><img src='gallery_images/".$item['Item_Image']."' width='100' height='100'> ".$item['Item_Info']." ";
      }
   }
   else
   {
      $gallery="The website manager has not added any items to this gallery yet, Please try back at a later time.";
   }
}
?>

NogDog

psionicwrath;10882164 wrote:
Ok I am making a gallery page for a website of mine and it wont echo out the $gallery var like it should code is below any help anyone can provide is awesome!...

Where is the echo statement in relation to that main block of code?

Krik

NogDog;10882349 wrote:
Actually, function names are not case-sensitive (although I used to be under that impression, too).

Hmm, that is interesting I guess since I know variables are, and I had never see any place they were used capitallized I just assumed. I know some languages they are. Well best practice dictates lower case anyway. 😃

NogDog;10882349 wrote:
The quotes should not be a problem there, as the code exits out of string literal mode at the first double quote, does concatenation of the array variable, then goes back into string literal mode with the second double quote.

I was sure I ran into a problem with that in the past even though it does make sense they shouldn't. Now that I think about it a bit more that situation was something different entirely.

I guess ignore my previous post was only half thinking.

goes looking for brain (return is subjective) :eek:

NogDog

Quoted array indexes interpolated within a double-quoted string literal will cause a problem unless you use "complex" notations (curly braces).

// this works:
echo "Foo $var[key] bar.";
// this works:
echo "Foo {$var['key']} bar.";
// this works:
echo "Foo " . $var['key'] . " bar.";
// this does NOT work:
echo "Foo $var['key'] bar.";

// and, this works, but raises a notice-level warning and is poor practice:
echo "Foo " . $var[key] . " bar.";

Weedpacket

One thing I notice is that in both loops, $gallery is given a new value every run through the loop, throwing away the value it was given the previous run through the loop. After all that, it will only contain whatever was put in it in the last run through the loop.

On the subject of capitalisation; variable names, unlike function names, are case-sensitive, and it is good practice to be consistent in how they're named. Compare $QUERY, $sql_query, $V, $Rez, $item['amt_stock'], and $row['Gallery_Name']; and I mention the last two especially because $row['Gallery_Name'] is used without being given a value if $item_list is not empty.