[RESOLVED] mysql not updating row

sys4dm1n

Hello,

I can't figure out why my row wont update. I have pasted my entire script. The portion where it is to update the row in cms_forums is at the end. It says it has successfully posted but nothing ever happens. I am having a major brain fart and maybe a second pair of eyes could help.

Thanks.

<?php
if(!$_POST['add_submit']) {
?>
<form method="post" action="" enctype="multipart/form-data">
<?php
switch($_GET['func']) {
	default:
	case "view":
		// view
		if($_GET['a'] == "sections") {
		// show the sections
?>
<table class="list">
	<tr class="listHead">
		<td>id</td><td>section</td><td>edit</td><td>delete</td>
    </tr>
<?php
	$query = mysql_query("SELECT * FROM cms_forums");
	while($row = mysql_fetch_array($query)) {
?>
    <tr class="listData">
    	<td><?=$row['id']; ?></td><td><a href="forums.php" target="_blank"><?=substr(stripslashes($row['title']), 0, 100); ?></a></td><td><a href="?func=edit&amp;section=<?=$row['id']; ?>">edit</a></td><td><a href="?func=delete&amp;section=<?=$row['id']; ?>" onclick="return confirm('Are you sure you want to delete section <?=$row['title']; ?>?')">delete</a></td>
    </tr>

<?php
	}
		}
?>
</table>

<?php
		if($_GET['a'] == "categories") {
		// show the categories
?>

<table class="list">
	<tr class="listHead">
		<td>id</td><td>title</td><td>description</td><td>section</td><td>access</td><td>edit</td><td>delete</td>
    </tr>
<?php
	$query = mysql_query("SELECT * FROM cms_categories");
	while($row = mysql_fetch_array($query)) {
		// search for the forum id
		$sql = mysql_query("SELECT * FROM cms_forums WHERE (id LIKE '" . $row['forum'] . "')");
		while($f = mysql_fetch_array($sql)) {
?>
    <tr class="listData">
    	<td><?=$row['id']; ?></td><td><a href="/forums.php?f=<?=$row['id']; ?>" target="_blank"><?=substr(stripslashes($row['title']), 0, 50); ?></a></td><td><a href="forums.php?func=edit&category=<?=$row['id']; ?>" target="_blank"><?=substr(stripslashes($row['description']), 0, 50); ?></a></td><td><a href="?func=edit&amp;section=<?=$row['forum']; ?>"><? print $f['title']; ?></a></td><td>
		<?php
		$pgs = $row['access'];
		if ($pgs == "1") {
		echo "regular users";
		}
		if ($pgs == "2") {
		echo "rostered members";
		}
		if ($pgs == "3") {
		echo "moderators";
		}
		if ($pgs == "4") {
		echo "administrators";
		}
		if ($pgs == "0") {
		echo "disabled users";
		} 
		?>
		</td>
		<td><a href="?func=edit&amp;category=<?=$row['id']; ?>">edit</a></td><td><a href="?func=delete&amp;category=<?=$row['id']; ?>" onclick="return confirm('Are you sure you want to delete section <?=$row['title']; ?>?')">delete</a></td>
    </tr>

<?php
		}
	}
}
?>
</table>
<?php
		if($_GET['a'] == "topics") {
		// show the topics
?>

<table class="list">
	<tr class="listHead">
		<td>id</td><td>title</td><td>post</td><td>date</td><td>category</td><td>edit</td><td>delete</td>
    </tr>
<?php
	$query = mysql_query("SELECT * FROM cms_topics ORDER BY date DESC");
	while($row = mysql_fetch_array($query)) {
		// search for the category id
		$sql = mysql_query("SELECT * FROM cms_categories WHERE (id LIKE '" . $row['category'] . "')");
		while($f = mysql_fetch_array($sql)) {
?>
    <tr class="listData">
    	<td><?=$row['id']; ?></td><td><a href="/forums.php?t=<?=$row['id']; ?>" target="_blank"><?=substr(stripslashes($row['title']), 0, 38); ?></a></td><td><a href="forums.php?func=edit&topic=<?=$row['id']; ?>" target="_blank"><?=substr(stripslashes($row['post']), 0, 38); ?></a></td><td><?=date("m/d/y", $row['date']); ?></td><td><?=$f['title']?></td>
		<td><a href="?func=edit&amp;topic=<?=$row['id']; ?>">edit</a></td><td><a href="?func=delete&amp;topic=<?=$row['id']; ?>" onclick="return confirm('Are you sure you want to delete topic <?=$row['title']; ?>?')">delete</a></td>
    </tr>

<?php
		}
	}
}
?>
</table>
<?php
		if($_GET['a'] == "posts") {
		// show the posts
?>

<table class="list">
	<tr class="listHead">
		<td>id</td><td>date</td><td>user</td><td>post</td><td>edit</td><td>delete</td>
    </tr>
<?php
	$query = mysql_query("SELECT * FROM cms_posts ORDER BY date DESC");
	while($row = mysql_fetch_array($query)) {
		// search for the user id
		$user = mysql_query("SELECT * FROM cms_users WHERE (id LIKE '" . $row['author'] . "')");
		while($u = mysql_fetch_array($user)) {
?>
    <tr class="listData">
    	<td><?=$row['id']; ?></td><td><?=date("m/d/y", $row['date']); ?></td><td><a href="/user.php?id=<?=$row['author']?>" target="_blank"><?=$u['username']?></a></td><td><a href="forums.php?func=edit&post=<?=$row['id']; ?>" target="_blank"><?=substr(stripslashes($row['post']), 0, 38); ?>...</a></td>
		<td><a href="?func=edit&amp;post=<?=$row['id']; ?>">edit</a></td><td><a href="?func=delete&amp;post=<?=$row['id']; ?>" onclick="return confirm('Are you sure you want to delete this post?')">delete</a></td>
    </tr>
</table>
<?php
		}
	}
}

break;

case "edit":
if(isset($_GET['section']) || is_numeric($_GET['section'])) {
	// match the section we want to edit
?>
<table>
<?php
$query = mysql_query("SELECT * FROM cms_forums WHERE id = '".$_GET['section']."'");
$row = mysql_fetch_array($query);
?>
<td class="fieldTitle">title</td>
</tr>
<tr>
<td class="inputData"><input class="text" type="text" name="title" value="<?=$row['title']; ?>" /> </td>
<tr>
<td class="inputData" id="buttons"><input type="submit" value="Edit Section" name="add_submit" /></td>
</tr>

<?php
if($_POST['add_submit']) {
				mysql_query("UPDATE cms_forums SET title = '".$_POST['title']."' WHERE 'id' = ".$_GET['section']."") or die("Unable to update database.");
					echo "<em>Successfully updated forum section to ".$_POST['title'].".</em>\n";
				} else {
					echo "<em>Error updating item</em><br /><br />".mysql_error()."\n";
				}

		break;
}
}
}
?>

Stryker250

You put quotes around the id in your where clause. It is actually supposed to give you an sql error and not say that it has successfully updated / posted the section.

mysql_query("UPDATE cms_forums SET title = '".$_POST['title']."' 
WHERE 'id' = ".$_GET['section']."") or die("Unable to update database."); 
//Change to
mysql_query("UPDATE cms_forums SET title = '".$_POST['title']."' 
WHERE id = '".$_GET['section']."'") or die("Unable to update database.");

sys4dm1n

Stryker250,

Thanks for the response -- I see what happened. Haha -- now the issue is it doesn't do anything. I submit the form, it posts but nothing is displayed and the data isn't saved into the database.

Edit: I spelled "form" incorrectly

Stryker250

I just noticed after copying and pasting your code into notepad to check all your brackets, your update code is put inside the if statement that checks if the submit button was not clicked.

So...

<?php
if(!$_POST['add_submit']) {
?>
<form method="post" action="" enctype="multipart/form-data">
<?php
switch($_GET['func']) {
    default:
    case "view":
        // view
        if($_GET['a'] == "sections") {
        // show the sections
?>
<table class="list">
    <tr class="listHead">
        <td>id</td><td>section</td><td>edit</td><td>delete</td>
    </tr>
<?php
    $query = mysql_query("SELECT * FROM cms_forums");
    while($row = mysql_fetch_array($query)) {
?>
    <tr class="listData">
        <td><?=$row['id']; ?></td><td><a href="forums.php" target="_blank"><?=substr(stripslashes($row['title']), 0, 100); ?></a></td><td><a href="?func=edit&amp;section=<?=$row['id']; ?>">edit</a></td><td><a href="?func=delete&amp;section=<?=$row['id']; ?>" onclick="return confirm('Are you sure you want to delete section <?=$row['title']; ?>?')">delete</a></td>
    </tr>

<?php
    }
        }
?>
</table>

<?php
        if($_GET['a'] == "categories") {
        // show the categories
?>

<table class="list">
    <tr class="listHead">
        <td>id</td><td>title</td><td>description</td><td>section</td><td>access</td><td>edit</td><td>delete</td>
    </tr>
<?php
    $query = mysql_query("SELECT * FROM cms_categories");
    while($row = mysql_fetch_array($query)) {
        // search for the forum id
        $sql = mysql_query("SELECT * FROM cms_forums WHERE (id LIKE '" . $row['forum'] . "')");
        while($f = mysql_fetch_array($sql)) {
?>
    <tr class="listData">
        <td><?=$row['id']; ?></td><td><a href="/forums.php?f=<?=$row['id']; ?>" target="_blank"><?=substr(stripslashes($row['title']), 0, 50); ?></a></td><td><a href="forums.php?func=edit&category=<?=$row['id']; ?>" target="_blank"><?=substr(stripslashes($row['description']), 0, 50); ?></a></td><td><a href="?func=edit&amp;section=<?=$row['forum']; ?>"><? print $f['title']; ?></a></td><td>
        <?php
        $pgs = $row['access'];
        if ($pgs == "1") {
        echo "regular users";
        }
        if ($pgs == "2") {
        echo "rostered members";
        }
        if ($pgs == "3") {
        echo "moderators";
        }
        if ($pgs == "4") {
        echo "administrators";
        }
        if ($pgs == "0") {
        echo "disabled users";
        }
        ?>
        </td>
        <td><a href="?func=edit&amp;category=<?=$row['id']; ?>">edit</a></td><td><a href="?func=delete&amp;category=<?=$row['id']; ?>" onclick="return confirm('Are you sure you want to delete section <?=$row['title']; ?>?')">delete</a></td>
    </tr>

<?php
        }
    }
}
?>
</table>
<?php
        if($_GET['a'] == "topics") {
        // show the topics
?>

<table class="list">
    <tr class="listHead">
        <td>id</td><td>title</td><td>post</td><td>date</td><td>category</td><td>edit</td><td>delete</td>
    </tr>
<?php
    $query = mysql_query("SELECT * FROM cms_topics ORDER BY date DESC");
    while($row = mysql_fetch_array($query)) {
        // search for the category id
        $sql = mysql_query("SELECT * FROM cms_categories WHERE (id LIKE '" . $row['category'] . "')");
        while($f = mysql_fetch_array($sql)) {
?>
    <tr class="listData">
        <td><?=$row['id']; ?></td><td><a href="/forums.php?t=<?=$row['id']; ?>" target="_blank"><?=substr(stripslashes($row['title']), 0, 38); ?></a></td><td><a href="forums.php?func=edit&topic=<?=$row['id']; ?>" target="_blank"><?=substr(stripslashes($row['post']), 0, 38); ?></a></td><td><?=date("m/d/y", $row['date']); ?></td><td><?=$f['title']?></td>
        <td><a href="?func=edit&amp;topic=<?=$row['id']; ?>">edit</a></td><td><a href="?func=delete&amp;topic=<?=$row['id']; ?>" onclick="return confirm('Are you sure you want to delete topic <?=$row['title']; ?>?')">delete</a></td>
    </tr>

<?php
        }
    }
}
?>
</table>
<?php
        if($_GET['a'] == "posts") {
        // show the posts
?>

<table class="list">
    <tr class="listHead">
        <td>id</td><td>date</td><td>user</td><td>post</td><td>edit</td><td>delete</td>
    </tr>
<?php
    $query = mysql_query("SELECT * FROM cms_posts ORDER BY date DESC");
    while($row = mysql_fetch_array($query)) {
        // search for the user id
        $user = mysql_query("SELECT * FROM cms_users WHERE (id LIKE '" . $row['author'] . "')");
        while($u = mysql_fetch_array($user)) {
?>
    <tr class="listData">
        <td><?=$row['id']; ?></td><td><?=date("m/d/y", $row['date']); ?></td><td><a href="/user.php?id=<?=$row['author']?>" target="_blank"><?=$u['username']?></a></td><td><a href="forums.php?func=edit&post=<?=$row['id']; ?>" target="_blank"><?=substr(stripslashes($row['post']), 0, 38); ?>...</a></td>
        <td><a href="?func=edit&amp;post=<?=$row['id']; ?>">edit</a></td><td><a href="?func=delete&amp;post=<?=$row['id']; ?>" onclick="return confirm('Are you sure you want to delete this post?')">delete</a></td>
    </tr>
</table>
<?php
        }
    }
}

break;

case "edit":
if(isset($_GET['section']) || is_numeric($_GET['section'])) {
    // match the section we want to edit
?>
<table>
<?php
$query = mysql_query("SELECT * FROM cms_forums WHERE id = '".$_GET['section']."'");
$row = mysql_fetch_array($query);
?>
<td class="fieldTitle">title</td>
</tr>
<tr>
<td class="inputData"><input class="text" type="text" name="title" value="<?=$row['title']; ?>" /> </td>
<tr>
<td class="inputData" id="buttons"><input type="submit" value="Edit Section" name="add_submit" /></td>
</tr>

<?php
}
if($_POST['add_submit']) {
                mysql_query("UPDATE cms_forums SET title = '".$_POST['title']."' WHERE 'id' = ".$_GET['section']."") or die("Unable to update database.");
                    echo "<em>Successfully updated forum section to ".$_POST['title'].".</em>\n";
                } else {
                    echo "<em>Error updating item</em><br /><br />".mysql_error()."\n";
                }

        break;
}
}
?>

sys4dm1n

Hmm,

Thanks but that still doesn't seem to work. I am stumped. I have been sifting through this code for a good 30 minutes and I still cannot find it problem.

sys4dm1n

Ok, scratch that -- I now see "Error updating item" in the form before I even submit.

Stryker250

Try this...closed the switch statement and an if statement that were not closed. Also added the break for the last case in the switch statement.

<?php
if(!$_POST['add_submit']) {
?>
<form method="post" action="" enctype="multipart/form-data">
<?php
switch($_GET['func']) {
    default:
    case "view":
        // view
        if($_GET['a'] == "sections") {
        // show the sections
?>
<table class="list">
    <tr class="listHead">
        <td>id</td><td>section</td><td>edit</td><td>delete</td>
    </tr>
<?php
    $query = mysql_query("SELECT * FROM cms_forums");
    while($row = mysql_fetch_array($query)) {
?>
    <tr class="listData">
        <td><?=$row['id']; ?></td><td><a href="forums.php" target="_blank"><?=substr(stripslashes($row['title']), 0, 100); ?></a></td><td><a href="?func=edit&amp;section=<?=$row['id']; ?>">edit</a></td><td><a href="?func=delete&amp;section=<?=$row['id']; ?>" onclick="return confirm('Are you sure you want to delete section <?=$row['title']; ?>?')">delete</a></td>
    </tr>

<?php
    }
        }
?>
</table>

<?php
        if($_GET['a'] == "categories") {
        // show the categories
?>

<table class="list">
    <tr class="listHead">
        <td>id</td><td>title</td><td>description</td><td>section</td><td>access</td><td>edit</td><td>delete</td>
    </tr>
<?php
    $query = mysql_query("SELECT * FROM cms_categories");
    while($row = mysql_fetch_array($query)) {
        // search for the forum id
        $sql = mysql_query("SELECT * FROM cms_forums WHERE (id LIKE '" . $row['forum'] . "')");
        while($f = mysql_fetch_array($sql)) {
?>
    <tr class="listData">
        <td><?=$row['id']; ?></td><td><a href="/forums.php?f=<?=$row['id']; ?>" target="_blank"><?=substr(stripslashes($row['title']), 0, 50); ?></a></td><td><a href="forums.php?func=edit&category=<?=$row['id']; ?>" target="_blank"><?=substr(stripslashes($row['description']), 0, 50); ?></a></td><td><a href="?func=edit&amp;section=<?=$row['forum']; ?>"><? print $f['title']; ?></a></td><td>
        <?php
        $pgs = $row['access'];
        if ($pgs == "1") {
        echo "regular users";
        }
        if ($pgs == "2") {
        echo "rostered members";
        }
        if ($pgs == "3") {
        echo "moderators";
        }
        if ($pgs == "4") {
        echo "administrators";
        }
        if ($pgs == "0") {
        echo "disabled users";
        }
        ?>
        </td>
        <td><a href="?func=edit&amp;category=<?=$row['id']; ?>">edit</a></td><td><a href="?func=delete&amp;category=<?=$row['id']; ?>" onclick="return confirm('Are you sure you want to delete section <?=$row['title']; ?>?')">delete</a></td>
    </tr>

<?php
        }
    }
}
?>
</table>
<?php
        if($_GET['a'] == "topics") {
        // show the topics
?>

<table class="list">
    <tr class="listHead">
        <td>id</td><td>title</td><td>post</td><td>date</td><td>category</td><td>edit</td><td>delete</td>
    </tr>
<?php
    $query = mysql_query("SELECT * FROM cms_topics ORDER BY date DESC");
    while($row = mysql_fetch_array($query)) {
        // search for the category id
        $sql = mysql_query("SELECT * FROM cms_categories WHERE (id LIKE '" . $row['category'] . "')");
        while($f = mysql_fetch_array($sql)) {
?>
    <tr class="listData">
        <td><?=$row['id']; ?></td><td><a href="/forums.php?t=<?=$row['id']; ?>" target="_blank"><?=substr(stripslashes($row['title']), 0, 38); ?></a></td><td><a href="forums.php?func=edit&topic=<?=$row['id']; ?>" target="_blank"><?=substr(stripslashes($row['post']), 0, 38); ?></a></td><td><?=date("m/d/y", $row['date']); ?></td><td><?=$f['title']?></td>
        <td><a href="?func=edit&amp;topic=<?=$row['id']; ?>">edit</a></td><td><a href="?func=delete&amp;topic=<?=$row['id']; ?>" onclick="return confirm('Are you sure you want to delete topic <?=$row['title']; ?>?')">delete</a></td>
    </tr>

<?php
        }
    }
}
?>
</table>
<?php
        if($_GET['a'] == "posts") {
        // show the posts
?>

<table class="list">
    <tr class="listHead">
        <td>id</td><td>date</td><td>user</td><td>post</td><td>edit</td><td>delete</td>
    </tr>
<?php
    $query = mysql_query("SELECT * FROM cms_posts ORDER BY date DESC");
    while($row = mysql_fetch_array($query)) {
        // search for the user id
        $user = mysql_query("SELECT * FROM cms_users WHERE (id LIKE '" . $row['author'] . "')");
        while($u = mysql_fetch_array($user)) {
?>
    <tr class="listData">
        <td><?=$row['id']; ?></td><td><?=date("m/d/y", $row['date']); ?></td><td><a href="/user.php?id=<?=$row['author']?>" target="_blank"><?=$u['username']?></a></td><td><a href="forums.php?func=edit&post=<?=$row['id']; ?>" target="_blank"><?=substr(stripslashes($row['post']), 0, 38); ?>...</a></td>
        <td><a href="?func=edit&amp;post=<?=$row['id']; ?>">edit</a></td><td><a href="?func=delete&amp;post=<?=$row['id']; ?>" onclick="return confirm('Are you sure you want to delete this post?')">delete</a></td>
    </tr>
</table>
<?php
        }
    }
}

break;

case "edit":
if(isset($_GET['section']) || is_numeric($_GET['section'])) {
    // match the section we want to edit
?>
<table>
<?php
$query = mysql_query("SELECT * FROM cms_forums WHERE id = '".$_GET['section']."'");
$row = mysql_fetch_array($query);
?>
<td class="fieldTitle">title</td>
</tr>
<tr>
<td class="inputData"><input class="text" type="text" name="title" value="<?=$row['title']; ?>" /> </td>
<tr>
<td class="inputData" id="buttons"><input type="submit" value="Edit Section" name="add_submit" /></td>
</tr>

<?php
		}
		break; //break from edit case
}//close the switch
} //close if(!$_POST['add_submit'])
if($_POST['add_submit']) {
	if(mysql_query("UPDATE cms_forums SET title = '".$_POST['title']."' WHERE 'id' = ".$_GET['section']."")){
		echo "<em>Successfully updated forum section to ".$_POST['title'].".</em>\n";
	} else {
		echo "<em>Error updating item</em><br /><br />".mysql_error()."\n";
	}
}
?>

sys4dm1n

Now it reads Error updating item before you even get to the form to edit heh.

It still reads Error updating item when you are on the form. When I submit it, it posts and says successfully updated blah blah blah.. but it doesn't actually update.

Ehhh I feel as if I somehow completely screwed this one up.

Stryker250

Try this...not 100% but its a shot in the dark.
Its an update from the last case...

    case "edit":
    if(isset($_GET['section']) || is_numeric($_GET['section'])) {
        // match the section we want to edit
?>
<table>
<?php
$query = mysql_query("SELECT * FROM cms_forums WHERE id = '".$_GET['section']."'");
$row = mysql_fetch_array($query);
?>
<input type="hidden" name="sectionId" value="<?php echo $_GET['section']; ?>" />
<td class="fieldTitle">title</td>
</tr>
<tr>
<td class="inputData"><input class="text" type="text" name="title" value="<?=$row['title']; ?>" /> </td>
<tr>
<td class="inputData" id="buttons"><input type="submit" value="Edit Section" name="add_submit" /></td>
</tr>

<?php
		}
		break; //break from edit case
}//close the switch
} //close if(!$_POST['add_submit'])
if(isset($_POST['add_submit'])) {
	if(mysql_query("UPDATE cms_forums SET title = '".$_POST['title']."' WHERE 'id' = ".$_POST['sectionId']."")){
		echo "<em>Successfully updated forum section to ".$_POST['title'].".</em>\n";
	} else {
		echo "<em>Error updating item</em><br /><br />".mysql_error()."\n";
	}
}
?>

sys4dm1n

Stryker250,

I get Parse error: syntax error, unexpected '}' so I have to remove the last brace before I can see what happens with the script. This happened in your other attempt also.

Still no luck 🙁.

Thanks

Stryker250

Hmmm....thats interesting. With the code that I copied from you above and edited...all the brackets are closed. Do you have any code above or below this?

sys4dm1n

This is all of the untouched code:

<?php
if(!$_POST['add_submit']) {
?>
<form method="post" action="" enctype="multipart/form-data">
<?php
switch($_GET['func']) {
    default:
    case "view":
        // view
        if($_GET['a'] == "sections") {
        // show the sections
?>
<table class="list">
    <tr class="listHead">
        <td>id</td><td>section</td><td>edit</td><td>delete</td>
    </tr>
<?php
    $query = mysql_query("SELECT * FROM oxcms_forums");
    while($row = mysql_fetch_array($query)) {
?>
    <tr class="listData">
        <td><?=$row['id']; ?></td><td><a href="forums.php" target="_blank"><?=substr(stripslashes($row['title']), 0, 100); ?></a></td><td><a href="?func=edit&amp;section=<?=$row['id']; ?>">edit</a></td><td><a href="?func=delete&amp;section=<?=$row['id']; ?>" onclick="return confirm('Are you sure you want to delete section <?=$row['title']; ?>?')">delete</a></td>
    </tr>

<?php
    }
        }
?>
</table>

<?php
        if($_GET['a'] == "categories") {
        // show the categories
?>

<table class="list">
    <tr class="listHead">
        <td>id</td><td>title</td><td>description</td><td>section</td><td>access</td><td>edit</td><td>delete</td>
    </tr>
<?php
    $query = mysql_query("SELECT * FROM oxcms_categories");
    while($row = mysql_fetch_array($query)) {
        // search for the forum id
        $sql = mysql_query("SELECT * FROM oxcms_forums WHERE (id LIKE '" . $row['forum'] . "')");
        while($f = mysql_fetch_array($sql)) {
?>
    <tr class="listData">
        <td><?=$row['id']; ?></td><td><a href="/forums.php?f=<?=$row['id']; ?>" target="_blank"><?=substr(stripslashes($row['title']), 0, 50); ?></a></td><td><a href="forums.php?func=edit&category=<?=$row['id']; ?>" target="_blank"><?=substr(stripslashes($row['description']), 0, 50); ?></a></td><td><a href="?func=edit&amp;section=<?=$row['forum']; ?>"><? print $f['title']; ?></a></td><td>
        <?php
        $pgs = $row['access'];
        if ($pgs == "1") {
        echo "regular users";
        }
        if ($pgs == "2") {
        echo "rostered members";
        }
        if ($pgs == "3") {
        echo "moderators";
        }
        if ($pgs == "4") {
        echo "administrators";
        }
        if ($pgs == "0") {
        echo "disabled users";
        }
        ?>
        </td>
        <td><a href="?func=edit&amp;category=<?=$row['id']; ?>">edit</a></td><td><a href="?func=delete&amp;category=<?=$row['id']; ?>" onclick="return confirm('Are you sure you want to delete section <?=$row['title']; ?>?')">delete</a></td>
    </tr>

<?php
        }
    }
}
?>
</table>
<?php
        if($_GET['a'] == "topics") {
        // show the topics
?>

<table class="list">
    <tr class="listHead">
        <td>id</td><td>title</td><td>post</td><td>date</td><td>category</td><td>edit</td><td>delete</td>
    </tr>
<?php
    $query = mysql_query("SELECT * FROM oxcms_topics ORDER BY date DESC");
    while($row = mysql_fetch_array($query)) {
        // search for the category id
        $sql = mysql_query("SELECT * FROM oxcms_categories WHERE (id LIKE '" . $row['category'] . "')");
        while($f = mysql_fetch_array($sql)) {
?>
    <tr class="listData">
        <td><?=$row['id']; ?></td><td><a href="/forums.php?t=<?=$row['id']; ?>" target="_blank"><?=substr(stripslashes($row['title']), 0, 38); ?></a></td><td><a href="forums.php?func=edit&topic=<?=$row['id']; ?>" target="_blank"><?=substr(stripslashes($row['post']), 0, 38); ?></a></td><td><?=date("m/d/y", $row['date']); ?></td><td><?=$f['title']?></td>
        <td><a href="?func=edit&amp;topic=<?=$row['id']; ?>">edit</a></td><td><a href="?func=delete&amp;topic=<?=$row['id']; ?>" onclick="return confirm('Are you sure you want to delete topic <?=$row['title']; ?>?')">delete</a></td>
    </tr>

<?php
        }
    }
}
?>
</table>
<?php
        if($_GET['a'] == "posts") {
        // show the posts
?>

<table class="list">
    <tr class="listHead">
        <td>id</td><td>date</td><td>user</td><td>post</td><td>edit</td><td>delete</td>
    </tr>
<?php
    $query = mysql_query("SELECT * FROM oxcms_posts ORDER BY date DESC");
    while($row = mysql_fetch_array($query)) {
        // search for the user id
        $user = mysql_query("SELECT * FROM oxcms_users WHERE (id LIKE '" . $row['author'] . "')");
        while($u = mysql_fetch_array($user)) {
?>
    <tr class="listData">
        <td><?=$row['id']; ?></td><td><?=date("m/d/y", $row['date']); ?></td><td><a href="/user.php?id=<?=$row['author']?>" target="_blank"><?=$u['username']?></a></td><td><a href="forums.php?func=edit&post=<?=$row['id']; ?>" target="_blank"><?=substr(stripslashes($row['post']), 0, 38); ?>...</a></td>
        <td><a href="?func=edit&amp;post=<?=$row['id']; ?>">edit</a></td><td><a href="?func=delete&amp;post=<?=$row['id']; ?>" onclick="return confirm('Are you sure you want to delete this post?')">delete</a></td>
    </tr>
</table>
<?php
        }
    }
}

break;

case "edit":
if(isset($_GET['section']) || is_numeric($_GET['section'])) {
    // match the section we want to edit
?>
<table>
<?php
$query = mysql_query("SELECT * FROM oxcms_forums WHERE id = '".$_GET['section']."'");
$row = mysql_fetch_array($query);
?>
<td class="fieldTitle">title</td>
</tr>
<tr>
<td class="inputData"><input class="text" type="text" name="title" value="<?=$row['title']; ?>" /> </td>
<tr>
<td class="inputData" id="buttons"><input type="submit" value="Edit Section" name="add_submit" /></td>
</tr>

<?php
	}
if($_POST['add_submit']) {
                mysql_query("UPDATE oxcms_forums SET title = '".$_POST['title']."' WHERE 'id' = ".$_GET['section']."") or die("Unable to update database.");
                    echo "<em>Successfully updated forum section to ".$_POST['title'].".</em>\n";
                } else {
                    echo "<em>Error updating item</em><br /><br />".mysql_error()."\n";
				}
}
}
?>

Stryker250

Replace all of that with this...

<?php
if(!$_POST['add_submit']) {
?>
<form method="post" action="" enctype="multipart/form-data">
<?php
switch($_GET['func']) {
    default:
    case "view":
        // view
        if($_GET['a'] == "sections") {
        // show the sections
?>
<table class="list">
    <tr class="listHead">
        <td>id</td><td>section</td><td>edit</td><td>delete</td>
    </tr>
<?php
    $query = mysql_query("SELECT * FROM cms_forums");
    while($row = mysql_fetch_array($query)) {
?>
    <tr class="listData">
        <td><?=$row['id']; ?></td><td><a href="forums.php" target="_blank"><?=substr(stripslashes($row['title']), 0, 100); ?></a></td><td><a href="?func=edit&amp;section=<?=$row['id']; ?>">edit</a></td><td><a href="?func=delete&amp;section=<?=$row['id']; ?>" onclick="return confirm('Are you sure you want to delete section <?=$row['title']; ?>?')">delete</a></td>
    </tr>

<?php
    }
        }
?>
</table>

<?php
        if($_GET['a'] == "categories") {
        // show the categories
?>

<table class="list">
    <tr class="listHead">
        <td>id</td><td>title</td><td>description</td><td>section</td><td>access</td><td>edit</td><td>delete</td>
    </tr>
<?php
    $query = mysql_query("SELECT * FROM cms_categories");
    while($row = mysql_fetch_array($query)) {
        // search for the forum id
        $sql = mysql_query("SELECT * FROM cms_forums WHERE (id LIKE '" . $row['forum'] . "')");
        while($f = mysql_fetch_array($sql)) {
?>
    <tr class="listData">
        <td><?=$row['id']; ?></td><td><a href="/forums.php?f=<?=$row['id']; ?>" target="_blank"><?=substr(stripslashes($row['title']), 0, 50); ?></a></td><td><a href="forums.php?func=edit&category=<?=$row['id']; ?>" target="_blank"><?=substr(stripslashes($row['description']), 0, 50); ?></a></td><td><a href="?func=edit&amp;section=<?=$row['forum']; ?>"><? print $f['title']; ?></a></td><td>
        <?php
        $pgs = $row['access'];
        if ($pgs == "1") {
        echo "regular users";
        }
        if ($pgs == "2") {
        echo "rostered members";
        }
        if ($pgs == "3") {
        echo "moderators";
        }
        if ($pgs == "4") {
        echo "administrators";
        }
        if ($pgs == "0") {
        echo "disabled users";
        }
        ?>
        </td>
        <td><a href="?func=edit&amp;category=<?=$row['id']; ?>">edit</a></td><td><a href="?func=delete&amp;category=<?=$row['id']; ?>" onclick="return confirm('Are you sure you want to delete section <?=$row['title']; ?>?')">delete</a></td>
    </tr>

<?php
        }
    }
}
?>
</table>
<?php
        if($_GET['a'] == "topics") {
        // show the topics
?>

<table class="list">
    <tr class="listHead">
        <td>id</td><td>title</td><td>post</td><td>date</td><td>category</td><td>edit</td><td>delete</td>
    </tr>
<?php
    $query = mysql_query("SELECT * FROM cms_topics ORDER BY date DESC");
    while($row = mysql_fetch_array($query)) {
        // search for the category id
        $sql = mysql_query("SELECT * FROM cms_categories WHERE (id LIKE '" . $row['category'] . "')");
        while($f = mysql_fetch_array($sql)) {
?>
    <tr class="listData">
        <td><?=$row['id']; ?></td><td><a href="/forums.php?t=<?=$row['id']; ?>" target="_blank"><?=substr(stripslashes($row['title']), 0, 38); ?></a></td><td><a href="forums.php?func=edit&topic=<?=$row['id']; ?>" target="_blank"><?=substr(stripslashes($row['post']), 0, 38); ?></a></td><td><?=date("m/d/y", $row['date']); ?></td><td><?=$f['title']?></td>
        <td><a href="?func=edit&amp;topic=<?=$row['id']; ?>">edit</a></td><td><a href="?func=delete&amp;topic=<?=$row['id']; ?>" onclick="return confirm('Are you sure you want to delete topic <?=$row['title']; ?>?')">delete</a></td>
    </tr>

<?php
        }
    }
}
?>
</table>
<?php
        if($_GET['a'] == "posts") {
        // show the posts
?>

<table class="list">
    <tr class="listHead">
        <td>id</td><td>date</td><td>user</td><td>post</td><td>edit</td><td>delete</td>
    </tr>
<?php
    $query = mysql_query("SELECT * FROM cms_posts ORDER BY date DESC");
    while($row = mysql_fetch_array($query)) {
        // search for the user id
        $user = mysql_query("SELECT * FROM cms_users WHERE (id LIKE '" . $row['author'] . "')");
        while($u = mysql_fetch_array($user)) {
?>
    <tr class="listData">
        <td><?=$row['id']; ?></td><td><?=date("m/d/y", $row['date']); ?></td><td><a href="/user.php?id=<?=$row['author']?>" target="_blank"><?=$u['username']?></a></td><td><a href="forums.php?func=edit&post=<?=$row['id']; ?>" target="_blank"><?=substr(stripslashes($row['post']), 0, 38); ?>...</a></td>
        <td><a href="?func=edit&amp;post=<?=$row['id']; ?>">edit</a></td><td><a href="?func=delete&amp;post=<?=$row['id']; ?>" onclick="return confirm('Are you sure you want to delete this post?')">delete</a></td>
    </tr>
</table>
<?php
        }
    }
}

break;

case "edit":
if(isset($_GET['section']) || is_numeric($_GET['section'])) {
    // match the section we want to edit
?>
<table>
<?php
$query = mysql_query("SELECT * FROM cms_forums WHERE id = '".$_GET['section']."'");
$row = mysql_fetch_array($query);
?>
<input type="hidden" name="sectionId" value="<?php echo $_GET['section']; ?>" />
<td class="fieldTitle">title</td>
</tr>
<tr>
<td class="inputData"><input class="text" type="text" name="title" value="<?=$row['title']; ?>" /> </td>
<tr>
<td class="inputData" id="buttons"><input type="submit" value="Edit Section" name="add_submit" /></td>
</tr>

<?php
		}
		break; //break from edit case
}//close the switch
} //close if(!$_POST['add_submit'])
if(isset($_POST['add_submit'])) {
	$query = "UPDATE cms_forums SET title = '".$_POST['title']."' WHERE id = '".$_POST['sectionId']."'";
	if(mysql_query($query)){
		echo "<em>Successfully updated forum section to ".$_POST['title'].".</em>\n";
		echo "<br />" . $query;
	} else {
		echo "<em>Error updating item</em><br /><br />".mysql_error()."\n";
	}
}
?>

sys4dm1n

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource line 35

sys4dm1n

Okay,

I fixed that error -- everything works up until I click the submit button. I click the submit button and it tells me it has been successfully added. I go and check and nothing has been updated in the database.

sys4dm1n

I fixed it! It was my query. 🙁

I forgot to do WHERE table.id (I forgot the table)

Thanks for all of your help!!

Stryker250

Great....glad you were able to sort it out 😉