[RESOLVED] unexpected T_STRING error problem

obel

I am making a database of clients for a job.
My problem is i keep getting some unexpected T_STRING error, and i can't find the error myself so i thought you guys may could help me out on this one 🙂

The error:

Parse error: syntax error, unexpected T_STRING in C:\xampp\htdocs\navn\tilfoj.php on line 46

Line 46 code:

mysql_query("INSERT INTO navne (fornavn, efternavn, firma, telefon, addresse, postnr, city)VALUES("$fornavn", "$efternavn", "$firma", "$telefon", "$addresse", "$postnr", "$city")");

Ashley_Sheridan

The problem is you are using the same types of quotation marks for the PHP and MySQL strings. You need to change the ones used by MySQL like so:

mysql_query("INSERT INTO navne (fornavn, efternavn, firma, telefon, addresse, postnr, city)VALUES('$fornavn', '$efternavn', '$firma', '$telefon', '$addresse', '$postnr', '$city')");

That should work now. Also, don't forget to sanitise your input variables and make sure there are no apostrophes or percent signs which could be used as part of an SQL injection attack.

obel

Well, it still makes the same error 😮

Ashley_Sheridan

can you output what the string translates as, i.e.

print "INSERT INTO navne (fornavn, efternavn, firma, telefon, addresse, postnr, city)VALUES('$fornavn', '$efternavn', '$firma', '$telefon', '$addresse', '$postnr', '$city')";

NogDog

Could you show us more of the code, especially several of the lines leading up to the one cited in the error message? (PS: use the

 tags instead of [code] tags to make it a bit easier to read here.)

obel

Well here is the full sourcecode if it might help 🙂

<?

mysql_connect("localhost", "root", "****");
mysql_select_db("navn);

$kodeord = $_POST[kodeord];
$fornavn = $_POST[fornavn];
$efternavn = $_POST[efternavn];
$firma = $_POST[firma];
$telefon = $_POST[telefon];
$addresse = $_POST[addresse];
$postnr = $_POST[postnr];
$city = $_POST[city];


if($kodeord == test){

mysql_query("INSERT INTO navne (fornavn, efternavn, firma, telefon, addresse, postnr, city)VALUES('$fornavn', '$efternavn', '$firma', '$telefon', '$addresse', '$postnr', '$city')");

echo "Navnet er tilføjet";

} else {

?>

<form action="<? echo $PHP_SELF; ?>" method="POST">

<b>Kodeord:</b><br>

<input type="password" name="kodeord"><br><br><br>

<b>Fornavn(e):</b><br>

<input type="text" name="fornavn"><br>

<b>Efternavn:</b><br>

<input type="text" name="efternavn"><br>

<b>Firma:</b><br>

<input type="text" name="firma"><br>

<b>Telefon:</b><br>

<input type="text" name="telefon"><br>

<b>Addresse:</b><br>

<input type="text" name="addresse"><br>

<b>Postnummer:</b><br>

<input type="text" name="postnr"><br>

<b>By:</b><br>

<input type="text" name="city"><br><br>

<input type="submit" value="Opret">

</form>

<?

}

?>

zoooj

You're missing quote marks around the word test

if($kodeord == "test"

This could be the problem though usually with T_STRING errors it's down to brackets and semi-colons.

Ashley_Sheridan

The problem is highlighted in your source code, look at the second line:

mysql_select_db("navn);

You are missing the double quotes on it, which means the string isn't closing until the line your error message is reporting, and the next characters which are meant to be part of that string are creating your error.

[EDIT]Use a syntax highlighting editor if you can. Notepad++ is good, and available for most operating systems.[/EDIT]

obel

Well the solution to the problem turned out to be very simple. At the

mysql_select_db("navn");

I forgot a " at the end :o

Ashley_Sheridan

Cool. Don't forget to mark the thread as resolved 🙂

obel

done.. 😉