global variable $datafl accessing problem?

asukla

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
<title>Untitled Document</title>
</head>
<?php


function reg() {
			global $datafl;
			$feedback = "Code Image Data = " . $datafl . ' <br/>Form Image Data = ' . $_POST['r_secdata'];
			return $feedback;
}

function datafile (){
		//global $id;
		global $datafl;
		$id =rand(0, 259); 
		$datafl =$id .'.jpg';
		return $datafl;
	}
if ($_POST['Submit'] == 'Submit')
{
	$fb =reg();
	echo $fb;
	exit();
}else {
$file=$_SERVER['PHP_SELF'];
$fl= datafile();
$data = <<< STT
<body>
<form id="form1" name="form1" method="post" action='$file'>
<label>$fl
  <input name="r_secdata" type="text" id="r_secdata" />
  </label>
  <label>
  <input type="submit" name="Submit" value="Submit" />
  </label>
</form>
</body>
STT;
echo $data;
}
?>
</html>

Why the $datafl is not retrived by the reg().

Weedpacket

$datafl never gets a value until datafile() has been called. You only call datafile() if $POST['Submit'] does not equal 'Submit'; you only call reg() if $POST['Submit'] does equal 'Submit'.

Just one more example of why global variables are Considered Harmful.

asukla

Weedpacket;10884102 wrote:
$datafl never gets a value until datafile() has been called. You only call datafile() if $POST['Submit'] does not equal 'Submit'; you only call reg() if $POST['Submit'] does equal 'Submit'.

Just one more example of why global variables are Considered Harmful.

When the Forms load it automatically called datafile(). So datafl gets value at once. What's the problem?

Weedpacket

asukla wrote:
When the Forms load it automatically called datafile(). So datafl gets value at once. What's the problem?

Only when the form is loaded. And it only does that if $POST['Submit'] does not equal 'Submit'. reg() is called only when $POST['Submit'] does equal 'Submit'.

<?php
if ($_POST['Submit'] == 'Submit')
{
	$fb =reg();
	echo $fb;
	exit();
}else {
$fl= datafile();
?>

I think what you're thinking here is that values assigned to a variable in one request will still be there in the next request, right?