sql counter with update

justme_gilbert

HI,

I don't know if i am in the right topic, but it is my first day here.

My problem is that i have wrote an function (part) to keep in track how many emails i have really sent. But somewhere i made an mistake, and i don't see it anymore what i did wrong ( i am just fighting for 6 hours with this sucker) So i hope somebody can help me out and see what the problem is.

function checkInput ($show) {
    /*
     * I implemented the $show variable because the error messages
     * were getting sent before the page header.  So, I check once
     * using $show=false, and then when I'm ready to display the error
     * message, show=true
     */
    global $body, $send_to, $send_to_bcc, $subject, $color;

if ($send_to == '' && $send_to_bcc == '') { 
    if ($show) {
        plain_error_message(_("You have not filled in the \"To:\" field."), $color);
}

else 
{$mysql_id=mysql_connect("back","mailcounter","XXXXX");

mysql_select_db("mailco", $mysql_id);


mysql_query('UPDATE myuser SET Mailtot=Mailtot + 1 WHERE userName=$username");

mysql_close($mysql_id);
}
return false;
}
    return true;
}

It is in Php ofcourse.

I hope to hear from someone.

Greetz

bpat1434

From what I see, you never close your SQL string. You open it with a single-quote, then close it with a double-quote. You have to use the same on either side 😉

It would also seem you've got some flawed logic in your if()else{} statements. You try and send an email even though $send_to and $send_to_bcc are empty.

justme_gilbert

yea i agree that the if () else {} isnt perfect 😃

this is my second script, the first one was perfect...but this one is an crime.

The mening is that in the compose script there is an controll, that if there is no email adress filled in, that he gives an error and stays on the same page. But if there is no error, he has to raise mailtot with one in the mysql databse, and then go back to the inbox.

But i dont see where i go wrong with the if else.

bpat1434

I'll just reformat your code so you can actually see....

function checkInput ($show) {
	/*
	* I implemented the $show variable because the error messages
	* were getting sent before the page header.  So, I check once
	* using $show=false, and then when I'm ready to display the error
	* message, show=true
	*/
	global $body, $send_to, $send_to_bcc, $subject, $color;

if ($send_to == '' && $send_to_bcc == '')
{
	if ($show)
	{
		plain_error_message(_("You have not filled in the \"To:\" field."), $color);
	}
	else
	{
		$mysql_id=mysql_connect("back","mailcounter","XXXXX");
		mysql_select_db("mailco", $mysql_id);
		mysql_query("UPDATE myuser SET Mailtot=Mailtot + 1 WHERE userName=$username");
		mysql_close($mysql_id);
	}

	return false;
}

return true;
}

If there's no "to" and no "to_bcc" wouldn't you want to just either log the error message or show it rather than count it as a valid send?

NOTE: I also fixed the syntax error you had before with the mismatched quotes.

justme_gilbert

Thank you verry mutch, it works great now :-D