[RESOLVED] Parse error on Line 36

tazman622

Hello,

This is my first post, so I hope this works. I have written a simple form to store info about inventory at my job. I keep getting a parse error for a Line 36 and when I look in the script, there is only 35 lines to the whole thing.

I would appreciate any suggestions on getting this to work. Here is the submit script that throws the error.

<?php
$con = mysql_connect("localhost","*","***");

if (!$con)
{
die('Could not connect: ' . mysql_error());
}

mysql_select_db("crownbattery", $con);

if($_POST['action'])

{

$part_num_in=$_POST['part_num_in'];

$cca_in=$_POST['cca_in'];

$ca_in=$_POST['ca_in'];

$rc_minutes_in=$_POST['rc_minutes_in'];

$warranty_period_sel=$_POST['warranty_period_sel'];

$free_replace_sel=$_POST['free_replace_sel'];

$list_price_in=$POST['list_price_in'];
$kap_price_in=$POST['kap_price_in'];
$bci_group=$POST['bci_group'];
$bat_length_in=$POST['bat_length_in'];
$bat_width_in=$POST['bat_width_in'];
$bat_height_in=$POST['bat_height_in'];

$sql="INSERT INTO batteryinfo (id, part_num_in, cca_in, ca_in, rc_minutes_in, warranty_period_sel, free_replace_sel, list_price_in, kap_price_in, bci_group_in, bat_length_in, bat_width_in, bat_height_in) VALUES (NULL, '$part_num_in', '$cca_in', '$ca_in', '$rc_minutes_in', '$warranty_period_sel', '$free_replace_sel', '$list_price_in', '$kap_price_in', '$bci_group', '$bat_length_in', '$bat_width_in', '$bat_height_in')";

if (!mysql_query($sql,$con))
{
die('Error: ' . mysql_error());
}
echo "1 record added";

mysql_close($con)
?>

Any help will be greatly appreciated. Beating my head against the laptop isn't doing either myself or the machine any good at this point.

Thanks
Tazman622

dagon

mysql_close($con);

missing semi colon

if($_POST['action'])

not closed

tazman622

I did find the mistakes that you mentioned...thanks...but I still get this error message.

Parse error: syntax error, unexpected $end in /var/www/JoomlaKAP/scripts/crownspecsubmitV2.php on line 36

and like I said earlier, there is only 35 lines if you count the blank lines too.

One question...as I do not understand PHP well enough to do much...the line about if($_POST['action']) now that it is syntaxed properly...should the 'action' be the name of the submit button on the form. The forms submit button is named submit.

I appreicate the help.

Tazman622

tazman622

I fixed the mistakes and still had trouble as mentioned. Then I found that I had not defined the name of the submit button on the form, I needed to change 'action' to 'submit' to match the name of the button in the submit form section $_POST, and finally I found that I didn't have enough curly brackets in the submit script itself.

Thanks,
Tazman622

dagon

post your new code

tazman622

Here is the fixed script to be able to submit to my database...

<?php
$con = mysql_connect("***","*","*****");

if (!$con)
{
die('Could not connect: ' . mysql_error());
}

mysql_select_db("database_name", $con);

if($_POST['submit'])

{

$part_num_in=$_POST['part_num_in'];

$cca_in=$_POST['cca_in'];

$ca_in=$_POST['ca_in'];

$rc_minutes_in=$_POST['rc_minutes_in'];

$warranty_period_sel=$_POST['warranty_period_sel'];

$free_replace_sel=$_POST['free_replace_sel'];

$list_price_in=$POST['list_price_in'];
$kap_price_in=$POST['kap_price_in'];
$bci_group_in=$POST['bci_group_in'];
$bat_length_in=$POST['bat_length_in'];
$bat_width_in=$POST['bat_width_in'];
$bat_height_in=$POST['bat_height_in'];

$sql="INSERT INTO table_name (id, part_num_in, cca_in, ca_in, rc_minutes_in, warranty_period_sel, free_replace_sel, list_price_in, kap_price_in, bci_group_in, bat_length_in, bat_width_in, bat_height_in) VALUES (NULL, '$part_num_in', '$cca_in', '$ca_in', '$rc_minutes_in', '$warranty_period_sel', '$free_replace_sel', '$list_price_in', '$kap_price_in', '$bci_group_in', '$bat_length_in', '$bat_width_in', '$bat_height_in')";
}
if (!mysql_query($sql,$con))
{
die('Error: ' . mysql_error());
}
echo "1 record added";

mysql_close($con);
?>

Problems that I fixed...
1) if($_POST['submit']) ...the 'submit' part was left as 'action'...it should match the name of the button on the submit form page.

2)Line just under the '$sql=' string needed a closing curly bracket to end the if statement properly.

3)Had to define the name of the submit button on the form page that goes with this script. Without the 'name=submit' tag, I kept getting Error Query Empty errors. This is now fixed as well.

4) The last problem I found was that the BCI Group info wasn't getting entered into MYSQL at all. I found that I had forgotten the _in part of the variable name in the upper part of the submit script. Since I had copied the wrong name when I defined it and then pasted it throughout the rest of the script, it is no wonder it didn't work.

Simple mistakes often seem to create the biggest problems. Syntax, Syntax, Syntax...Thanks Again for the guidance!