syntax for including PHP variables inside a query String?

pufftissue

Hi,

Going kind of nuts figuring this out.

<?php

if (isset($_GET['currentSelectedIndication']))
{
	$selection = $_GET['currentSelectedIndication'];
	$SQLString = "SELECT variant FROM indications WHERE indication='$selection'";
	$queryResult = Process::queryDatabase($myConnection,$SQLString);
	Process::generateVariants($queryResult);
}
?>

if i change $SQLString to: "SELECT variant FROM indications WHERE indication='Low Back Pain'"; it works.

When I run both $SQLString statements in the console or phpmyAdmin I get the correct results.

But why not in my script? $selection is 'Low Back Pain'. I echoed it to verify that it is indeed correct.

I am single quoting the PHP variable correctly, I think. Oddly, the syntax is the same with another function that uses the same syntax.

Any ideas why?

NogDog

Try var_dump()-ing the $SQLString variable after you define it to make sure it is exactly what you expected it to be. If it is, you can copy-and-paste it into your SQL command interface to see what happens. Also don't forget to make sure you have a valid DB connection in your $myConnection variable. It also might help to ensure all error reporting is turned on.

pufftissue

So when i use

var_dump($selection) I've got a leading space, as in " low back pain" or " fever"

I'm not sure why or how to fix it.

I've tried the usual suspects. Anything obvious?

pufftissue

Well what I did was just use the trim() function, I still don't know why an extra space was being introduced.

NogDog

pufftissue;10884930 wrote:
Well what I did was just use the trim() function, I still don't know why an extra space was being introduced.

Difficult to say how that would have happened without seeing the code that populates those variables. At least you found the problem and a work-around, so you can look for the root cause at your leisure now rather than having to find a fix ASAP. 🙂