Date/Time problems under PHP5

[grumpy]

Hello-
My hoster upgraded to PHP5 over the weekend and now my site that uses strtotime, etc. no longer functions correctly. Its been working for a year with no problems until now. I can't seem to figure out what I need to change. The times returned are incorrect. Below is my code that seems to be affected. What do I need to change? Thanks.

<?

$qs = "select * from admin_setting where admin_setting_id='$user_id'";			
	$ids = mysql_query($qs) or die(mysql_error());
	$rowsetting = mysql_fetch_object($ids);



if(!isset($_GET['year']))
{
	$_GET['year'] = date("Y");
}
if(!isset($_GET['month']))
{
	$_GET['month']=date("m");
}
if(!isset($_GET['day']))
{
	$_GET['day']=date("d");
}


$starttime = strtotime("$_GET[year]-$_GET[month]-$_GET[day] $available_start_time");

$endtime = strtotime("$_GET[year]-$_GET[month]-$_GET[day] $available_end_time");


$today = mktime();


$diff_time = $starttime - $today;


?>

[bpat1434]

Where is $available*time defined? I don't see it in the script anywhere.

And what exactly do you mean by "incorrect"? As in off by a few hours, or as in it's just not taking in to account the $available*time items?

[grumpy]

Hi--
Thanks for your response. $available*time comes from the mysql database.

[bpat1434]

Okay, but where to you define the variables? If they aren't defined earlier, then they're not available later 😉 If these are just snippets of your code, post all relevant code.

[grumpy]

Thanks again. The $available_start_time, etc. comes from the database. The GET year,month, day come from a form on a previous page. They are being sent correctly. When I echo the variables $starttime and $endtime they are no longer the correct unix timestamp. If I remove the $available_start_time, end_time from the strtotime statements for testing, I at least get the correct date stamp. I'm surmising that it must be something in how PHP5 is handling the strtotime statments. Like I said everything worked correctly for over a year until my host upgraded from PHP4 to PHP5.

This page uses a config file. Here are the lines that get the start and end times. Could these be the problem?

$admin_qs = "select * from admin_setting where admin_setting_id='$user_id'";
$admin_ids = mysql_query($admin_qs) or die(mysql_error());
$admin_setting = mysql_fetch_object($admin_ids);
$work_days_sun = "";
$work_days_mon = "";
$work_days_tue = "";
$work_days_wed = "";
$work_days_thur = "";
$work_days_fri = "";
$work_days_sat = "";
if($admin_setting->work_days_sun == "Y")
	$work_days_sun = "Sunday";
if($admin_setting->work_days_mon == "Y")
	$work_days_mon = "Monday";
if($admin_setting->work_days_tue == "Y")
	$work_days_tue = "Tuesday";
if($admin_setting->work_days_wed == "Y")
	$work_days_wed = "Wednesday";
if($admin_setting->work_days_thur == "Y")
	$work_days_thur = "Thursday";
if($admin_setting->work_days_fri == "Y")
	$work_days_fri = "Friday";
if($admin_setting->work_days_sat == "Y")
	$work_days_sat = "Saturday";
$work_days = array($work_days_sun,$work_days_mon,$work_days_tue,$work_days_wed,$work_days_thur,$work_days_fri,$work_days_sat);
$available_start_time = $admin_setting->available_start_hour.":".$admin_setting->available_start_min." ".$admin_setting->available_start_dur;
$available_end_time = $admin_setting->available_end_hour.":".$admin_setting->available_end_min." ".$admin_setting->available_end_dur;
$admin_email = $admin_setting->email_id;
$company_name =$admin_setting->company_name;

[bpat1434]

What does $available*time give you if you echo them out? Are they what you expect?

[grumpy]

When I echo the echo $available_start_time and end_time they are returning times that appear to be truncated, for example 9:0 or 7:0

That is the waty the data is stored in the db, minutes are as 0-60, not 00 or 01 for example.

[bpat1434]

You can edit your posts... you don't need to keep double-posting.

Okay, then that's an easy fix. For one, you could use [man]str_pad/man to pad the numbers to be 0X or whatever. For example:

$available_start_time = str_pad($admin_setting->available_start_hour, 2, '0', STR_PAD_LEFT) . ':' . str_pad($admin_setting->available_start_min, 2, '0', STR_PAD_LEFT) . ' ' . $admin_setting->available_start_dur;

Try that and see if it helps.

[grumpy]

Thank you. It works! Do you happen to know what in PHP5 is different that would have caused the old code to not work?

bpat1434;10885003 wrote:

You can edit your posts... you don't need to keep double-posting.

Okay, then that's an easy fix. For one, you could use [man]str_pad/man to pad the numbers to be 0X or whatever. For example:

$available_start_time = str_pad($admin_setting->available_start_hour, 2, '0', STR_PAD_LEFT) . ':' . str_pad($admin_setting->available_start_min, 2, '0', STR_PAD_LEFT) . ' ' . $admin_setting->available_start_dur;

Try that and see if it helps.

[bpat1434]

To me, it's not a php5 issue,it's a coding issue. Technically that shouldn't have worked in php4 🙁 Not sure. Could have been a database thing. Perhaps they upgraded MySQL as well and you didn't notice some columns change types? Or perhaps you changed the type of column from text to numeric? Who knows. Far as I can tell, it's not really a php core issue, more a code issue.

[grumpy]

Thanks for the answer. The code/database has not changed for a year, including column types. Everything worked perfectly until the upgrade so it definitely has something to do with PHP5. The columns related to start/end minutes have the attribute "unsigned". Wonder if that is what PHP5 doesnt' like? Oh well...thanks again.

bpat1434;10885014 wrote:

To me, it's not a php5 issue,it's a coding issue. Technically that shouldn't have worked in php4 🙁 Not sure. Could have been a database thing. Perhaps they upgraded MySQL as well and you didn't notice some columns change types? Or perhaps you changed the type of column from text to numeric? Who knows. Far as I can tell, it's not really a php core issue, more a code issue.

[bpat1434]

Not really sure. I just went and did a test case, and you're right. There is something different about php5 that doesn't like the "malformed" dates.

In the change-log I see:

Rewrote strtotime() with support for timezones and many new formats. Implements feature requests #21399, #26694, #28088, #29150, #29585 and #29595. (Derick)

Every other bug listed in there dealing directly with strtotime seems to be about something else, and nothing really "close". Not sure, but it could just be that now they're following all the RFCs dealing with dates.