First-time switch problems

[WOW_WP]

Howdy folks,
Does anyone know why this always displays the first case result? I am passing each variable's id through the url (ex. library.php?web_id=202). Note: All the id's being used have an assigned value stored within mySQL table - $brochure_id (1-100), $card_id (101-200), $web_id (201-300), and $eblast_id (301-400). All this is is a simple switch to display the corresponding statement when the proper id is sent via the url. It can't be that difficult! Here's the switch code:

    [code=php]<?php
	switch(true) 
	{
		case ($brochure_id <= 100):
			echo "This works";
			break;
		case ($card_id <= 200):
			echo "This works too";
			break;
		case ($web_id <= 300):
			echo "This works three";
			break;
		case ($eblast_id <= 400):
			echo "This works four";
			break;
		default:
			echo "No match found";
			break;
	}
	?>[/code]

If anyone can help answer this it would be great!

-WOW

[bpat1434]

If you're sending it through the URL, and no matter what the url will look like:

library.php?web_id=202
library.php?web_id=57
library.php?web_id=306

Then you would want to use $_GET['web_id'] and see if that's <= 100, <= 200, <= 300, etc.

<?php

$id = $_GET['web_id'];

switch(true)
{
    case $id <= 100:
        break;

case $id <= 200:
    break;

case $id <= 300:
    break;

default:
    break;
}

Get the idea?

Now, if you constantly change that URL to be:

library.php?web_id=202
library.php?card_id=135
library.php?brochure_id=57
etc.

then I would suggest you remove the "whatever_" from the URL and just use:

library.php?id=XXX

Then do the switch and look at $_GET['id'].

[WOW_WP]

Guess I basically need to use $_GET for the id. Thanks for the quick reply, that was awesome!

-WOW

[NogDog]

There's also a logic issue here. You state in your post the brochure_id will be a value from 1-100. In your first switch case you check if it is <= 100. Since apparently it normally will be, that case will normally execute. Since the last statement of that case is break;, once it's done it will break out of the entire switch structure, therefore none of the other cases will be executed. I hesitate to suggest what the "fix" is since I do not know what the precise functionality is that you want, but hopefully that will at least help you understand what's happening so you can figure out if/how you need to change it.

[bpat1434]

I think they were getting caught up on the fact that the $_GET variable would be a number, and thought they could check to see which was sent inside a switch statement. So if "brochure_id" was sent, then it would have a value between 1 and 100, or the default would catch it. If "web_id" was sent then it would be between 201 and 300, or the default would catch. So it was counter to what the switch statement does, and also possibly based on "register_globals" being enabled.

[WOW_WP]

Yeah, I'm just passing one of the listed variables, knowing that there will never be a brochure_id = 202 or web_id, and so on. Basically just trying have a single webpage pull up the corresponding info. - still works like a charm! Thanks to everyone! Oh yeah, I also tagged onto it a counter so each individual id gets a count added to the db.

-WOW