[RESOLVED] Loop Image Cropping Code

[mramonster]

I'm trying to get a While Loop Going on this but it doesn't seem to be working well for me. As of right now the problem seems to be separating the images. because it just prints them out in one variable.

<?php
   $dir = 'path/to/image/';

   // open specified directory
   $dirHandle = opendir($dir);
   $count = -1;
   $returnstr = "";
   while ($file = readdir($dirHandle)) {
      // if not a subdirectory and if filename contains the string '.jpg' 
      if(!is_dir($file) && strpos($file, '.jpg')>0) {
         // update count and string of files to be returned
         $count++;
         $returnstr .= $file;
      }
   } 
   echo $returnstr."<br />";
   closedir($dirHandle);

$images = $dir.$returnstr;
do {

$file3 = 'path/to/image/'.$returnstr;
$file4 = 'path/to/image/thumb/'.$returnstr;
echo $file3.'<br>'.$file4.'<br><br>';

cropImage(115, 77, $file3, 'jpg', $file4);

function cropImage($nw, $nh, $source, $stype, $dest) {

$size = getimagesize($source);
$w = $size[0];
$h = $size[1];

switch($stype) {
case 'gif':
$simg = imagecreatefromgif($source);
break;
case 'jpg':
$simg = imagecreatefromjpeg($source);
break;
case 'png':
$simg = imagecreatefrompng($source);
break;
}

$dimg = imagecreatetruecolor($nw, $nh);

$wm = $w/$nw;
$hm = $h/$nh;

$h_height = $nh/2;
$w_height = $nw/2;

if($w> $h) {

$adjusted_width = $w / $hm;
     $half_width = $adjusted_width / 2;
     $int_width = $half_width - $w_height;

imagecopyresampled($dimg,$simg,-$int_width,0,0,0,$adjusted_width,$nh,$w,$h);

} elseif(($w <$h) || ($w == $h)) {

$adjusted_height = $h / $wm;
$half_height = $adjusted_height / 2;
$int_height = $half_height - $h_height;

imagecopyresampled($dimg,$simg,0,-$int_height,0,0,$nw,$adjusted_height,$w,$h);

} else {
    imagecopyresampled($dimg,$simg,0,0,0,0,$nw,$nh,$w,$h);
 }

imagejpeg($dimg,$dest,100);
}
} while (file_exists($images))
?>

[bpat1434]

Instead of $returnstring .= $file use $files[] = $file; and then you can use $files[0] and $files[1] instead of $file3 and $file4.

[mramonster]

I did what you suggested and that didn't work, However you have to do the Files[0] for each to keep it the same file name in a different folder. This is what I changed the code to and am still getting an error.

Call to undefined function cropImage() on Line 25.

<?php
   $dir = 'path/to/image/';

   // open specified directory
   $dirHandle = opendir($dir);
   $count = -1;
   $returnstr = "";
   while ($file = readdir($dirHandle)) {
      // if not a subdirectory and if filename contains the string '.jpg' 
      if(!is_dir($file) && strpos($file, '.jpg')>0) {
         // update count and string of files to be returned
         $count++;
         $files[] = $file;
      }
   } 
   echo $returnstr."<br />";
   closedir($dirHandle);

do {

$path1 = '/path/to/image/'.$files[0];
$path2 = '/path/to/image/thumb/'.$files[0];
echo $path1.'<br>'.$path2.'<br><br>';

cropImage(115, 77, $path1, 'jpg', $path2);

function cropImage($nw, $nh, $source, $stype, $dest) {

//ECT.......

}
} while (file_exists($dir))
?>

[bpat1434]

Okay, you really shouldn't define a function inside a "do-while" loop. Reason being is that the function won't really be there until the code reaches that point in the loop.

Here's how I would crop images inside of one directory:

<?php

$dir = 'path/to/image/';

$dh = dir($dir);
/* $count = 0; // Unnecessary because you can count the array $images */
$images = array();

while(false !== ($entry = $dh->read()))
{
	$path1 = $dir;
	$path2 = $dir.'thumb/';

if(!is_dir($entry) && strpos($entry, '.jpg')>0)
{
	/* $count++; // This is now unnecessary because you can count the array */
	$images[] = $entry;

	cropImage(115, 77, $path1, 'jpg', $path2);
}
}
$dh->close();

echo 'Successfully cropped ' . count($images) . ' images';

function cropImage($nw, $nh, $source, $stype, $dest)
{
	// Etc.....
}

Much simpler code don't you think?

[mramonster]

With a little more testing I narrowed it down to one Error. It obviously doesn't work without all the "//ECT" coding in there. So I added that this time again just to show it all.

Error:
Parse error: syntax error, unexpected T_LNUMBER, expecting '&' or T_VARIABLE in photos/crop.php on line 26

I don't see why there should be a & anywhere in that code or a ';'

<?php

$dir = 'path/to/image/';

$dh = dir($dir);

$images = array();

while(false !== ($entry = $dh->read()))
{
    $path1 = $dir;
    $path2 = $dir.'thumb/';

if(!is_dir($entry) && strpos($entry, '.jpg')>0)
{

    $images[] = $entry;

    cropImage(115, 77, $path1, 'jpg', $path2);
}
}
$dh->close();

echo 'Successfully cropped ' . count($images) . ' images';

function cropImage(115, 77, $path1, 'jpg', $path2){

$size = getimagesize($source);
$w = $size[0];
$h = $size[1];

switch($stype) {
case 'gif':
$simg = imagecreatefromgif($source);
break;
case 'jpg':
$simg = imagecreatefromjpeg($source);
break;
case 'png':
$simg = imagecreatefrompng($source);
break;
}

$dimg = imagecreatetruecolor($nw, $nh);

$wm = $w/$nw;
$hm = $h/$nh;

$h_height = $nh/2;
$w_height = $nw/2;

if($w> $h) {

$adjusted_width = $w / $hm;
     $half_width = $adjusted_width / 2;
     $int_width = $half_width - $w_height;

imagecopyresampled($dimg,$simg,-$int_width,0,0,0,$adjusted_width,$nh,$w,$h);

} elseif(($w <$h) || ($w == $h)) {

$adjusted_height = $h / $wm;
$half_height = $adjusted_height / 2;
$int_height = $half_height - $h_height;

imagecopyresampled($dimg,$simg,0,-$int_height,0,0,$nw,$adjusted_height,$w,$h);

} else {
    imagecopyresampled($dimg,$simg,0,0,0,0,$nw,$nh,$w,$h);
 }

imagejpeg($dimg,$dest,100);
}
?>

[bpat1434]

Parameters in the function declaration should be variables, not integers and strings.

e.g. this is line 26 currently:

function cropImage(115, 77, $path1, 'jpg', $path2) {

Which should be:

function cropImage($nw, $nh, $source, $stype, $dest) {

[mramonster]

bpat1434;10886842 wrote:

Parameters in the function declaration should be variables, not integers and strings.

e.g. this is line 26 currently:

function cropImage(115, 77, $path1, 'jpg', $path2) {

Which should be:

function cropImage($nw, $nh, $source, $stype, $dest) {

Ahh I had changed it because I kept getting these errors:

Warning: imagecreatefromjpeg() [function.imagecreatefromjpeg]: gd-jpeg: JPEG library reports unrecoverable error: in /path/to/website/photos/crop.php on line 37

Warning: imagecreatefromjpeg() [function.imagecreatefromjpeg]: 'path/to/photos/' is not a valid JPEG file in /path/to/website/photos/crop.php on line 37

Warning: Division by zero in /path/to/website/photos/crop.php on line 62

Warning: imagecopyresampled(): supplied argument is not a valid Image resource in /path/to/website/photos/crop.php on line 66

Warning: imagejpeg() [function.imagejpeg]: Unable to open 'path/to/photos/thumb/' for writing: Is a directory in /path/to/website/photos/crop.php on line 72

[bpat1434]

Well, given that $source is never defined inside the function, yet you're using that to create new images.... I would say most of your problems stem from that.

[mramonster]

I see that for the $source now. Maybe I'm an idiot or just a noobie but I don't see how I am suppose to "loop it".

[bpat1434]

The while is a loop... so if you crop your images while your in the while loop, there's your loop.... look at my code above (#4)

[mramonster]

That's what I'm not understanding. Below is the original code for one image and it works perfectly. The source in this is defined by the "cropImage(115, 77, $file3, 'jpg', $file4);" above it.

<?php
$file = 'image.jpg';
$file3 = 'path/to/image/'.$file;
$file4 = 'path/to/image/thumb/'.$file;
echo $file3.'<br>'.$file4.'<br><br>';

cropImage(115, 77, $file3, 'jpg', $file4);

function cropImage($nw, $nh, $source, $stype, $dest) {

$size = getimagesize($source);
$w = $size[0];
$h = $size[1];

switch($stype) {
case 'gif':
$simg = imagecreatefromgif($source);
break;
case 'jpg':
$simg = imagecreatefromjpeg($source);
break;
case 'png':
$simg = imagecreatefrompng($source);
break;
}

$dimg = imagecreatetruecolor($nw, $nh);

$wm = $w/$nw;
$hm = $h/$nh;

$h_height = $nh/2;
$w_height = $nw/2;

if($w> $h) {

$adjusted_width = $w / $hm;
     $half_width = $adjusted_width / 2;
     $int_width = $half_width - $w_height;

imagecopyresampled($dimg,$simg,-$int_width,0,0,0,$adjusted_width,$nh,$w,$h);

} elseif(($w <$h) || ($w == $h)) {

$adjusted_height = $h / $wm;
$half_height = $adjusted_height / 2;
$int_height = $half_height - $h_height;

imagecopyresampled($dimg,$simg,0,-$int_height,0,0,$nw,$adjusted_height,$w,$h);

} else {
    imagecopyresampled($dimg,$simg,0,0,0,0,$nw,$nh,$w,$h);
 }

imagejpeg($dimg,$dest,100);
}

?> 

[bpat1434]

Well, for one you could do:

$dh = dir('/path/to/images');
$files = array();
while(false !== ($entry = $dh->read()))
{
    if($entry != '.' && $entry != '..' && pathinfo($entry, PATHINFO_EXTENSION) == 'jpg')
        $files[] = $entry;
}

// Now with our list of files, let's create the thumbnails...
foreach($files as $file)
{
    cropImage(115, 77, $file, 'jpg', '/path/to/images/thumbnails/'.$file);
}

Or more concisely:

$path_orig = '/path/to/images/';
$path_thumb = $path_orig.'thumbnails/';

chdir('/path/to/images');
$files = glob('*.jpg');
chdir(dirname(__FILE__));

foreach($files as $file)
{
    $large = $path_orig.$file;
    $thumb = $path_thumb.$file;

cropImage(115, 77, $large, 'jpg', $thumb);
}

There are quite a few other options to grab all the files of a particular type inside a directory, but I just gave you two that should work.

[mramonster]

Thank you very much for your time and effort. I was finally able to get it to work this morning :-D

Here's the final working code (I had to change a few things in order for it to work properly).

<?php
$path_orig = 'path/to/images/';
$path_thumb = $path_orig.'thumb/';

chdir($path_orig);
$files = glob('*.jpg');
chdir(dirname(__FILE__));

foreach($files as $file)
{
    $large = $path_orig.$file;
    $thumb = $path_thumb.$file;

cropImage(115, 77, $large, 'jpg', $thumb);
echo $path_orig.$file."<br /><br />";
echo $path_thumb.$file."<br /><br />";
} 


//Define Function
function cropImage($nw, $nh, $source, $stype, $dest) {

$size = getimagesize($source);
$w = $size[0];
$h = $size[1];

switch($stype) {
case 'gif':
$simg = imagecreatefromgif($source);
break;
case 'jpg':
$simg = imagecreatefromjpeg($source);
break;
case 'png':
$simg = imagecreatefrompng($source);
break;
}

$dimg = imagecreatetruecolor($nw, $nh);

$wm = $w/$nw;
$hm = $h/$nh;

$h_height = $nh/2;
$w_height = $nw/2;

if($w> $h) {

$adjusted_width = $w / $hm;
     $half_width = $adjusted_width / 2;
     $int_width = $half_width - $w_height;

imagecopyresampled($dimg,$simg,-$int_width,0,0,0,$adjusted_width,$nh,$w,$h);

} elseif(($w <$h) || ($w == $h)) {

$adjusted_height = $h / $wm;
$half_height = $adjusted_height / 2;
$int_height = $half_height - $h_height;

imagecopyresampled($dimg,$simg,0,-$int_height,0,0,$nw,$adjusted_height,$w,$h);

} else {
    imagecopyresampled($dimg,$simg,0,0,0,0,$nw,$nh,$w,$h);
 }

imagejpeg($dimg,$dest,100);
};
?>

[bpat1434]

Please mark this thread as resolved if it is.