[RESOLVED] Login script not working

[glima]

Hey guys, im a newbie since im posting here its obvious lol 😛
Anyway I dont want to take too much time talking non-sense so I'll get right to the point.
I'm Learning PHP and trying now to make a signup system. But it is not working properly.
If someone can please help me 🙂
Here is the code I've written (I only omitted the Form part):

<?php
require_once 'connection/dbconnect.inc';
$email = $_POST['email'];
$pass1 = $_POST['pass1'];
$pass2 = $_POST['pass2'];
$accntype = $_POST['accntype'];
$country = $_POST['country'];
$state = $_POST['state'];
$city = $_POST['city'];
$zip = $_POST['zipcode'];
$gender = $_POST['gender'];
$date =$_POST['year']."-".$_POST['month']."-".$_POST['day'];


if($email){
	$existingaccnt=mysql_query("SELECT * FROM users WHERE user_email='".$email."'");
		if(mysql_rum_rows($existingaccnt)==0){
			continue;
		}      else{
			   print "There is already an account with this email address.";
			   exit;
		}if(!$email || !$pass3 || !$accntype || !$country || !$state  || !$city || !$zip){
			print "Please fill in all the fields.";
			exit;
		       }else{
			   continue;
		}if($resp){
			continue;
		       }else{
		           print "Please enter Captcha.";
			   exit;
		}if(eregi("^([[:alnum:]]|_|\.|-)+@([[:alnum:]]|\.|-)+(\.)([a-z]{2,4})$", $_POST['email'])) {
			continue;
		        }else{
			    print "Please enter a valid email address.";
		}if(eregi("^[[:alnum:]]{8,16}$", $_POST['pass1'])) {
			continue;
		        }else{
			     print "Plese enter a password that consists only of letter and numbers, between 8 and 16 characters long.";
		}if($_POST['pass1']==$_POST['pass2']){
			$pass3=$pass1;
			continue;
		        }else{
			    print "Passwords dont match.";
		        }
}else{
	print "Your accont has been created with success! Please check your email";
	print $_POST['submit'];
	}
?>

It is only going straight to the last 'ELSE' so it seems like eveything is ok.. but im inserting everything wrong on the form.

[igorlopez]

Well since you always end up at the else part of your if statement your $email is obviously empty so the problem is most likely in your form....

As a newbie you need to learn how to debug and the first steps are just echoing out your variables to the browser. In your case put these statements after the variable assignments:

$email = $_POST['email'];
$pass1 = $_POST['pass1'];
$pass2 = $_POST['pass2'];
$accntype = $_POST['accntype'];
$country = $_POST['country'];
$state = $_POST['state'];
$city = $_POST['city'];
$zip = $_POST['zipcode'];
$gender = $_POST['gender'];
$date =$_POST['year']."-".$_POST['month']."-".$_POST['day'];
$email = $_POST['email'];
echo $pass1 . "<br>";
echo $pass2 . "<br>";
echo $accntype . "<br>";
echo $country . "<br>";
echo $state . "<br>";
echo $city . "<br>";
echo $zip . "<br>";
echo $gender . "<br>";
echo $date . "<br>";

[NogDog]

Here's a little one-liner I use a lot to inspect the data input from a form:

echo "<pre>".print_r($_POST, 1)."</pre>\n";

This can give you a quick "sanity check" to see what the form actually sent to your script and what the $_POST array keys are (change $POST to $GET if using the get method).

[glima]

Yo guys 🙂 lol just kidding. Anyway, I checked the output of the form:

Array
(
    [email] => [e-mail]
    [pass1] => passtest
    [pass2] => passtest
    [accntype] => Fan
    [country] => Brazil
    [state] => Sao Paulo
    [city] => city
    [zipcode] => 2187987979
    [month] => April
    [day] => 3
    [year] => 2005
    [gender] => male
    [recaptcha_challenge_field] =>(too long text, cut to look better)
    [recaptcha_response_field] => 43-10 canvases
    [button] => I accept. Sign me up.
)

but it still does not work... im gonna try to rewrite the code with 1 if and lots elseifs inside it to see if it works :S

[igorlopez]

I had a second go and actually ran your code on my server except for the form and the mySQL query but could not get it to work....
In my case it complained about the first continue; statement, why do you use it?
Changing that to a normal

if(!mysql_rum_rows($existingaccnt)==0){
print "There is already an account with this email address.";
exit;
}

took care of that issue.
Next one is that you are using $pass3 in the field validation which is not assigned...
I removed it and came to the same problem as before with your usage of continue statements. As I read your code they don't fill a purpose and are probably just wrong to use so I removed all continue; statements with corresponding changes to the conditions in your if statements. The next hurdle is your captcha check, here you are using $resp which is not assigned.
So your plan to rewrite sounds like a good plan.

[glima]

Eeeee guys my script is working 😃 Thank god lol 😛 like you said igor it was really going nowhere!

Now I have one more tip to ask, this script is just to filter on the client side now on the server side there is some more information I want to filter before register the user on the database.

How can I send the information of this script to another one that will finalize the process?

<?php
require_once 'connection/dbconnect.inc';
//reCaptcha
require_once('includes/recaptchalib.php');
$privatekey = "6LcxMQMAAAAAAHJ0G1cbSZ3_H0n6u-wlRUFRCfee";

//fields taken
$email = $_POST['email'];
$pass1 = $_POST['pass1'];
$pass2 = $_POST['pass2'];
$accntype = $_POST['accntype'];
$country = $_POST['country'];
$state = $_POST['state'];
$city = $_POST['city'];
$zip = $_POST['zipcode'];
$gender = $_POST['gender'];
$date =$_POST['year']."-".$_POST['month']."-".$_POST['day'];
$resp = recaptcha_check_answer ($privatekey,
                                $_SERVER["REMOTE_ADDR"],
                                $_POST["recaptcha_challenge_field"],
                                $_POST["recaptcha_response_field"]);

$checkexitingemail=mysql_query("SELECT * FROM users WHERE user_email='".$email."'");

if (mysql_num_rows($checkexitingemail)!=0){ //Check if the email already exists
			print "This email already has an account. If you forgot your password click here
			<a href='lostpass.php'>lost your password?</a>.<br>";
			exit;
}elseif(!eregi("^[[:alnum:]]{8,16}$", $_POST['pass1'])) {
			echo "Plese enter a password that consists only of letter and numbers, between 8 and 16 characters long.<BR>";
}elseif ($pass1 != $pass2){
			print "Password mismatch. Please enter the same password in both fields.";
			exit;
}elseif(!eregi("^([[:alnum:]]|_|\.|-)+@([[:alnum:]]|\.|-)+(\.)([a-z]{2,4})$", $_POST['email'])) {
			echo"Please enter a valid email address.<BR>";
}elseif($_POST['month'] == "Month" || $_POST['day'] == "Day" || $_POST['year'] == "Year"){
			print "Please select your birthdate";
			exit;
}elseif (!$resp->is_valid) {
		    print "Please re-enter the captcha.";
}elseif (!$email || !$pass1 || !$pass2 || !$accntype || !$country || !$state || !$city || !$zip ||
	!$date || !$gender){
			print "Please fill in all fields.";
			exit;
}else	{
   	 //send all this info to another script that will handle this info and send an email
   	 //to the user depending to its age or type.
	}	    

?>