displaying problem

mski0687

I've banged my hand on this for the past couple hours so maybe a new set up eyes will help. Problem I'm having is information from the database won't display. I get the title of the table and the column headers but the data won't insert like it suppose to.

mysql_connect(localhost,$username,$password);
@mysql_select_db($database) or die( "Unable to select database");
$query = 'SELECT * FROM pc ';
$result=mysql_query($query);

$num=mysql_numrows($result);

mysql_close();

echo "<b><center>Complete List of PCs Checked Out</center></b><br><br>";

?>
<table border="1" cellspacing="2" cellpadding="2">
<table>
<tr>

<th width="44"><font face="Arial, Helvetica, sans-serif">First Name</font></th>
<th width="44"><font face="Arial, Helvetica, sans-serif">Last Name</font></th>
<th width="76"><font face="Arial, Helvetica, sans-serif">Computer</font></th>
<th width="68"><font face="Arial, Helvetica, sans-serif">Request Number</font></th>
<th width="83"><font face="Arial, Helvetica, sans-serif">Office Comments</font></th>
<th width="27"><font face="Arial, Helvetica, sans-serif">PC S/N</font></th>
<th width="79"><font face="Arial, Helvetica, sans-serif">Keyboard S/N</font></th>
<th width="62"><font face="Arial, Helvetica, sans-serif">Monitor S/N</font></th>
<th width="29"><font face="Arial, Helvetica, sans-serif">PC Tag</font></th>
<th width="79"><font face="Arial, Helvetica, sans-serif">Keyboard Tag</font></th>
<th width="62"><font face="Arial, Helvetica, sans-serif">Monitor Tag</font></th>
<th width="51"><font face="Arial, Helvetica, sans-serif">Mouse</font></th>
<th width="69"><font face="Arial, Helvetica, sans-serif">Wireless Antenna</font></th>
<th width="49"><font face="Arial, Helvetica, sans-serif">Status</font></th>
<th width="302"><font face="Arial, Helvetica, sans-serif">ID#</font></th>
</tr>
<?
$i= 0;
while ($i < $num) {
$first=mysql_result($result,$i,'fn');
$last=mysql_result($result,$i,"ln");
$computer=mysql_result($result,$i,"computer");
$random=mysql_result($result,$i,"random");
$office=mysql_result($result,$i,"office");
$pc=mysql_result($result,$i,"pc");
$keyboard=mysql_result($result,$i,"keyboard");
$monitor=mysql_result($result,$i,"monitor");
$pctag=mysql_result($result,$i,"pctag");
$keyboardtag=mysql_result($result,$i,"keyboardtag");
$monitortag=mysql_result($result,$i,"monitortag");
$mouse=mysql_result($result,$i,"mouse");
$network=mysql_result($result,$i,"network");
$status=mysql_result($result,$i,"status");
$id=mysql_result($result,$i,"id");
?>
<tr>
<td><font face="Arial, Helvetica, sans-serif"><? echo $first; ?></font></td>
<td><font face="Arial, Helvetica, sans-serif"><? echo $last; ?></font></td>
<td><font face="Arial, Helvetica, sans-serif"><? echo $computer; ?></font></td>
<td><font face="Arial, Helvetica, sans-serif"><? echo $random; ?></font></td>
<td><font face="Arial, Helvetica, sans-serif"><? echo $office; ?></font></td>
<td><font face="Arial, Helvetica, sans-serif"><? echo $pc; ?></font></td>
<td><font face="Arial, Helvetica, sans-serif"><? echo $keyboard; ?></font></td>
<td><font face="Arial, Helvetica, sans-serif"><? echo $monitor; ?></font></td>
<td><font face="Arial, Helvetica, sans-serif"><? echo $pctag; ?></font></td>
<td><font face="Arial, Helvetica, sans-serif"><? echo $keyboardtag; ?></font></td>
<td><font face="Arial, Helvetica, sans-serif"><? echo $monitortag; ?></font></td>
<td><font face="Arial, Helvetica, sans-serif"><? echo $mouse; ?></font></td>
<td><font face="Arial, Helvetica, sans-serif"><? echo $network; ?></font></td>
<td><font face="Arial, Helvetica, sans-serif"><? echo $status; ?></font></td>
<td><font face="Arial, Helvetica, sans-serif"><? echo $id; ?></font></td>
</tr>
</table>
<p>
  <?
$i++;
}
?>

</body>
</html>

Any suggestions???
Thanks

jkurrle

I'm not familiar with that type of coding, but an alternative is to use mysql_fetch_array(). When using with MYSQL_ASSOC, you have the variable names directly associated with the table fields. For example:

$select="select * from pc";
$result=mysql_query($select)
  or die("Select statement \"$select\" had errors - ".mysql_error());
echo "Your table setup and header information";
while($row=mysql_fetch_array($result,MYSQL_ASSOC))
  {
  extract($row);
  echo "<td>$table_field_1</td><td>$table_field_2</td> etc.";
  }
echo "Your table closing information";

Hope this helps...

cahva

Heh.. Why not just use [man]mysql_fetch_assoc()[/man]? 🙂

Your code would work but you use mysql_close() which closes the connection and you cannot fetch anything after that. Why? Because the connection is closed! 😃 You dont have to use mysql_close() at all. Mysql will close after script execution has ended. Anyway as mski0687 said, code in a different(=cleaner and more efficient) way.

BTW, there is no need to use <font> tags. Use CSS like for example:

<table style="font-family: Arial, Helvetica, sans-serif">
<tr>
  ...

..or if you want to use the same font-family in all tables, just define it for all table tags:

<style type="text/css">
<!--
table {
  font-family: Arial, Helvetica, sans-serif;
}
-->
</style>

Put style definitions inside <head></head> tags.

jkurrle

I never claimed my code was terribly efficient, I was simply trying to answer an unanswered thread posted 5 days ago. My code snippet does require mysql_close(), however. I neglected to throw that in my example. Good catch!

igorlopez

You may have a problem using shorthanded php tags depending on your server configuration,
Replace

<td><font face="Arial, Helvetica, sans-serif"><? echo $first; ?></font></td>

with

<td><font face="Arial, Helvetica, sans-serif"><?php echo $first; ?></font></td>

cahva

@:
I wasnt criticising your code, just the mysql_fetch_assoc that I think is shorter. I had a mistake in post and meant that mski0687 should code the way you said 🙂