Help returning multiple values from Class

[Pinkmischief]

Hi guys i am quite new to classes in PHP

What i have is this class

class DbConnector extends SystemComponent {

var $theQuery;
var $link;

function DbConnector(){
	//Load the values from SystemComponent $settings;
	$settings = SystemComponent::getSettings();

	$host= $settings['dbhost'];
	$db = $settings['dbname'];
	$user = $settings['dbusername'];
	$pass = "";

	//Connect to the db
	$this->link = mysql_connect($host,$user,$pass);
	mysql_select_db($db);
	register_shutdown_function(array(&$this,'close'));



}
///Perform a query
function query($query){

	$this->theQuery = $query;
	return mysql_query($query, $this->link);

}
///Retrieve values 
function fetchArray($result){

	return mysql_fetch_array($result);

}

function getResults($result){

while(mysql_fetch_array($result)){
	$i = 0;	
	//amount of rows in db 
		$NumRows = mysql_num_rows($result);
		while ($i < $NumRows){
			return(mysql_fetch_array($result));
			return($NumRows);
			$i++;

		}

	}



}


///Close the MYSQL connection
function close(){

	mysql_close($this->link);


}

Now what im trying to do is retrive all results from a query in the main php page to display all entries in the database. It works fine when trying to retrieve 1 value but when i try to retrieve all values to display in the page it only will show the last entry not all the previous ones. :S

The code from the page calling this class.

require_once('includes/QueryProcessor.php');

$connector = new DbConnector();

$result = $connector->query('SELECT * FROM welcome');
$row = $connector->getResults($result);

echo "NumRows is ".$connector->getResults['$NumRows'];
echo"<br />".$row['Title'];

Any help would be appreciated.

Many Thanks Pinky. 🙂

[bretticus]

There are a few problems. Firstly, even though your getResults() method has a while loop it throws away one iteration and then immediately returns one row and then exists the loop. Then there's the calling the getResults() method again but no notion of a loop to display the records in the calling page. Finally, you can't call the method as if it were an array (that should have given you an error.)

I took the liberty of rewriting the method and including new one for getting the record count below:

// replace this one method

function getResults($result){          

		while(mysql_fetch_array($result)){ 
			$i = 0;     

			//amount of rows in db 
			$NumRows = mysql_num_rows($result); 
			while ($i < $NumRows){ 
			    return(mysql_fetch_array($result)); 
			    return($NumRows); 
			    $i++;
			} 		
		} 
    } 


// with these two

function getResults($result)
{
	$result_array = array();
	while ($row = mysql_fetch_assoc($result)) {
		$result_array[] = $row;
	}
	return $result_array;
}

function getNumRows($result)
{
	return mysql_num_rows($result);
}

Now if you do a simple foreach, you can loop through each row to show mulitple records:

require_once('includes/QueryProcessor.php'); 

$connector = new DbConnector(); 

$result = $connector->query('SELECT * FROM welcome'); 
$rows = $connector->getResults($result); 

echo "NumRows is ".$connector->getNumRows($result);

foreach ($rows as $row) {
	echo"<br />".$row['Title']; 
}

[Pinkmischief]

Thanks a great deal for your explanation and the rewrite 🙂 I can see what i was doing wrong 🙂

Regards Pinky. 🙂