Error in Function?

janet287

I am using an some existing and trying to edit it. Basically, I need this code to create a block with a link in it. That link needs to be a specific URL plus the courseid number of the course that the block exists in.

For example, say I am in ACC 101 which is courseid number 47. I need the block to have a link in it that when clicked on goes to say
http://www.yahoo.com & courseid = 47.

I think I am close with the code below, but it isn't quite working. Can anyone see what I have wrong?

<?php

class block_test extends block_list {
function init() {
$this->title = get_string('blockname', 'block_test');
}

function get_content() {
global $THEME, $CFG, $USER;

if($this->content !== NULL) {
return $this->content;
}

$this->content = new stdClass;
$this->content->items = array();
$this->content->icons = array();
$this->content->footer = '';

}
{ $this->content->items[]="<a $linkcss title=\"" . "href=\"$CFG->www.yahoo.com?id=$course->id\"></a>";

}
}
?>

HalfaBee

You have title=" , no closing " and there is no title attribute for <A>

janet287

Here is what I have now - still not working??

$this->content->items[]="<a $linkcss title=\"" . "href=\"$CFG->www.yahoo.com?id=$course->id\"">test</a>";

HalfaBee

change it to

$this->content->items[]="<a $linkcss href=\"www.yahoo.com?id=$course->id\"">test</a>";

what is $CFG-> supposed to do?

janet287

hmmm...still not working...here is the whole thing as I have it now...any ideas?

<?php

class block_test extends block_list {
function init() {
$this->title = get_string('blockname', 'block_test');
}

function get_content() {
global $CFG;

if($this->content !== NULL) {
return $this->content;
}

$this->content = new stdClass;
$this->content->items = array();

}
{
$this->content->items[]="<a $linkcss href=\"www.yahoo.com?id=$CFG=>$course->id\"">test</a>";
}
?>

HalfaBee

href=\"www.yahoo.com?id=". $CFG=>$course->id . \"">test</a>";

janet287

Here is what I have now - it still isn't working - got to be something small...

if ($this->content->items[]='<a $linkcss href="http://www.yahoo.com?id='.($COURSE->id).'">test</a>')

laserlight

What do you think that line of code does?

janet287

Basically I want it to create a link that goes to a web site such as www.yahoo.com and then adds the courseid to the end of that URL as a variable
so if the courseid is 47 I end up with
http://www.yahoo.com?id=47

Am I totally off base with my code? Sorry, I am trying to learn.

laserlight

Am I totally off base with my code?

You are on the right track, except that the if statement looked wrong, and indeed it is.

What you want to do is something like this:

$this->content->items[] = '<a ' . $linkcss . ' href="http://www.yahoo.com?id=' . $course->id . '">test</a>';

However, do $linkcss and $course even exist?

janet287

Ohhh...It seems to be working! Thanks so much!!

laserlight

No problem, and remember to mark this thread as resolved using the thread tools.