help plese, contact form

madox

I am new to php and I am trying to get a contact form to e-mail me.
I don't see any errors. I have two parts, contact and form.

Here is my contact.php code

<?php
ini_set ("display_errors", "1");
error_reporting(E_ALL);
$subject="from ".$_GET['your_name'];
$headers= "From: ".$_GET['your_email']."\n";
$phone="from: ".$_GET['your_phone'];
$address="from: ".$_GET['your_address'];
 $headers.='Content-type: text/html; charset=iso-8859-1';
mail("myemailaddress", $subject,  "
<html>
<head>
 <title>Contact letter</title>
</head>
<body>

<br>
  ".$_GET['message']."
</body>
</html>" , $headers);
echo ("Your message was successfully sent!");
?>
<script>
	resizeTo(300, 300)
	//window.close()
</script>

Here is my form code

<form action="contact.php" method="get">   

                                                            <div class="container1">
                                                                <div class="col-3">
                                                                    <div class="h"><input type="text" name="your_name" value="name"></div>
                                                                    <div class="h"><input type="text" name="your_address" value="name"/></div>
                                                                    <div class="h"><input type="text" name="your_phone" value="name"/></div>
                                                                    <div class="h"><input type="text" name="your_address" value="name" /></div>
                                                                </div>
                                                                <div class="col-4">
                                                                  <textarea name="message" cols="35" rows="35">message</textarea><br />
                                                                  <div class="fright">
                                                                  		<div class="link-2"><em><b><a href="#" onclick="document.getElementById('contact.php').submit()">Send</a></b></em></div>   

                                                                        <div class="indent"><div class="link-2"><em><b><a href="#" onclick="document.getElementById('contact.php').reset()">Clear</a></b></em></div></div>
                                                                  </div>
                                                              </div>
                                                              <br class="clear" />
                                                         </div>
                                                      </form>

1042

This should work just fine

$Name = $_GET['your_name']; //senders name
$recipient = "myemail"; //recipient's email
$mail_body = "<html><head><title>Contact letter</title></head><body><br>".$_GET['message']."</body></html>"; //mail body
$subject = "your subject here"; //subject
$header = "From: ". $_GET['your_name'] . " <" . $_GET['your_email'] . ">\r\n"; //optional headerfields
$header.='Content-type: text/html; charset=iso-8859-1';

mail($recipient, $subject, $mail_body, $header); //mail command :)

NogDog

I'd suggest using the "post" method in your form and the $POST array instead of $GET, as there is a platform-dependent limit on how many characters can be included in the URL.

Also, you'll need to do some validation/filtering on the input values before using them in the mail() command, unless you don't mind if spammers hijack your form. :eek:

Feel free to use any/all of the code on my web site for a contact form: http://www.charles-reace.com/PHP_and_MySQL/Contact_Form/

madox

For some reason it is still not working and I don't know why.