Open Link in a New Window

janet287

I've got the code for opening a link in a new window and I've got the code to access my link - but I am not sure how to incorporate a reference to $target in my link code to ensure it opens in a new window.

Can anyone help me?

$target = !empty($CFG->block_test_window) ? ' target="_blank"' : '';

$this->content->items[] = '<a ' . $linkcss . ' href="https://test.com/reports?/test/Responses&id=' . $COURSE->id . '">Responses</a>'; 
return $this->content;

NogDog

Just concatenate the $target variable into the <a> tag (much like you do the $linkcss variable).

PS: Since the "target" attribute is now deprecated in [X]HTML, the generally accepted "best practice" these days seems to be to use JavaScript instead, usually on an "onclick" event in the <a> tag (e.g.: see http://www.quirksmode.org/js/popup.html).

janet287

Thanks for the help. I tried adding it in, but I don't think I have it quite right... what am I doing wrong below?

$this->content->items[] = '<a ' . $linkcss . ' . $target . ' href="......

NogDog

Since you already have a space in front of "target", it looks like you could just do:

$this->content->items[] = '<a ' . $linkcss . $target . ' href="......

janet287

Cool. Perfect. I've got it!! Thanks.

nrg_alpha

NogDog;10888339 wrote:
PS: Since the "target" attribute is now deprecated in [X]HTML, the generally accepted "best practice" these days seems to be to use JavaScript instead, usually on an "onclick" event in the <a> tag

This leads me to wonder.. if it is discouraged to use 'target' as it is depreciated, what happens in the event the end user has his / her javascript disabled?

I personally simply middle moue click to open links in a new tab (this seems to be universal across all major up to date browsers). But if I'm not mistaken (and I could very well be here), relying on such actions may not work on javascript-onclick-driven links? I do recall having some issues that forced me to simply left-click the link to open it, as using the middle mouse button method didn't work under those circumstances.

Granted, perhaps I'm splitting hairs here in the face of the argument that not many internet users have their javascript disabled (which is probably true). However, as I keep reading in web dev sources... Javascript should 'enhance' features, not be the complete features in and of themselves..

On a side note, does HTML 5 have any new built in alternatives for this? Or is Javascript simply the complete recommended way?

NogDog

nrg_alpha;10888418 wrote:
This leads me to wonder.. if it is discouraged to use 'target' as it is depreciated, what happens in the event the end user has his / her javascript disabled?

If JS is not enabled/available, then the onclick attribute will be ignored and the link will be opened in the same window/tab (unless the user/browser has some other default behavior in effect).

Ultimately, the basic thrust of W3C.org seems to be to discourage ever forcing links to open in new windows/tabs and instead leaving it up to the user.

nrg_alpha

Makes sense, and thus duly noted.

Cheers,

NRG