Radio buttons not echoing

clintonkatie

I am a noob so please bear with me.

I am trying to build a form to record attendance for a group I am in. I am using radio buttons for Y or N. In my db each member is marked Y for each week as default. I want to only record the absences. My current form is echoing all the data correctly except the radio buttons, but I used the same radio button echo in a form that looks at individual data with success.

Here is my code:

<?php
$host="****"; // Host name
$username=""; // Mysql username
$password="**"; // Mysql password
$db_name="***"; // Database name
$tbl_name="******"; // Table name

// Connect to server and select databse.
mysql_connect("$host", "$username", "$password")or die("cannot connect");
mysql_select_db("$db_name")or die("cannot select DB");
$sql="SELECT * FROM $tbl_name ORDER BY Last_Name ASC";
$result=mysql_query($sql);
$count=mysql_num_rows($result);
if(!$result)die(mysql_error());
?>
<table width="500" border="0" cellspacing="1" cellpadding="0">
<form name="form1" method="post" action="">
<tr>
<td>
<table width="500" border="0" cellspacing="1" cellpadding="0">

<tr>
<td align="center"><strong>ID</strong></td>
<td align="center"><strong>First Name</strong></td>
<td align="center"><strong>Last Name</strong></td>
<td align="center"><strong>Sept_08_2008</strong></td>
</tr>
<?php
while($rows=mysql_fetch_array($result)){
?>
<tr>
<td align="center"><? $ID[]=$rows['ID_Number']; ?><? echo $rows['ID_Number']; ?></td>
<td align="center"><? $First_Name[]=$rows['First_Name']; ?><? echo $rows['First_Name']; ?></td>
<td align="center"><? $Last_Name[]=$rows['Last_Name']; ?><? echo $rows['Last_Name']; ?></td>
<td align="center"><? $Sept_08_2008[]=$rows['Sept_08_2008']; ?><?
echo("Yes: <input type='radio' name='Sept_08_2008' value='Y'");
if($Sept_08_2008 == Y) {
echo(" checked>");
} else {
echo(">");
}
echo("No: <input type='radio' name='Sept_08_2008' value='N'");
if($Sept_08_2008 == N) {
echo(" checked>");
} else {
echo(">");
}
?> </td>
</tr>
<?php
}
?>
<tr>
<td colspan="4" align="center"><input type="submit" name="Submit" value="Submit"></td>
</tr>
</table>
</td>
</tr>
</form>
</table>
<?php
// Check if button name "Submit" is active, do this
if($Submit){
for($i=0;$i<$count;$i++){
$sql1="UPDATE $tbl_name SET name='$First_Name[$i]', Last_Name='$Last_Name[$i]', Sept_08_2008='$Sept_08_2008[$i]' WHERE ID_Number='$ID_Number[$i]'";
$result1=mysql_query($sql1);
}
}

if($result1){
header("location:attendance.php");
}
mysql_close();
?>

Please let me know I have not been clear enough about what I am wanting to do. I currently have only one week inserted in the form. Once I get everything working I will add subsequent weeks.

Thanks!

HalfaBee

The only problem I could see is here, but it will still work.

When you say the radio buttons are not being evhoed, maybe there is no rows being returned.

if($Sept_08_2008 == Y) { // should be 'Y'
echo(" checked>");
} else {
echo(">");
}

clintonkatie

I already tried that hoping that it would work. It has no effect.

Weedpacket

ee12csvt wrote:
I already tried that hoping that it would work. It has no effect.

It's still the right thing to do.

<td align="center"><? $ID[]=$rows['ID_Number']; ?><? echo $rows['ID_Number']; ?></td>
<td align="center"><? $First_Name[]=$rows['First_Name']; ?><? echo $rows['First_Name']; ?></td>
<td align="center"><? $Last_Name[]=$rows['Last_Name']; ?><? echo $rows['Last_Name']; ?></td>
<td align="center"><? $Sept_08_2008[]=$rows['Sept_08_2008']; ?><?
echo("Yes: <input type='radio' name='Sept_08_2008' value='Y'");
if($Sept_08_2008 == Y) {
echo(" checked>");
} else {
echo(">");
}
echo("No: <input type='radio' name='Sept_08_2008' value='N'");
if($Sept_08_2008 == N) {
echo(" checked>");
} else {
echo(">");
}
?> </td>

The problem is those [] bits; they make $ID, $First_Name, and all the rest arrays of values (by the time you get to the end of the list, $ID will be containing all of the IDs in the list).

You're not using almost all of them, so you might as well drop the <? $ID[]=$rows['ID_Number']; ?> bits completely (and while I'm looking at that, I recommend you stick to using "<?php" and don't get into the habit of using "<?" ... Long story.).

The only exception is $Sept_08_2008[]. Like I said, you're making $Sept_08_2008 an array. And an array is never equal to "Y" (or "N" for that matter), the radio buttons never get checked (and the modern standard is to use checked="checked", not just checked).

So put <?php $Sept_08_2008 = $rows['Sept_08_2008'] ?> instead of what you have now, and see how it goes.

Now all of your radio buttons have the exact same name, which means you'll only be able to select one of them. I'm guessing that's not what you want, and what you want is for each row of radio buttons to work separately from the other rows. (If it is what you want you can stop reading.) They'll have to have different names. The cleanest way to do that will be to bring back $ID (not $ID[]!) and name the radio buttons as

echo("Yes: <input type='radio' name='Sept_08_2008[".$ID."]' value='Y'");

When you process the form, $POST['Sept_08_2008'] will have an array of all the radio buttons, with, for example $POST['Sept_08_2008'][3] having the value "Y" if row 3's "Y" button was selected.

Y'know, if there are only two choices then one checkbox would do the job better than two radio buttons....

clintonkatie

Thanks so much for your help. I have now abandoned the radio buttons and gone with a checkbox as you suggested. Everything is now echoing, but nothing is submitting to the db...

Can you help?

<?php
$host="***"; // Host name
$username=""; // Mysql username
$password="**"; // Mysql password
$db_name="***"; // Database name
$tbl_name="*******"; // Table name

<tr>
<td align="center"><strong>ID</strong></td>
<td align="center"><strong>First Name</strong></td>
<td align="center"><strong>Last Name</strong></td>
<td align="center"><strong>Sept_08_2008</strong></td>
</tr>
<?php
while($rows=mysql_fetch_array($result)){
?>
<tr>
<td align="center"><?php echo $rows['ID_Number']; ?></td>
<td align="center"><?php echo $rows['First_Name']; ?></td>
<td align="center"><?php echo $rows['Last_Name']; ?></td>
<td align="center"><?php $Sept_08_2008 = $rows['Sept_08_2008']; ?><?
echo("Yes: <input type='checkbox' name='Sept_08_2008[".$ID."]' value='1'");
if($Sept_08_2008 == '1') {
echo(" checked>");
} else {
echo(">");
}
?> </td>
</tr>
<?php
}
?>
<tr>
<td colspan="4" align="center"><input type="submit" name="Submit" value="Submit"></td>
</tr>
</table>
</td>
</tr>
</form>
</table>
<?php
// Check if button name "Submit" is active, do this
if($Submit){
for($i=0;$i<$count;$i++){
$sql1="UPDATE $tbl_name SET First_Name='$First_Name[$i]', Last_Name='$Last_Name[$i]', Sept_08_2008='$Sept_08_2008[$i]' WHERE ID_Number='$ID[$i]'";
$result1=mysql_query($sql1);
}
}

if($result1){
header("location:attendance.php");
}
mysql_close();
?>

igorlopez

This might be your problem (depending on your PHP environment)

if($Submit){

replace with

if($_POST['Submit']){

clintonkatie

Thanks igorlopez, but that did not work...any other ideas?

igorlopez

Have a look and see what your update query consist of by simply echoing it out,

if($POST_['Submit']){
   for($i=0;$i<$count;$i++){
      $sql1="UPDATE $tbl_name SET `First_Name`='$First_Name[$i]', `Last_Name`='$Last_Name[$i]', 
      `Sept_08_2008`='$Sept_08_2008[$i]' WHERE ID_Number='$ID[$i]'";
      echo "Query number $i = $sql1<br>";
      $result1=mysql_query($sql1);
   }
}

personally I don't know where $First_Name, $Last_Name, $Sept_08_2008 and $ID comes from and secondly, you are using $result1 further down hence will it only be the last query that is used in the if statement

if($result1){
header("location:attendance.php");
}