One variable works, other one doesn't?

[janet287]

Can anyone figure out why variable A below works but variable B doesn't? Does the PHP look correct?

Variable A:
if( $userid = "375" ) {
role_assign( $role->id, $userid, 0, $context->id, 0, 0, 1, 'database' );
} else {
role_assign($role->id, $user->id, 0, $context->id, 0, 0, 0, 'database');
}

Variable B:
if( $role->id == "14" ) {
role_assign( $role->id, $userid, 0, $context->id, 0, 0, 1, 'database' );
} else {
role_assign($role->id, $user->id, 0, $context->id, 0, 0, 0, 'database');
}

[laserlight]

Perhaps instead of:

if( $userid = "375" ) {

you wanted to write:

if( $userid == "375" ) {

[janet287]

Huh, I didn't even catch that mistake. But the thing is the userid one works and the role->id one doesn't? Can't figure out why?

[janet287]

Ha! I got it. The userid variable was supposed to be user->id. Thanks!

[nrg_alpha]

If 375 is a number, just don't encase it in quotes and reverse the order in your if statement:

if(375 == $userid){
   // do something...
}

Should you accidently use only a single equal sign by accident...

if(375 = $userid){
   // do something...
}

Oops.. does not compute! You cannot assign the number 375 to anything, as it is a constant value.

EDIT- Actually even with quotes, this still holds.