mysql query error

warzo69

This is a payroll website that i am building, the select box is loading correctly however the textarea is loading blank. there are no error messages being displayed. i have tried many variations with this and nothing has worked.

  <?php
  $result = mysql_query("SELECT fullname FROM employee");
  while ($row = mysql_fetch_array($result)) {
      echo "<option>".$row['fullname']."</option><br>";
  };
  ?>
              <option>New Employee</option>
            </select>
            <br/>
            <br/>
            <br/>
            <br/>

        <textarea name="txtempinfo" rows="5" cols="15" id="txtempinfo"/>
  <?php
$tmpVar = $_POST['select1'];
  $result = mysql_query("SELECT ssn, dob, add1, add2, phone, empid, position, hiredate, termdate, status, salary, driverslicense FROM employee WHERE fullname = '$tmpVar' ") or die(mysql_error());
  while ($row = mysql_fetch_array($result)) {
      echo "".$row['ssn']."|"."".$row['dob']."|"."".$row['add1']."|"."".$row['add2']."|".
           "".$row['phone']."|"."".$row['empid']."|"."".$row['position']."|"."".$row['hiredate']."|".
           "".$row['termdate']."|"."".$row['status']."|"."".$row['salary']."|"."".$row['driverslicense']."";
  };

  ?>
            </textarea>

i have tried changing the $tmpVar variable to $tmp_var, I have reversed all the quotes from single ' to double" and from double " to single '.

If I change

FROM employee WHERE fullname = '$tmpVar'

FROM employee WHERE fullname = 'John Smith'

then It correctly displays John Smiths details. i have also tried to change the query to count the rows and display that to see if was reading the database just not displaying the info but it displayed a 0, I have ran out of ideas. any help is greatly appreciated. And no John Smith is not a real person nor is the information loaded into the database. If you would like to see the code hosted you can go to redhammerconstruction.com , please excuse the lack of styling, i have dedicated all my time to fixing this coding error and not to appearance.

Jaokri

did you echo $_POST['select1'] and/or $tmpVar to see if it gets filled correctly?

Besides, all userinput ($POST, $GET) should only be used with mysql_real_escape_string() in mysql_query() to prevent sql-injections.

warzo69

I tried to echo the variable and it came up blank.
I changed the variable name and included real_escape_string as weel and still it is coming up blank. this includes the echo

<?php   

           echo '<textarea name="txtempinfo" rows="5" cols="15" id="txtempinfo"/>';

$select = mysql_real_escape_string($_POST['select1']);
  $result = mysql_query("SELECT ssn, dob, add1, add2, phone, empid, position, hiredate, termdate, status, salary, driverslicense FROM employee WHERE fullname = '$select' ") or die(mysql_error());
  while ($row = mysql_fetch_array($result)) {
      echo "".$row['ssn']."|"."".$row['dob']."|"."".$row['add1']."|"."".$row['add2']."|".
           "".$row['phone']."|"."".$row['empid']."|"."".$row['position']."|"."".$row['hiredate']."|".
           "".$row['termdate']."|"."".$row['status']."|"."".$row['salary']."|"."".$row['driverslicense']."";
  };


        echo '</textarea>';
        echo $select;
?>

warzo69

I also tried to echo ($_POST["select1"]); and it was also empty

Jaokri

Is your select-box namend correctly with <select name='select1'>?
Is your form method correctly set to <form action='yourPage.php' method='post'>?
submit-button is type='submit'? ie has problems with type='image'.
form-tag closed?

just a few ideas that can't be checked by the code you posted so far. the code u posted should work correctly.

warzo69

I am not using a submit button, rather the onchange event. The js code isnt working in ie however all our pc's are running firefox. I will eventually modify the code for multiple browsers.

here is the complete code:
empedit.php

  <head>

<script src="empedit.js" type="text/javascript" language="javascript"></script>

  </head>

    <form name="form1">

<div align="left">
  <table width="825" border="0" bgcolor="#FAFAFA">
    <tr>
      <td width="155" rowspan="6" valign="top">
        <div align="center">
            <select name="select1" id="select1" onChange='empsel()'/> 
  <?php
  $result = mysql_query("SELECT fullname FROM employee");
  while ($row = mysql_fetch_array($result)) {
      echo "<option>".$row['fullname']."</option><br>";
  };
  ?>
              <option>New Employee</option>
            </select>
            <br/>
            <br/>
            <br/>
            <br/>
<?php   

           echo '<textarea name="txtempinfo" rows="5" cols="15" id="txtempinfo"/>';

$select = mysql_real_escape_string($_POST["select1"]);
  $result = mysql_query("SELECT ssn, dob, add1, add2, phone, empid, position, hiredate, termdate, status, salary, driverslicense FROM employee WHERE fullname = '$select' ") or die(mysql_error());
  while ($row = mysql_fetch_array($result)) {
      echo "".$row['ssn']."|"."".$row['dob']."|"."".$row['add1']."|"."".$row['add2']."|".
           "".$row['phone']."|"."".$row['empid']."|"."".$row['position']."|"."".$row['hiredate']."|".
           "".$row['termdate']."|"."".$row['status']."|"."".$row['salary']."|"."".$row['driverslicense']."";
  };


        echo '</textarea>';
        echo ($_POST["select1"]);
?>

  </td>
<td width="299" height="10">Full Name or DBA
  </td>			
<td width="151" height="10">SSN / Tax ID
  </td>			
<td width="151" height="10">Position
  </td>
</tr>
<tr>
  <td width="299" height="10">
    <div align="left">
      <input type="text" name="txtfullname" id='txtfullname' value="Full Name or DBA"/>
    </div>
  </td>
  <td width="151" height="10">
    <div align="center">
      <input type="text" name="txtssn" id='txtssn'/>
    </div>
  </td>
  <td width="151" height="10">
    <div align="center">
      <input type="text" name="txtposition" id="txtposition"/>
    </div>
  </td>
</tr>
<tr>
  <td width="299" height="10">Address
  </td>			
<td width="151" height="10">Drivers License #
  </td>			
<td width="151" height="10">Start Date
  </td>
</tr>
<tr>
  <td width="299" height="10"> 
    <div align="center">
      <input name="txtadd1" id="txtadd1" type="text" value="Street Address"/>
      <input name="txtadd2" id="txtadd2" type="text" value="City State Zip"/>
    </div>
  </td>
  <td height="10">      
    <div align="center">
      <input type="text" name="txtdriverslicense" id="txtdriverslicense"/>
    </div>
  </td>
  <td height="10">
    <div align="center">
      <input type="text" name="txthiredate" id="txthiredate"/>
    </div>
  </td>
</tr>
<tr>
  <td width="299" height="10">Phone Number
  </td>			
<td width="151" height="10">Employee ID Number
  </td>			
<td width="151" height="10">Term Date
  </td>
</tr>
<tr height="20">
  <td width="299" height="10"> 
    <div align="left">
      <input name="txtphone" id="txtphone" type="text" value="XXX-XXX-XXXX"/>
    </div>
  </td>
  <td height="10">   
    <div align="center">
      <input type="text" name="txtempid" id="txtempid"/>
    </div>
  </td>
  <td height="10">
    <div align="center">
      <input type="text" name="txttermdate" id="txttermdate"/>
    </div>
  </td>
</tr>
<tr>
  <td height="20" rowspan="2">
    <div align="center">

    </div>
  </td>
  <td width="299" height="10">Date Of Birth
  </td>			
<td width="151" height="10">Status 
  </td>			
<td width="151" height="10">Salary 
  </td>
</tr>
  <td width="299" height="10">
    <div align="left">
      <input type="text" name="txtdob" id="txtdob"/>
    </div>
  </td>
  <td height="10">
    <div align="left">
      <select name="txtstatus" id="txtstatus"/>
        <option>Active</option>
        <option>Inactive</option>
      </select>
    </div>
  </td>
  <td height="10">
    <div align="center">
      <input type="text" name="txtsalary" id="txtsalary"/>
    </div>
  </td>
</tr>
  </table>
        </form>  

  </div>

and empedit.js

function empsel() {
document.getElementById('txtfullname').value = document.getElementById('select1').value;

var empinfo = document.getElementById('txtempinfo').value;
var emparry = new Array();
emparry = empinfo.split('|');

document.getElementById('txtssn').value = emparry[0]; 
document.getElementById('txtdob').value = emparry[1]; 
document.getElementById('txtadd1').value = emparry[2]; 
document.getElementById('txtadd2').value = emparry[3]; 
document.getElementById('txtphone').value = emparry[4]; 
document.getElementById('txtempid').value = emparry[5];
document.getElementById('txtposition').value = emparry[6]; 
document.getElementById('txthiredate').value = emparry[7]; 
document.getElementById('txttermdate').value = emparry[8]; 
document.getElementById('txtstatus').value = emparry[9]; 
document.getElementById('txtsalary').value = emparry[10]; 
document.getElementById('txtdriverslicense').value = emparry[11];  

}

warzo69

As far as i can see this should work. I am at a loss as to where to go with this. If there is another way to code this please tell me. i have been stuck on this for two weeks and would greatly appreciate a fix to this.

Jaokri

warzo69;10889280 wrote:
I am not using a submit button, rather the onchange event

There's the problem.
php runs serverside, javascript runs clientside.

So an javascript-event works only on the clientside and can't have effect on php.
To do something with php you have to send a request to the server, which will run through php and give the generated content back to the browser.
You need a submit-button and a form-action (POST, in your example).

warzo69

the code for the select box contains the onchange even and that is working fine? It is just the textarea that isnt working properly. Also if I hard code a name into the mysql query it works fine. an example of this is in red below

<?php   

           echo '<textarea name="txtempinfo" rows="5" cols="15" id="txtempinfo"/>';

$select = mysql_real_escape_string($_POST["select1"]);
  $result = mysql_query("SELECT ssn, dob, add1, add2, phone, empid, position, hiredate, termdate, status, salary, driverslicense FROM employee WHERE fullname = '[COLOR="Red"]John Smith[/COLOR]' ") or die(mysql_error());
  while ($row = mysql_fetch_array($result)) {
      echo "".$row['ssn']."|"."".$row['dob']."|"."".$row['add1']."|"."".$row['add2']."|".
           "".$row['phone']."|"."".$row['empid']."|"."".$row['position']."|"."".$row['hiredate']."|".
           "".$row['termdate']."|"."".$row['status']."|"."".$row['salary']."|"."".$row['driverslicense']."";
  };


        echo '</textarea>';
?>

Jaokri

$select = mysql_real_escape_string($_POST["select1"]);
  $result = mysql_query("SELECT ssn, dob, add1, add2, phone, empid, position, hiredate, termdate, status, salary, driverslicense FROM employee WHERE fullname = 'John Smith' ") or die(mysql_error());
  while ($row = mysql_fetch_array($result)) {
      echo "".$row['ssn']."|"."".$row['dob']."|"."".$row['add1']."|"."".$row['add2']."|".
           "".$row['phone']."|"."".$row['empid']."|"."".$row['position']."|"."".$row['hiredate']."|".
           "".$row['termdate']."|"."".$row['status']."|"."".$row['salary']."|"."".$row['driverslicense']."";
  }

This php code only runs once, on the server when the page is generated. So if you hardcode a name into the mysql_query it is correctly generated on first calling the page from the server.

Once again: php runs only on the server (take a look at the source code of the generated page, you won't find any php there).
JavaScript runs only clientside, so you can't change php-generated content using javascript.
u need to send your change of the select-box to the server, using a submit button.

Just try and you will see.

warzo69

I am going to attempt your suggestion. How would I do this without a submit button. I need it to appear seamless.

warzo69

ok I have found the answer that I was looking for, now it looks like itll be an allnighter trying to implement it.
http://www.tizag.com/ajaxTutorial/ajaxform.php