[RESOLVED] formatting query output

qrt123

Hi !

I have a simple mysql query:

$resultat = mysql_query('SELECT id, teamname, teamrank FROM teams ORDER BY teamrank, teamname ASC');

echo("<table cellspacing=\"0\" cellpadding=\"0\" width=\"500\" class=\"edittable\">
<tr><th>Teamname</th><th>Team rank</th></tr>");

while ($row = mysql_fetch_array($resultat))
  {
  echo("<tr>");
  echo("<td>" . $row["teamname"] . "</td>");
  echo("<td>" . $row["teamrank"] . "</td>");
  echo "</tr>";
  }
echo("</table>");
?>

It outputs like this:

team 1 rank 1
team 2 rank 1
team 3 rank 2
team 4 rank 2
and so on.

I would like to format the output like this:

team 1 rank 1
team 2 rank 1

team 3 rank 2
team 4 rank 2

Grouping the output according to team rank. Putting each group in it's own tablecell.
Any suggestions ? I'm not very good at this, and I have tried to search for solutions, but always ends up with something that is way too complicated for me. :queasy:
Thanks in advance.

ixalmida

The following should work...

while ($row = mysql_fetch_array($resultat)) 
  { 
  echo("<tr>"); 
  echo("<td>" . $row["teamname"] . "</td>"); 
  echo("<td>" . $row["teamrank"] . "</td>"); 
  echo "</tr>"; 

  // Echo a blank row if this ranking is higher than the last...
  if($row["teamrank"] > $prev_rank) echo "<tr><td colspan='2'></td></tr>";

  // Remember this rank for the next loop...
  $prev_rank = $row["teamrank"];
  }

qrt123

Thanks for your reply Ixalmida.

But the code you have suggested, does not make any difference.
It does not make any changes to the output.

In the line where you compare the row['teamrank'] to $prev_rank , you haven't defined the variable $prev_rank.
I don't understand that. The variable $prev_rank doesn't contain anything.
Am I right ?

I will try again. See what I can come up with.
You are welcome to try again. I really need to get this working.
🙂

djjjozsi

Let's try this. if you want to write an emty cell, use tha  

$prev_rank=0;
while ($row = mysql_fetch_assoc($resultat)) 
  { 
  echo("<tr>"); 
  echo("<td>" . $row["teamname"] . "</td>"); 
  echo("<td>" . $row["teamrank"] . "</td>"); 
  echo "</tr>"; 

  // Echo a blank row if this ranking is higher than the last...
  if($row["teamrank"] != $prev_rank) echo "<tr><td colspan='2'>&nbsp;</td></tr>";

  // Remember this rank for the next loop...
  $prev_rank = $row["teamrank"];
  }

ixalmida

Yep, I forgot to define the variable for the first iteration. My bad.

djjjozsi

you are not angry that I rewrote your code?

ixalmida;10889978 wrote:
Yep, I forgot to define the variable for the first iteration. My bad.

qrt123

Hi djjjozsi.
Thanks for Your suggestion.

Gettin' closer, but not there yet.

Your coding makes an odd result. It does break up the array, but in a peculiar way.
Looks like example shown below.

team 1 rank 1
team 2 rank 1

team 3 rank 2

team 4 rank 2
team 5 rank 2
team 6 rank 3

team 7 rank 3
and so on.

Getting a little confused here.
😕

ixalmida

Since you are already sorting the results ascending in your query, go back to the greater_than sign in the if statement and see if that fixes it.

if($row["teamrank"] > $prev_rank) echo "<tr><td colspan='2'></td></tr>";

One way or another, the problem is in the if condition.

By the way, PLEASE rewrite my code when it is wrong. Who would mind that?

b321

What about moving where you print out the blank row... (code stolen from previous posts...):evilgrin:

Also, don't print out a blank row at the top of the table ($row["teamrank"]!=1)

$prev_rank=0;
while ($row = mysql_fetch_assoc($resultat)) 
  { 
  // Echo a blank row if this ranking is higher than the last...
  if(($row["teamrank"] != $prev_rank) && ($row["teamrank"]!=1) ) echo "<tr><td colspan='2'>&nbsp;</td></tr>";

  echo("<tr>"); 
  echo("<td>" . $row["teamname"] . "</td>"); 
  echo("<td>" . $row["teamrank"] . "</td>"); 
  echo "</tr>"; 

  // Remember this rank for the next loop...
  $prev_rank = $row["teamrank"];
  }

qrt123

Sorry, but that just made it look odd in another way.

Thank you for trying again, ixalmida.

Now looks like:

team 1 rank 1
team 2 rank 1
team 3 rank 2
team 4 rank 2

team 5 rank 2
team 6 rank 3

team 7 rank 3

ixalmida

I've been beotch-slapped again. Good catch b321. I should probably debug my code before I confuse people!

qrt123

b321. You nailed it.

Thank You very much.
Now it looks like i want it to.

Thanks all for helping out.

Think I can say RESOLVED now.
(and go to bed and sleep well)

b321

ixalmida, these order of output stuff always gets me to waste alot of time.

Glad we could all help.

djjjozsi

Nice🙂

b321;10890001 wrote:
ixalmida, these order of output stuff always gets me to waste alot of time.

Glad we could all help.