unlink question

[leicaphotos]

trying to delete a file after it has been read -- my code is as follows:

function ListFiles($dir) {

if($dh = opendir($dir)) {

    $files = Array();
    $inner_files = Array();

    while($file = readdir($dh)) {
        if($file != "." && $file != ".." && $file[0] != '.') {
            if(is_dir($dir . "/" . $file)) {
                $inner_files = ListFiles($dir . "/" . $file);
                if(is_array($inner_files)) $files = array_merge($files, $inner_files); 
            } else {
                array_push($files, $dir . "/" . $file);
            }
        }
    }

    closedir($dh);
    return $files;
}
}

then it does all the display..

followed by:

if ($recipe_title =="" || $ingredients =="" || $instructions =="")
{
echo "error with file, saving file for later";
}

else
{

$sql="Insert into sbrecipe_recipes (sb_title,sbuser_id,sb_ingredient,sb_recipetext,sb_posted_on,sb_hits,sb_website,sbscore,sbno_of_ratings,sb_dish_type)";
		$sql.="values ('$recipe_title','$author','$ingredients', '$instructions', '$recipe_date','$hits','$website','$rating','$total_rates','$recipe_cat_id')";


unlink ('$file');
if (!unlink($file))
{
echo ("Error deleting $file");
exit;
}
else
{
echo "File successfully entered, file removed";
}
}

echo "$counter records added";
$counter = $counter + 1;

if (!mysql_query($sql,$connect))
  {
  die('Error: ' . mysql_error());
  }




}

keeps crapping out and won't delete file

any thoughts?

[Stryker250]

Your first unlink line is doing the deleting so trying it again on the next line will create an error because the file does not exist anymore.
So change

unlink($file)
if(!unlink($fie)){

to

if(!unlink($file)){

And that should stop it from bringing up an error. Unless the script does not have the correct permissions to delete the file.

[Weedpacket]

As a matter of fact

unlink ('$file');

won't delete anything unless you really do have a file named [font=monospace]$file[/font]. Variables aren't interpolated into single-quoted strings, remember.