[RESOLVED] Downloads From SQL

snipervip

I thought I had this working until I tried to download a file. When you click download it opens the popup box allows you to save the file, and download the file. The download goes very quickly, and turns up and empty zip file. Most of these were placed in the sql manually. A few were done using an upload script. Both methods have the same effect. These files are working and are not corrupt. I'm redoing an existing html link downloads area, and turning it sql, so I know these files work for download. One last thing, when I enter the direct link >> download.php?id=35 for example still downloads the file like it should but its empty as well. What do I need to change here? Any help is greatly appreciated.

EDIT == If this helps for a clue, on the popup it shows the size as 232 or 233 bytes on every single file. even thought when it's uploaded it puts the correct size
in the datebase ( I tested a few dozen. )

<?php
error_reporting(E_ALL);
if(isset($_GET['id']))
{
	include 'inc/config.php';
	include 'inc/opendb.php';

$id      = $_GET['id'];
$query   = "SELECT name, type, size, path, dis, icon FROM upload WHERE id = '$id'";
$result  = mysql_query($query) or die('Error, query failed');
list($name, $type, $size, $icon, $dis, $filePath) = mysql_fetch_array($result);

header("Content-Disposition: attachment; filename=$name");
header("Content-length: $size");
header("Content-type: $type");
    header("Content-type: $dis");
    header("Content-type: $icon");

readfile($filePath);

include 'inc/closedb.php';	
exit;
}

?>

<html>
<head>
<title>Downloads</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css">
a {
	color: #FFFFFF;
}
a:visited {
	color: #FFFFFF;
}
a:active {
	color: #FFFFFF;
}
a:hover {
	color: #FFFFFF;
}
.style1 {
	border: 2px solid #008000;
	background-color: #000000;
}
.style3 {
	text-align: center;
	border: 2px solid #008000;
	background-color: #000000;
}
.style4 {
	text-align: right;
	border: 2px solid #008000;
	background-color: #000000;
}
.style5 {
	text-align: right;
	border: 2px solid #008000;
	background-color: #000000;
	white-space: nowrap;
}
</style>
</head>

<body style="color: #FFFFFF; background-color: #000000;">
<center><img src="../images/Dl2.gif"></center><br><center> <strong>Files = <img src="../images/file.gif"> Liners = <img src="../images/liner.gif"> Local Band Music = <img src="../images/mp3.gif"></strong></center>
<?php
include 'inc/config.php';
include 'inc/opendb.php';

$query  = "SELECT id, name, dis, icon FROM upload";
$result = mysql_query($query) or die('Error, query failed');
if(mysql_num_rows($result) == 0)
{
	echo "Database is empty <br>";
} 
else
{
	while(list($id, $name, $dis, $icon) = mysql_fetch_array($result))
	{

?>
	<center><table style="width: 50%; float: left; height: 42px;" class="style1" align="left">
	<tr>
	  	  <td class="style5" style="width: 27px; height: 23px;"><img src="../images/<?=$icon;?>.gif"></td>
		<td style="width: 62%; height: 23px;" class="style3"><?=$dis;?></td>
		<td class="style4" style="width: 140px; height: 23px;"><a href="download.php?id=<?=$id;?>"><img src="../images/download.gif" height="23" width="140"  border="0"></a></td>

				</tr>
</table>
</center>
<?php		
	}
}
include 'inc/closedb.php';
?>

</body>
</html>

djjjozsi

i've not tested, you missed the header ....

<?

if ($_GET["file_id"])
{
$hostname="***";
$user="***";
$pass="****";
$dbase="***";$connection=mysql_connect("$hostname","$user","$pass");
$db=mysql_select_db($dbase,$connection);



$sql="SELECT * FROM files WHERE file_id='".mysql_real_escape_string($_GET["file_id"])."' LIMIT 1";
$result=mysql_query($sql);
if(mysql_num_rows($result)==1)
{
$row=mysql_fetch_assoc($result)
$fn = $row["folder"]."/".$row["filename"];

$fn = stripslashes($fn);
$fn = str_replace('.', '&', $fn);


// We'll be outputting a binary file
header("Content-type: application/octet-stream");
// It will be called ....
$filename = basename($fn);

header("Content-Disposition: attachment; filename=".$filename);
readfile($fn);
}
else
print "You've lost";
?>

Weedpacket

I'm pretty sure that this bit:

	header("Content-type: $type");
        header("Content-type: $dis");
        header("Content-type: $icon");

Won't be helping, either.

snipervip

If the problem is that I'm missing a header djjjozsi, how should I write that?

Weedpacket, are you saying if I took those lines out it would work?

I'm very new at php and sql, so please be descriptive.

djjjozsi

after this line,

header("Content-Disposition: attachment; filename=$name");

put this
header("Content-type: application/octet-stream");

and remove those, becouse you wanted to set more then 3 content type.

header("Content-type: $type");
    header("Content-type: $dis");
    header("Content-type: $icon");

bye.
jjozsi

snipervip

djjjozsi;10890890 wrote:
after this line,

header("Content-Disposition: attachment; filename=$name");

put this
header("Content-type: application/octet-stream");

and remove those, becouse you wanted to set more then 3 content type.
header("Content-type: $type");
    header("Content-type: $dis");
    header("Content-type: $icon"); 
bye.
jjozsi

Thank you but this didn't help it. I also want to add that these files are uploaded into directories and only the path is used in the SQL. I think it has something to do with the file size saying 223 or 233 bytes, but I'm not experienced enough to know were the problem is.

djjjozsi

Lets try this...

<?php
error_reporting(E_ALL);
if(isset($_GET['id']))
{
	include 'inc/config.php';
	include 'inc/opendb.php';

$id      = mysql_real_escape_string($_GET['id']);
$query   = "SELECT name, type, size, path, dis, icon FROM upload WHERE id = '$id'";

$result  = mysql_query($query) or die('Error, query failed');
if(mysql_num_rows($result)>0)
{
	$row=mysql_fetch_assoc($result); // LETS GET USED THIS METHOD...

	if (file_exists($row["path"])) 
	{
		header("Content-Disposition: attachment; filename=".basename($row["path"]));
		header("Content-type: application/octet-stream"); 
		readfile($filePath);
	}
	else
	print "File do not exists..";
}
else
print "No file found in the database...";

include 'inc/closedb.php';	
exit;
} // IF SOMETHING SEND WITH GET

?><html>
<head>
<title>Downloads</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css">
a {
	color: #FFFFFF;
}
a:visited {
	color: #FFFFFF;
}
a:active {
	color: #FFFFFF;
}
a:hover {
	color: #FFFFFF;
}
.style1 {
	border: 2px solid #008000;
	background-color: #000000;
}
.style3 {
	text-align: center;
	border: 2px solid #008000;
	background-color: #000000;
}
.style4 {
	text-align: right;
	border: 2px solid #008000;
	background-color: #000000;
}
.style5 {
	text-align: right;
	border: 2px solid #008000;
	background-color: #000000;
	white-space: nowrap;
}
</style>
</head>

<body style="color: #FFFFFF; background-color: #000000;">
<center><img src="../images/Dl2.gif"></center><br><center> <strong>Files = <img src="../images/file.gif"> Liners = <img src="../images/liner.gif"> Local Band Music = <img src="../images/mp3.gif"></strong></center>
<?php
include 'inc/config.php';
include 'inc/opendb.php';

$query  = "SELECT id, name, dis, icon FROM upload";
$result = mysql_query($query) or die('Error, query failed');
if(mysql_num_rows($result) == 0)
{
	echo "Database is empty <br>";
} 
else
{
	while(list($id, $name, $dis, $icon) = mysql_fetch_array($result))
	{

?>
	<center><table style="width: 50%; float: left; height: 42px;" class="style1" align="left">
	<tr>
	  	  <td class="style5" style="width: 27px; height: 23px;"><img src="../images/<?=$icon;?>.gif"></td>
		<td style="width: 62%; height: 23px;" class="style3"><?=$dis;?></td>
		<td class="style4" style="width: 140px; height: 23px;"><a href="download.php?id=<?=$id;?>"><img src="../images/download.gif" height="23" width="140"  border="0"></a></td>

				</tr>
</table>
</center>
<?php		
	}
}
include 'inc/closedb.php';
?>

</body>
</html>

snipervip

I gave that a try and it now says on all the files I manually added to the SQL "file doesn't exist" on the ones I uploaded useng the other script, it downloads empty zips and pictures that won't open. The file sizes in the download popups are still showing up as small bytes instead of kb or mb.

djjjozsi

hm.
lets see that file with notepad, what is inside ?

if you have download.php

if you add a value the filename, $filename="a.zip";

and copy a.zip next to download.php

what happen?

if the file is out of an upper directory then the download .php, you must use the path from the root:

-first_folder
- upload/
+ 1.zip

second_folder
+ download.php

/first_folder/upload/1.zip

lets write down the location of the download.php, and where is a test file located.

snipervip

I'm not sure what I'm doing wrong, but I've attached all the files I have for the script.

I have made a folder called "upload" inside that folder it contains index.php, download.php, my folder the files are in called "downloads" , and an "inc" folder ( opendb.php, closedb.php, config.php).

I'm at a loss here.

djjjozsi

And on data from the database how it looks like? I've made a correction at the readfile line, it had no value.

if the database the path to the file is correct, it must been good.

and after download the file, open with notepad, and see the content of it. it might has error message. If it has shave with us.

?php
error_reporting(E_ALL);
if(isset($_GET['id']))
{
    include 'inc/config.php';
    include 'inc/opendb.php';

$id      = mysql_real_escape_string($_GET['id']);
$query   = "SELECT name, type, size, path, dis, icon FROM upload WHERE id = '$id'";

$result  = mysql_query($query) or die('Error, query failed');
if(mysql_num_rows($result)>0)
{
    $row=mysql_fetch_assoc($result); // LETS GET USED THIS METHOD...

    if (file_exists($row["path"]))
    {
        header("Content-Disposition: attachment; filename=".basename($row["path"]));
        header("Content-type: application/octet-stream");
        readfile($row["path"]);
    }
    else
    print "File do not exists..";
}
else
print "No file found in the database...";

include 'inc/closedb.php';    
exit;
} // IF SOMETHING SEND WITH GET

?><html>
<head>
<title>Downloads</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css">
a {
    color: #FFFFFF;
}
a:visited {
    color: #FFFFFF;
}
a:active {
    color: #FFFFFF;
}
a:hover {
    color: #FFFFFF;
}
.style1 {
    border: 2px solid #008000;
    background-color: #000000;
}
.style3 {
    text-align: center;
    border: 2px solid #008000;
    background-color: #000000;
}
.style4 {
    text-align: right;
    border: 2px solid #008000;
    background-color: #000000;
}
.style5 {
    text-align: right;
    border: 2px solid #008000;
    background-color: #000000;
    white-space: nowrap;
}
</style>
</head>

<body style="color: #FFFFFF; background-color: #000000;">
<center><img src="../images/Dl2.gif"></center><br><center> <strong>Files = <img src="../images/file.gif"> Liners = <img src="../images/liner.gif"> Local Band Music = <img src="../images/mp3.gif"></strong></center>
<?php
include 'inc/config.php';
include 'inc/opendb.php';

$query  = "SELECT id, name, dis, icon FROM upload";
$result = mysql_query($query) or die('Error, query failed');
if(mysql_num_rows($result) == 0)
{
    echo "Database is empty <br>";
}
else
{
    while(list($id, $name, $dis, $icon) = mysql_fetch_array($result))
    {

?>
    <center><table style="width: 50%; float: left; height: 42px;" class="style1" align="left">
    <tr>
            <td class="style5" style="width: 27px; height: 23px;"><img src="../images/<?=$icon;?>.gif"></td>
        <td style="width: 62%; height: 23px;" class="style3"><?=$dis;?></td>
        <td class="style4" style="width: 140px; height: 23px;"><a href="download.php?id=<?=$id;?>"><img src="../images/download.gif" height="23" width="140"  border="0"></a></td>

                </tr>
</table>
</center>
<?php        

    }
}
include 'inc/closedb.php';
?>

</body>
</html>

snipervip

Inside the database the path is correct.

When I make the changes you suggest I see this error on my page now.

?php error_reporting(E_ALL); if(isset($_GET['id'])) { include 'inc/config.php'; include 'inc/opendb.php'; $id = mysql_real_escape_string($_GET['id']); $query = "SELECT name, type, size, path, dis, icon FROM upload WHERE id = '$id'"; $result = mysql_query($query) or die('Error, query failed'); if(mysql_num_rows($result)>0) { $row=mysql_fetch_assoc($result); // LETS GET USED THIS METHOD... if (file_exists($row["path"])) { header("Content-Disposition: attachment; filename=".basename($row["path"])); header("Content-type: application/octet-stream"); readfile($row["path"]); } else print "File do not exists.."; } else print "No file found in the database..."; include 'inc/closedb.php'; exit; } // IF SOMETHING SEND WITH GET ?>

Weedpacket

It's not an error; it's a typo. djjjozsi missed out the "<" in "<?php".

snipervip

Thanks it works great now. 🙂