Need help fixxing This

KiXeN

<?php 
if (!isset($_GET["link"])) include 'main.php';
else if(is_file($_GET["link"] . ".php") && $_GET["link"] !="index" ) include htmlspecialchars($_GET["link"] . ".php");
else include 'error.php';
?>

Need some help fixxing this code so it cant be attacked by XSS I'd like to fix this or maybe someone can help with a code that will work the same way this one does.

NogDog

What is $_GET['link'] supposed to contain: just a file name, a directory/filename, a URL, or what?

If just a filename, all you need to do is:

<?php
$file = (isset($_GET['link'])) ? basename($_GET['link']).'.php' : 'main.php';
if(!is_file($file) or !is_readable($file))
{
   $file = 'error.php';
}
include $file.'.php';
?>

KiXeN

Well its just going to using like,

<a href="index.php?link=programs">Programs</a>

basicly whatever I have is in the programs.php will load using:

<a href="index.php?link=programs">

Only reason I ask is because the code a asked for help fixxing some how can be attacked by some kinda XSS I just wanted something that hopefully cant be attacked.

Im still learning php I started out with using php to updating mysql data bases and getting info from the mysql but stuff like this im new to.

NogDog

My solution above should work as long a you are just expecting a file name like that ("progress") as opposed to a path like "path/to/somewhere/else/progress").