PHP Script Help

[IMP_TWI]

I wrote a script recently that I can't get error free. I tried to use multiple if / else/elseif statements and it errors out. I usually get an error like:

Parse error: syntax error, unexpected '{' in /home/tserv1l/public_html/original/files/quest.php on line 234

Or expecting '(' instead of '{' etc.

Anyone know the problem?

if ($action=="recruitkill")
  {

  $totalvthugs = "SELECT thugs FROM $prefix.user_characters WHERE nickname='$victim'";
	$result     = mysql_query($totalvthugs);
	$result_array = mysql_fetch_array($result);

  $totalathugs = "SELECT thugs FROM $prefix.user_characters WHERE nickname='$stats_array[nickname]'";
	$result     = mysql_query($totalathugs);
	$result_array = mysql_fetch_array($result);

$totalaweapon = "SELECT ak47s FROM $prefix.user_characters WHERE nickname='$stats_array[nickname]'";
                       $result = mysql_query($totalathugs) ;
                       $result_array = mysql_fetch_array($result) ;

$totalvweapon = "SELECT ak47s FROM $prefix.user_characters WHERE nickname='$victim'";
                       $result = mysql_query($totalvthugs) ;
                       $result_array = mysql_fetch_array($result) ;

	  If ($totalvthugs <=0)

           {
		print "Your victim does not have any units to attack!";


            } If ($totalathugs <=0){
              echo "You do not have any units!";


            } elseif ($totalaweapon >= $totalathugs) {

               $totaldamageposa = $totalaweapon / 2.5;

            } else ($totalaweapon == $totalathugs) {

               $totaldamageposa = $totalaweapon /2.5;

            } If ($totalaweapon <= $totalathugs) {

               $totaldamageposa = $totalathugs /2.5;

            } elseif ($totalvweapon >= $totalvthugs) {

               $totaldamageposv = $totalvweapon / 2.5;

            } elseif ($totalvweapon == $totalvthugs) {

               $totaldamageposv = $totalvweapon /2.5;

            } elseif ($totalvweapon <= $totalvthugs) {

               $totaldamageposv = $totalvthugs /2.5;

	    } elseif ($totaldamageposa >= $totaldamageposv) {

		$totalvunitskilled = ($totaldamageposa / $totaldamageposv;)
                    $totalaunitskilled = ($totaldamageposv / .$totaldamageposa;)

            } elseif {$totaldamageposa <= $totaldamageposv) {

		$totalvunitskilled = $totaldamageposv / $totaldamageposa;
                                $totalaunitskilled = $totaldamageposa / .$totaldamageposv;

	} else {

	$query    = "UPDATE $prefix.user_characters SET item_thug=item_thug-$totalaunitskilled WHERE nickname='$victim'";
	$result     = mysql_query($query);
	$query    = "UPDATE $prefix.user_characters SET item_thug=item_thug-$totalvunitskilled WHERE nickname='" . $stats_array["nickname"] . "'";
	$result     = mysql_query($query);

	send_news($victim,"" . $stats_array["nickname"] . " and his recruits drove by your house and gunned down $" . number_format($totalaunitskilled) . ".");
	gain_exp($stats_array["nickname"],15,150);
	echo "<center>You killed $" . number_format($totalvunitskilled) . ".</center><br>";
	$query    = "UPDATE $prefix.user_characters SET tokens=tokens-$attackcost WHERE nickname='" . $stats_array["nickname"] . "'";
	$result     = mysql_query($query);
}
else
{
	echo "<center>Your attempt at killing units failed.</center><br>";
	gain_exp($stats_array["nickname"],2,100);
	$query = "UPDATE $prefix.user_characters SET tokens=tokens-$attackcost WHERE nickname='" . $stats_array["nickname"] . "'";
	$result = mysql_query($query);
}
}}

[HalfaBee]

The problem is with these lines

        $totalvunitskilled = ($totaldamageposa / $totaldamageposv;)
                    $totalaunitskilled = ($totaldamageposv / .$totaldamageposa;)

)'s in the wrong spots ) after the ; )

[IMP_TWI]

Now I get error Parse error: syntax error, unexpected '{' in /home/tserv1l/public_html/original/files/quest.php on line 234 which is the blank space in between this code

               {
			print "Your victim does not have any units to attack!";


            } If ($totalathugs <=0){

[HalfaBee]

There were a couple of other errors, you really need to format the code a bit better to make it easy to debug.

<?php
	if( $action == 'recruitkill' )
	{
		$totalvthugs = "SELECT thugs FROM $prefix.user_characters WHERE nickname='$victim'";
		$result = mysql_query( $totalvthugs );
		$result_array = mysql_fetch_array( $result );
		$totalathugs = "SELECT thugs FROM $prefix.user_characters WHERE nickname='$stats_array[nickname]'";
		$result = mysql_query( $totalathugs );
		$result_array = mysql_fetch_array( $result );
		$totalaweapon = "SELECT ak47s FROM $prefix.user_characters WHERE nickname='$stats_array[nickname]'";
		$result = mysql_query( $totalathugs ) ;
		$result_array = mysql_fetch_array( $result ) ;
		$totalvweapon = "SELECT ak47s FROM $prefix.user_characters WHERE nickname='$victim'";
		$result = mysql_query( $totalvthugs ) ;
		$result_array = mysql_fetch_array( $result ) ;

	If( $totalvthugs <= 0 )
	{
		print 'Your victim does not have any units to attack!';
	}

	If( $totalathugs <= 0 )
	{
		echo 'You do not have any units!';
	}
	elseif( $totalaweapon >= $totalathugs )
	{
		$totaldamageposa = $totalaweapon / 2.5;
	}
	else( $totalaweapon == $totalathugs ) {
		$totaldamageposa = $totalaweapon /2.5;
	}

	If( $totalaweapon <= $totalathugs )
	{
		$totaldamageposa = $totalathugs /2.5;
	}
	elseif( $totalvweapon >= $totalvthugs )
	{
		$totaldamageposv = $totalvweapon / 2.5;
	}
	elseif( $totalvweapon == $totalvthugs )
	{
		$totaldamageposv = $totalvweapon /2.5;
	}
	elseif( $totalvweapon <= $totalvthugs )
	{
		$totaldamageposv = $totalvthugs /2.5;
	}
	elseif( $totaldamageposa >= $totaldamageposv )
	{
		$totalvunitskilled = ( $totaldamageposa / $totaldamageposv );
		$totalaunitskilled = ( $totaldamageposv / . $totaldamageposa );
	}
	elseif( $totaldamageposa <= $totaldamageposv )
	{
		$totalvunitskilled = $totaldamageposv / $totaldamageposa;
		$totalaunitskilled = $totaldamageposa / . $totaldamageposv;
	}
	else
	{
		$query = "UPDATE $prefix.user_characters SET item_thug=item_thug-$totalaunitskilled WHERE nickname='$victim'";
		$result = mysql_query( $query );
		$query = "UPDATE $prefix.user_characters SET item_thug=item_thug-$totalvunitskilled WHERE nickname='" . $stats_array[ 'nickname' ] . '\'';
		$result = mysql_query( $query );
		send_news( $victim, '' . $stats_array[ 'nickname' ] . ' and his recruits drove by your house and gunned down $' . number_format( $totalaunitskilled ) . '.' );
		gain_exp( $stats_array[ 'nickname' ], 15, 150 );
		echo '<center>You killed $' . number_format( $totalvunitskilled ) . '.</center><br>';
		$query = "UPDATE $prefix.user_characters SET tokens=tokens-$attackcost WHERE nickname='" . $stats_array[ 'nickname' ] . '\'';
		$result = mysql_query( $query );
	}
	else
	{
		echo '<center>Your attempt at killing units failed.</center><br>';
		gain_exp( $stats_array[ 'nickname' ], 2, 100 );
		$query = "UPDATE $prefix.user_characters SET tokens=tokens-$attackcost WHERE nickname='" . $stats_array[ 'nickname' ] . '\'';
		$result = mysql_query( $query );
	}
}

[IMP_TWI]

When I use that on the script I get this error: Parse error: syntax error, unexpected '{' in /home/tserv1l/public_html/original/files/quest.php on line 230

on the blank space in between these lines:

                    {
            print 'Your victim does not have any units to attack!';
        }

    If( $totalathugs <= 0 )

[HalfaBee]

There is no { there, are you sure you have the correct line?

[IMP_TWI]

Yes line 229 is }, line 230 is blank, Line 231 is the IF statment line

[HalfaBee]

there is a problem here

        {
            $totaldamageposa = $totalaweapon / 2.5;
        }
        else( $totalaweapon == $totalathugs ) {   // else doesn't have a condition should be elseif maybe

        $totaldamageposa = $totalaweapon /2.5;
    }

[HalfaBee]

and you need to remove the . here

        $totalvunitskilled = ( $totaldamageposa / $totaldamageposv );
        $totalaunitskilled = ( $totaldamageposv / . $totaldamageposa );
    }

[IMP_TWI]

I think that error is fixed now, I get the error Parse error: syntax error, unexpected '.' in /home/tserv1l/public_html/original/files/quest.php on line 253 now on line:

  $totaldamageposv = $totalvweapon /2.5;

[HalfaBee]

and you have 2 else's near the end.

[HalfaBee]

there was another . 2 lines down

[IMP_TWI]

$totalvunitskilled = ( $totaldamageposa / $totaldamageposv );
$totalaunitskilled = ( $totaldamageposv / . $totaldamageposa );
}

On that line how would i make it $totaldamageposv/ the decimal $totaldamageposa... say total damage is equal to 40, then i want it to be .40

[HalfaBee]

($totaldamageposa/100)

[IMP_TWI]

Now the original errors are gone and the script displays but when I click submit I get these errors:

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /home/tserv1l/public_html/original/files/attack.php on line 207

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /home/tserv1l/public_html/original/files/attack.php on line 210

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /home/tserv1l/public_html/original/files/attack.php on line 213

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /home/tserv1l/public_html/original/files/attack.php on line 216
Your victim does not have any units to attack!You do not have any units!

	}    //line 207

}}
        //line 210

elseif( $action == 'recruitkill' )
{  //line 213
    $totalvthugs = "SELECT thugs FROM $prefix.user_characters WHERE nickname='$victim'";
    $result = mysql_query( $totalvthugs );
    $result_array = mysql_fetch_array( $result );  //line 216

[IMP_TWI]

I fixed those errors by getting rid of the $result_array line, but now when I click submit it automatically echo's the "You do not have units, your victim does not have units" line and doesn't do the r est of the querys from the if/else statements

[HalfaBee]

add some debugging to lines like this
$result = mysql_query($totalvthugs);

    $result     = mysql_query($totalvthugs) or die( mysql_error() . "<br>$totalvthugs"  );

[IMP_TWI]

.I reposted, didn't check 2nd page edit

[IMP_TWI]

It still only displays Your victim does not have any units to attack!You do not have any units! and doesn't do the rest of the querys

[HalfaBee]

The lines you removed were important.

Errors are there to tell you there are problems, not to just remove the line.

If you have no programming experience, you need to learn a bit before you try modifying scripts.