Delte multipe index(s) from array

awreneau

Have a situation wherein I read a text file into an array:

$filename = file_get_contents("/etc/postfix/allowed_relay_ip");
$filename = explode("\n", $filename);

Then search that array for an entry:

if (array_search($ip_address, $filename)))
{
    echo "true<br />";
   }

else
{
    echo "false";

}

I print out the array so I can see what's happened to it w/ the print_r ($filename); command and every line has an index number, example:

[0] => #Localhost Subnet
    [1] => 127.0.0.0/8
    [2] => 
    [3] => # wes's IP
    [4] => 11.5.215.103
    [5] => 
    [6] => #Branch 704
    [7] => #MFP
    [8] => 11.4.36.12
    [9] => 
    [10] => #Branch 717, Charlotte NC
    [11] => # MFP
    [12] => 11.14.24.27

What I want to do is have a user enter the IP address they want to delete into a form, process that data through a series of integrity checks and then delete the ip address as well as the other 'metadata' with it. For instance if I wanted to delete the last IP address of 11.14.24.27, I'd want to delete #MFP and #Branch 717, Charlotte NC as well.

How would I go about doing that? I thought I could have the array defined by a blank line and have the array index be comprised of the data between each blank line and delete it all in one command. That is to say that Index 0 might have 2 or more lines associated with it.

dagon

array_search will return the key, then you can unset that key and the two before it.

awreneau

Excellent, I'll try that and post my findings.

Thanks

awreneau

Worked like a champ!

I used a foreach and unset the keys. The syntax:

$ip_address = "11.14.24.27";
$filename = file_get_contents("/etc/postfix/allowed_relay_ip");
$filename = explode("\n", $filename);
foreach($filename as $key => $value)
{
    if(stripos($value, $ip_address) !==false)
        {
            unset ($filename[$key]);
            unset ($filename[$key -1]);
            unset ($filename[$key -2]);
            unset ($filename[$key -3]);
        }
}
if ($found = (array_search($ip_address, $filename)))
{
    echo "true<br />";
     print "$found";


}

else
{
    echo "false";
    echo "<pre>";
    print_r ($filename);
}

I tossed in a little sanity check to be sure the IP address was deleted and as a CYA factor.

See a problem w/ this?

Thanks again.

dagon

unset ($filename[$key],$filename[$key -1],$filename[$key -2],$filename[$key -3]);

save you a few nanoseconds

awreneau

I'll have to give that a shot.

Thanks

awreneau

Works like a champ but I've run into another problem...

I added the form to the page so users can indicate what IP they want to delete and I have some logic testing in place that displays an error if the IP the user wants to delete is not in the array. The error is as follows:

The IP address is not listed in the mail relay.

The IP address is not listed in the mail relay.

The IP address is not listed in the mail relay.

The IP address is not listed in the mail relay.

The IP address is not listed in the mail relay.

The IP address is not listed in the mail relay.

The entire code is below. I moved the forloop outside the if statement thinking that may be the problem but, no joy.

<?php include("index.php"); ?>

<html> <head> <meta http-equiv="content-type" content="text/html; charset=iso-8859-1">
<link rel=StyleSheet href="style.css" type="text/css" media="screen"> </head>
<div id="rh-col">


<center><strong>Enter the IP address of the device that you would like to delete below.<br /> <br />
<form method="POST" action="<?=$PHP_SELF;?>">
IP Address:<input type="text" name="ip_address" /><br /><br />
<input type="submit" name="submit" Value="Submit" />
<input type="submit" name="submit" value="Reset" />
</form>
</strong></center>
<br /> <br />


<?php>
$button = $_REQUEST['submit'];
$ip_address = $_REQUEST['ip_address'];
$filename = file_get_contents("/etc/postfix/allowed_relay_ip"); //read contents into string
$filename = explode("\n", $filename); //read contents of string into an array, separator is new line
foreach($filename as $key => $value) //read each line of array and assign it a key value

//if the button clicked is Submit
if ($button == "Submit")
{
	if (!isset($_POST['$ip_address']))
	{
		if (empty($ip_address))
		{
			echo "<center><strong>You did not specify an IP address.</strong></center><br />";
		}
		else
		{
			if (preg_match("{^\b((25[0-5]|2[0-4]\d|[01]\d\d|\d?\d)\.){3}(25[0-5]|2[0-4]\d|[01]\d\d|\d?\d)\b$}", $ip_address))
			{


                                if(strpos($value, $ip_address)!==false) //check if the $ip_address is in the array and 
                                {
                                   unset ($filename[$key], $filename[$key -1], $filename[$key -2], $filename[$key -3], $filename[$key -4], $filename[$key -5]);
                                }
                                else
                                { 

                                   echo "<center><strong>The IP <font color = #0000CC>".$grep_ip."</font> address is not listed in the mail relay.</strong></center>>"; 
                                }

		}
		else
		{
			echo "<center><strong>The IP <font color = #0000CC>".$grep_ip."</font> address is invalid</strong</center>>";
		}
	}
}		
}
echo "<pre>";
print_r ($filename);
?>
</div>
</html>

?>

At a loss on this one. Once again, help would be much appreciated.

awreneau

I found the problem. Rather than using $filename = file_get_contents (/path/to/file);

I used

$filename = file("/path/to/file");

Worked like a champ...

Edit
Still having problem of each index returning a "not found" other than the one that actually was found.

If I comment out the else it works flawlessly. Still at a loss.

dagon

file() reads the file in to an array you then don't need explode

awreneau

OK, here is the code, I'm using file instead of file_get_contents. I can enter a valid IP and it's removed from the array as I want it to be. However, it's almost as tho the foreach I have runs over EVERY sequence in the array and produces an error for each index.

I've copied my entire code, following the code, I'll have the error.

<?php include("index.php"); ?>

<html> <head> <meta http-equiv="content-type" content="text/html; charset=iso-8859-1">
<link rel=StyleSheet href="style.css" type="text/css" media="screen"> </head>
<div id="rh-col">


<center><strong>Enter the IP address of the device that you would like to delete below.<br /> <br />
<form method="POST" action="<?=$PHP_SELF;?>">
IP Address:<input type="text" name="ip_address" /><br /><br />
<input type="submit" name="submit" Value="Submit" />
<input type="submit" name="submit" value="Reset" />
</form>
</strong></center>
<br /> <br />


<?php>
$button = $_REQUEST['submit'];
$ip_address = $_REQUEST['ip_address'];
$filename = file("/etc/postfix/allowed_relay_ip");
//$filename = explode("\n", $filename);
foreach($filename as $key => $value) //read each line of array and assign it a key value
//if the button clicked is Submit
if ($button == "Submit")
{
	if (!isset($_POST['$ip_address']))
	{
		if (empty($ip_address))
		{
			echo "<center><strong>You did not specify an IP address.</strong></center><br />";
		}
		else
		{
			if (preg_match("{^\b((25[0-5]|2[0-4]\d|[01]\d\d|\d?\d)\.){3}(25[0-5]|2[0-4]\d|[01]\d\d|\d?\d)\b$}", $ip_address))
			{
			    if(strpos($value, $ip_address) !==false) //check if the $ip_address is in the array
                            {
                                unset ($filename[$key], $filename[$key -1], $filename[$key -2], $filename[$key -3], $filename[$key -4], $filename[$key -5]);
                            }
                            else
                            {
                                echo "The ip address," .$ip_address. ", is not listed in the array.";
                            }

                    }
		else
		{
			echo "<center><strong>The IP address, <font color = #0000CC>".$ip_address."</font> ,is invalid</strong</center>>";
		}
	}
}
}

echo "<pre>";
print_r ($filename);
?>
</div>
</html>

Error:

The ip address,11.4.36.12, is not listed in the array.The ip address,11.4.36.12, is not listed in the array.The ip address,11.4.36.12, is not listed in the array.The ip address,11.4.36.12, is not listed in the array.The ip address,11.4.36.12, is not listed in the array.

It seems to me that the foreach is causing my problem but I cant figure how to get out of that. I want the array checked until the first match, then the IP shouldn't appear again in the array (I disallow duplicate IP's from being entered into the text file in another piece of code). I've come to that conclusion b/c it keeps printing the message "The ip address 11.4.36.12, is not listed in the array." hundreds of times.

Once again looking forward to your help.

dagon

you shouldn't be starting the foreach till just before the "if(strpos($value" line. there's no need for it till after the submit and check is done

awreneau

No joy, moved the foreach as you suggested. Code snippet below:

if (preg_match("{^\b((25[0-5]|2[0-4]\d|[01]\d\d|\d?\d)\.){3}(25[0-5]|2[0-4]\d|[01]\d\d|\d?\d)\b$}", $ip_address))
			{
			    foreach($filename as $key => $value) //read each line of array and assign it a key value
                            if(strpos($value, $ip_address) !==false) //check if the $ip_address is in the array
                            {
                                unset ($filename[$key], $filename[$key -1], $filename[$key -2], $filename[$key -3], $filename[$key -4], $filename[$key -5]);
                            }
                            else
                            {
                                echo "<center><strong>The ip address,<font color = #0000cc>" .$ip_address. "</font>, is not listed in the array</strong></center>.";
                            }

                    }
		else
		{
			echo "<center><strong>The IP address, <font color = #0000CC>".$ip_address."</font> ,is invalid</strong</center>>";
		}

Thanks for the help thus far...

awreneau

bump