Unknown error?

[IMP_TWI]

I fixed most of the initial errors but now I get this error which happens to be on a line where it shouldn't error out: Parse error: syntax error, unexpected T_ELSEIF in /home/tserv1l/public_html/original/files/attack.php on line 258

elseif($action=="recruitkill")
    {
	$victim_info = mysql_fetch_object(mysql_query("SELECT * FROM $prefix.user_characters WHERE nickname='".$victim."'"));
//        $totalvthugs = "SELECT item_thug FROM $prefix.user_characters WHERE nickname='$victim'";
//        $result = mysql_query( $totalvthugs );
//        $result_array = mysql_fetch_array($result);
//        $totalathugs = "SELECT item_thug FROM user_characters WHERE nickname='$stats_array[nickname]'";
//        $result = mysql_query( $totalathugs );
//        $result_array = mysql_fetch_array($result);
//        $totalaweapon = "SELECT ak47s FROM $prefix.user_characters WHERE nickname='$stats_array[nickname]'";
//        $result = mysql_query($totalaweapon) ;
//        $result_array = mysql_fetch_array($result) ;
//        $totalvweapon = "SELECT ak47s FROM $prefix.user_characters WHERE nickname='$victim'";
//        $result = mysql_query($totalvweapon) ;
//        $result_array = mysql_fetch_array($result) ;

$totalathugs = "SELECT * FROM user_characters WHERE nickname='".$nickname."'";
   $totalathugs = mysql_query($totalathugs);
   $totalathugs = mysql_fetch_array($totalathugs);

   $totalvthugs = "SELECT * FROM user_characters WHERE nickname='$victim'";
   $totalvthugs = mysql_query($totalvthugs);
   $totalvthugs = mysql_fetch_array($totalvthugs);

   $totalaweapon = "SELECT * FROM user_characters WHERE nickname='".$nickname."'";
   $totalaweapon = mysql_query($totalaweapon);
   $totalaweapon = mysql_fetch_array($totalaweapon);

   $totalvweapon = "SELECT * FROM user_characters WHERE nickname='$victim'";
   $totalvweapon = mysql_query($totalvweapon);
   $totalvweapon = mysql_fetch_array($totalvweapon);


/**
* print "<br>";
* print $totalathugs[item_thug];   error line 258
* print "<br>";
* print $totalvthugs[item_thug];
* print "<br>";
* print $totalaweapon[ak47s];
* print "<br>";
* print $totalvweapon[ak47s];
*/

$totalvthugs = $totalvthugs[item_thug];
$totalathugs = $totalathugs[item_thug];
$totalaweapon = $totalaweapon[ak47s];
$totalvweapon = $totalvweapon[ak47s];
/**print $totalvthugs;
*print $totalathugs;
*print $totalaweapon;
*print $totalvweapon;
*/ 
         If ( $totalvthugs <= 0 )
         {
             print 'Your victim does not have any units to attack!';

     elseif ( $totalathugs <= 0 )
     {
         echo 'You do not have any units!';

     else 
     {

         If ( $totalaweapon >= $totalathugs )

        {
         $aMaxDamage = $totalaweapon

        else 
        {
         $aMaxDamage = $totalathugs
        }



     $aMaxDamage = $aMaxDamage/(5.2);
        }


     If ( $totalvweapon >= $totalvthugs )
     {
         $vMaxDamage = $totalvweapon

     else 
     {
         $vMaxDamage = $totalvthugs


     }

     $vMaxDamage = $vMaxDamage/(5/2);

     }

     If( $aMaxDamage >= $vMaxDamage )
     {
         $totalvunitskilled = ( $aMaxDamage / $vMaxDamage );
         $totalaunitskilled = ( $vMaxDamage / $aMaxDamage/100 );

     else( $aMaxDamage <= $vMaxDamage )
     {
        $totalvunitskilled = $vMaxDamage / $aMaxDamage;
        $totalaunitskilled = $aMaxDamage / $vMaxDamage/100;
     }

         $query = "UPDATE $prefix.user_characters SET item_thug=item_thug-$totalaunitskilled WHERE nickname='$victim'";
         $result = mysql_query( $query );
         $query = "UPDATE $prefix.user_characters SET item_thug=item_thug-$totalvunitskilled WHERE nickname='" . $stats_array[ 'nickname' ] . '\'';
         $result = mysql_query( $query );
         send_news( $victim, '' . $stats_array[ 'nickname' ] . ' and his recruits drove by your house and gunned down $' . number_format( $totalaunitskilled ) . '.' );
        gain_exp( $stats_array[ 'nickname' ], 15, 150 );
        echo '<center>You killed $' . number_format( $totalvunitskilled ) . '.</center><br>';
        $query = "UPDATE $prefix.user_characters SET tokens=tokens-$attackcost WHERE nickname='" . $stats_array[ 'nickname' ] . '\'';
        $result = mysql_query( $query );
                    }

[laserlight]

It might be this line:

else( $aMaxDamage <= $vMaxDamage )

Clearly, an else should not have a condition, because its condition is already implicitly the negation of the condition of its matching if.

[IMP_TWI]

I tried using an elseif instead but it still does the same error.. What I was doing with that line was comparing the MaxDamage a/v to see which one was higher then setting the variables for total killed

[IMP_TWI]

This is the current code after I edited it, but it still has the same error.

/**
* print "<br>";
* print $totalathugs[item_thug];
* print "<br>";
* print $totalvthugs[item_thug];
* print "<br>";
* print $totalaweapon[ak47s];
* print "<br>";
* print $totalvweapon[ak47s];
*/

$totalvthugs = $totalvthugs[item_thug];
$totalathugs = $totalathugs[item_thug];
$totalaweapon = $totalaweapon[ak47s];
$totalvweapon = $totalvweapon[ak47s];
/**print $totalvthugs;
*print $totalathugs;
*print $totalaweapon;
*print $totalvweapon;
*/ 
         If ( $totalvthugs <= 0 )
         {
             print 'Your victim does not have any units to attack!';

     elseif ( $totalathugs <= 0 )
     {
         echo 'You do not have any units!';

     else 
     {

         If ( $totalaweapon >= $totalathugs )

        {
         $aMaxDamage = $totalaweapon

        else 
        {
         $aMaxDamage = $totalathugs
        }



     $aMaxDamage = $aMaxDamage/(5.2);



     If ( $totalvweapon >= $totalvthugs )
     {
         $vMaxDamage = $totalvweapon

     else 
     {
         $vMaxDamage = $totalvthugs


     }

     $vMaxDamage = $vMaxDamage/(5/2);

     }

     If( $aMaxDamage >= $vMaxDamage )
     {
         $totalvunitskilled = ( $aMaxDamage / $vMaxDamage );
         $totalaunitskilled = ( $vMaxDamage / $aMaxDamage/100 );

     else
     {
        $totalvunitskilled = $vMaxDamage / $aMaxDamage;
        $totalaunitskilled = $aMaxDamage / $vMaxDamage/100;


         $query = "UPDATE $prefix.user_characters SET item_thug=item_thug-$totalaunitskilled WHERE nickname='$victim'";
         $result = mysql_query( $query );
         $query = "UPDATE $prefix.user_characters SET item_thug=item_thug-$totalvunitskilled WHERE nickname='" . $stats_array[ 'nickname' ] . '\'';
         $result = mysql_query( $query );
         send_news( $victim, '' . $stats_array[ 'nickname' ] . ' and his recruits drove by your house and gunned down $' . number_format( $totalaunitskilled ) . '.' );
        gain_exp( $stats_array[ 'nickname' ], 15, 150 );
        echo '<center>You killed $' . number_format( $totalvunitskilled ) . '.</center><br>';
        $query = "UPDATE $prefix.user_characters SET tokens=tokens-$attackcost WHERE nickname='" . $stats_array[ 'nickname' ] . '\'';
        $result = mysql_query( $query );
                    }}

[laserlight]

Maybe you have more than one error. Where is line 258?

EDIT:
Okay, it looks like you are just not placing your braces properly. You lack too many closing braces. You also need to indent your code properly.

[IMP_TWI]

line 258 is the 2nd line on that part i pasted

[IMP_TWI]

• print "<br>";

[laserlight]

As I said, you need to indent your code and match opening and closing braces.

[Protato]

As laserlight pointed out you're missing more then enough closing braces, but you need the closing braces for the else's and the elseif's too.

//what you have
if(something){
  //code
elseif(somethingelse){
  //code


//what you need
if(something){
   //code
}elseif(somethingelse){
   //code
}else{
   //code
}
   //non condition code

Keep in mind that an else closes an if, it's if A or else B. You have a few instances where you start an if, break into an else without closing the if, then jumping back into the if -- but it could be the lack of closing braces that makes it look like this.

[IMP_TWI]

Now I get: Parse error: syntax error, unexpected T_VARIABLE in /home/tserv1l/public_html/original/files/attack.php on line 269

        If ( $totalvthugs <= 0 )
         {
             print 'Your victim does not have any units to attack!';
         }
         elseif ( $totalathugs <= 0 )           // line 269
         {
             echo 'You do not have any units!';
         }

         If ( $totalaweapon >= $totalathugs )

        {
         $aMaxDamage = $totalaweapon
         $aMaxDamage = $aMaxDamage/(5.2);         
        }else 
         {
         $aMaxDamage = $totalathugs
         $aMaxDamage = $aMaxDamage/(5.2);
         }







     If ( $totalvweapon >= $totalvthugs )
     {
         $vMaxDamage = $totalvweapon
         $vMaxDamage = $vMaxDamage/(5.2);
     }
     else 
     {
         $vMaxDamage = $totalvthugs
         $vMaxDamage = $vMaxDamage/(5.2);

     }





     If( $aMaxDamage >= $vMaxDamage )
     {
         $totalvunitskilled = ( $aMaxDamage / $vMaxDamage );
         $totalaunitskilled = ( $vMaxDamage / $aMaxDamage/100 );
     }
     else
     {
        $totalvunitskilled = $vMaxDamage / $aMaxDamage;
        $totalaunitskilled = $aMaxDamage / $vMaxDamage/100;
     }

         $query = "UPDATE $prefix.user_characters SET item_thug=item_thug-$totalaunitskilled WHERE nickname='$victim'";
         $result = mysql_query( $query );
         $query = "UPDATE $prefix.user_characters SET item_thug=item_thug-$totalvunitskilled WHERE nickname='" . $stats_array[ 'nickname' ] . '\'';
         $result = mysql_query( $query );
         send_news( $victim, '' . $stats_array[ 'nickname' ] . ' and his recruits drove by your house and gunned down $' . number_format( $totalaunitskilled ) . '.' );
        gain_exp( $stats_array[ 'nickname' ], 15, 150 );
        echo '<center>You killed $' . number_format( $totalvunitskilled ) . '.</center><br>';
        $query = "UPDATE $prefix.user_characters SET tokens=tokens-$attackcost WHERE nickname='" . $stats_array[ 'nickname' ] . '\'';
        $result = mysql_query( $query );

}

[laserlight]

It looks like the error is from even earlier in your code.

Also, your indentation can be more consistent, e.g.,

    if ( $totalvthugs <= 0 )
    {
        print 'Your victim does not have any units to attack!';
    }
    elseif ( $totalathugs <= 0 )           // line 269
    {
        echo 'You do not have any units!';
    }

if ( $totalaweapon >= $totalathugs )
{
    $aMaxDamage = $totalaweapon
    $aMaxDamage = $aMaxDamage/(5.2);
}
else
{
    $aMaxDamage = $totalathugs
    $aMaxDamage = $aMaxDamage/(5.2);
}

if ( $totalvweapon >= $totalvthugs )
{
    $vMaxDamage = $totalvweapon
    $vMaxDamage = $vMaxDamage/(5.2);
}
else
{
    $vMaxDamage = $totalvthugs
    $vMaxDamage = $vMaxDamage/(5.2);
}

if( $aMaxDamage >= $vMaxDamage )
{
    $totalvunitskilled = ( $aMaxDamage / $vMaxDamage );
    $totalaunitskilled = ( $vMaxDamage / $aMaxDamage/100 );
}
else
{
    $totalvunitskilled = $vMaxDamage / $aMaxDamage;
    $totalaunitskilled = $aMaxDamage / $vMaxDamage/100;
}

$query = "UPDATE $prefix.user_characters SET item_thug=item_thug-$totalaunitskilled WHERE nickname='$victim'";
$result = mysql_query( $query );
$query = "UPDATE $prefix.user_characters SET item_thug=item_thug-$totalvunitskilled WHERE nickname='"
    . $stats_array[ 'nickname' ] . '\'';
$result = mysql_query( $query );
send_news( $victim, $stats_array[ 'nickname' ]
    . ' and his recruits drove by your house and gunned down $'
    . number_format( $totalaunitskilled ) . '.' );
gain_exp( $stats_array[ 'nickname' ], 15, 150 );
echo '<center>You killed $' . number_format( $totalvunitskilled ) . '.</center><br>';
$query = "UPDATE $prefix.user_characters SET tokens=tokens-$attackcost WHERE nickname='"
    . $stats_array[ 'nickname' ] . '\'';
$result = mysql_query( $query );

}

[Protato]

The parser error should help you out a bit more on this one. What does it say, and what line? Take a look at the line of code before the one reported in the error.