[RESOLVED] loop w/in loop not returning as expected

[lisa99]

I have a loop within a loop that is not returning as expected.

Maybe my expectations are too high :rolleyes:

I'm trying to create a user defined number of "codes" that should be 9 characters long and alphanumeric (though all letters or all numbers doesn't really matter).

I'm only getting one number and I don't see what is failing.

Any help is sincerely appreciated.

<?php
$numofcodes=50;
for($i=0; $i<$numofcodes; $i++)
{

$numofchar=9;
	for ($c=0; $c<$numofchar; $c++)
	{

		srand((double)microtime()*1000000); 
		$selectchar = rand(0,32); 
		//now set 0-32 to alphanumeric...
		if ($selectchar == 0) 
		{
		$a="a";
		}
		elseif ($selectchar == 1) 
		{
		$a="b";    
		}
		elseif ($selectchar == 2) 
		{
		$a="c";    
		}
		elseif ($selectchar == 3) 
		{
		$a="d";    
		} 
		elseif ($selectchar == 4) 
		{
		$a="e";    
		}
		elseif ($selectchar == 5) 
		{
		$a="f";    
		}
		elseif ($selectchar == 6) 
		{
		$a="g";    
		}
		elseif ($selectchar == 7) 
		{
		$a="h";    
		}
		///////////////////////skip "i" for alphanumeric clarity...
		elseif ($selectchar == 8) 
		{
		$a="j";    
		}
		elseif ($selectchar == 9) 
		{
		$a="k";    
		}
		elseif ($selectchar == 10) 
		{
		$a="l";    
		}
		elseif ($selectchar == 11) 
		{
		$a="m";    
		}
		elseif ($selectchar == 12) 
		{
		$a="n";    
		}
		////////////////////skip "o" for alphanumeric clarity...
		elseif ($selectchar == 13) 
		{
		$a="p";    
		}
		elseif ($selectchar == 14) 
		{
		$a="q";    
		}
		elseif ($selectchar == 15) 
		{
		$a="r";    
		}
		elseif ($selectchar == 16) 
		{
		$a="s";    
		}
		elseif ($selectchar == 17) 
		{
		$a="t";    
		}
		elseif ($selectchar == 18) 
		{
		$a="u";    
		}
		elseif ($selectchar == 19) 
		{
		$a="v";    
		}
		elseif ($selectchar == 20) 
		{
		$a="w";    
		}
		elseif ($selectchar == 21) 
		{
		$a="x";    
		}
		elseif ($selectchar == 22) 
		{
		$a="y";    
		}
		elseif ($selectchar == 23) 
		{
		$a="z";    
		}
		elseif ($selectchar == 24) 
		{
		$a="2";    
		}
		elseif ($selectchar == 25) 
		{
		$a="3";    
		}
		elseif ($selectchar == 26) 
		{
		$a="4";    
		}
		elseif ($selectchar== 27) 
		{
		$a="5";    
		}
		elseif ($selectchar == 28) 
		{
		$a="6";    
		}
		elseif ($selectchar == 29) 
		{
		$a="7";    
		}
		elseif ($selectchar == 30) 
		{
		$a="8";    
		}
		elseif ($selectchar == 31) 
		{
		$a="9";    
		}
		elseif ($selectchar == 32) 
		{
		$a="1";    
		}

	$acode .=$a;
	$acodelen=strlen($acode);
	if ($acodelen==9)
		{
		echo "$acode <br>";			
		}

   }	

}

?>

[HalfaBee]

You need to empty $acode at the start of the first loop.
eg $acode = '';

[laserlight]

Instead of that huge if/else chain, it would be easier to write:

$chars = "abcdefghjklmnpqrstuvwxyz234567891";
$acode .= $chars[rand(0, 32)];

or more safely:

$chars = "abcdefghjklmnpqrstuvwxyz234567891";
$acode .= $chars[rand(0, strlen($chars)];

[lisa99]

Thank you HalfaBee for fixing the problem and Laserlight for shortening my code!

In case it helps another newbie like me...I got it to work like this...

<?php

$numofcodes=5;
for($i=0; $i<$numofcodes; $i++)
{		
	$numofchar=9;
	$chars = "1abc2def3ghj4klm5npq6rst7uvw8xyz9";

for($c=0; $c<$numofchar; $c++)
{
	$selectchar = mt_rand(0,strlen($chars)-1);
	$buildingcode = $buildingcode . $chars{$selectchar};	
}

$newcode=strtoupper($buildingcode);
echo $newcode . "<br>";
$buildingcode=""; 		
}

?>