Difficulty using class

[rokchik]

I'm using this shopping cart class:

<?php
class Cart {
 var $products = array();
 function Cart($products=array()) {
  $this -> products = $products;
 }

[SNIP...]

 function removeProduct($product) {
  if (!$this -> countProduct($product)) {
   return false;
  } else {
   if ($this -> products[$product] > 1) {
    $this -> products[$product]--;
   } else {
    unset($this -> products[$product]);
   }
   return true;
  }
 }
 function processInput($data = array()) {
  $loop = isset($data["amount"]) ? $data["amount"] : 1;
  if (isset($data["action"])) {
   switch($data["action"]) {
    case "Add to cart":
     if (isset($data["product"])) {
      for ($i=0; $i<$loop; $i++) {
       $this -> addProduct($data["product"]);
      }
     }
    break;
    case "remove":
     if (isset($data["product"])) {
      for ($i=0; $i<$loop; $i++) {
       $this -> removeProduct($data["product"]);
      }
     }
    break;
   }
  }
 }
}
?>

I'm having difficulty using the removeProduct method. I've tried submitting a form via post and using query strings like:

?action=remove&product=$product

Does anyone have a clue for sale, please? 😕

Thanks.

[dagon]

Cart::removeProduct($product);

or

$cart =new Cart();

$cart->removeProduct($product);

depends on the context and how your handling it. Assuming you have an add\edit methods working, it shouldn't be a big leap to remove.

[rokchik]

Thanks Dagon. That's what I thought. Here's the whole Cart class fyi:

<?php
class Cart {
 var $products = array();
 function Cart($products=array()) {
  $this -> products = $products;
 }
 function getProducts() {
  return $this -> products;
 }
 function countProduct($product) {
  if (!isset($this -> products[$product])) {
   return false;
  } else {
   return $this -> products[$product];
  }
 }
 function countTotal() {
  $return = 0;
  foreach ($this -> products as $product => $count) {
   $return+= $count;
  }
  return $return;
 }
 function addProduct($product) {
  if ($this -> countProduct($product)) {
   $this -> products[$product]++;
  } else {
   $this -> products[$product] = 1;
  }
  return true;
 }
 function removeProduct($product) {
  if (!$this -> countProduct($product)) {
   return false;
  } else {
   if ($this -> products[$product] > 1) {
    $this -> products[$product]--;
   } else {
    unset($this -> products[$product]);
   }
   return true;
  }
 }
 function processInput($data = array()) {
  $loop = isset($data["amount"]) ? $data["amount"] : 1;
  if (isset($data["action"])) {
   switch($data["action"]) {
    case "Add to cart":
     if (isset($data["product"])) {
      for ($i=0; $i<$loop; $i++) {
       $this -> addProduct($data["product"]);
      }
     }
    break;
    case "remove":
     if (isset($data["product"])) {
      for ($i=0; $i<$loop; $i++) {
       $this -> removeProduct($data["product"]);
      }
     }
    break;
   }
  }
 }
}
?>

So I thought that the most sensible option would be to use the switch/case in the processInput method...

 foreach ($_SESSION["cart"] -> getProducts() as $product => $count) {
  echo '
    <tr>
     <td>'.stripslashes($product).'</td>
     <td>'.$count.'</td>
	 <td><a href="?action=remove&product='.$product["id"].'">X</a></td>
    </tr>';
   }
 echo '

I get the link but it does nothing.
Thx

[laserlight]

Did you write this Cart class yourself?

rokchik wrote:

I get the link but it does nothing.

Of course, you need to check if $_GET['product'] is set, and if so, remove the product. That said, you should not be using a link to perform a "remove product" operation. Use a form passed with the POST method instead.

[rokchik]

Thanks Laserlight.
I changed the link to a form using this code:

<td>
		 <form method="post" action="index.php">
		 <input type="hidden" name="product" value="'.$product.'" />
		 <input type="hidden" name="del" value="del" />
		 <input type="submit" value="Remove" />
		 </form>
	 </td>
    </tr>';
   }
 echo '
  </tbody>
 </table>
';
}

if ($_POST["product"] && $_POST["del"]) {
	$delProduct = stripslashes($_POST["product"]);
	$_SESSION["cart"] -> removeProduct($delProduct);
}

It's better, but I have to press the 'remove' button twice to remove one product.
Thanks again.