File upload with directory creation

[trueinvestor]

I have a question on how to do a task with uploading a file but having it create a folder

First let me tell ya what I have.. I have it setup on a site where a person can upload verification documents and it goes to a folder call verifications BUT i need it to create a folder with there site name which I use the $_GET['site_name']; code.

I dont want to have to make the folder becuz it would be way more work but I need it to get the site name in the url and create the folder make it "777" then save the uploaded files there.

Any help would be nice

Thanks
TI

[brbourdo]

trueinvestor;10893708 wrote:

I have a question on how to do a task with uploading a file but having it create a folder

First let me tell ya what I have.. I have it setup on a site where a person can upload verification documents and it goes to a folder call verifications BUT i need it to create a folder with there site name which I use the $_GET['site_name']; code.

I dont want to have to make the folder becuz it would be way more work but I need it to get the site name in the url and create the folder make it "777" then save the uploaded files there.

Any help would be nice

Thanks
TI

mkdir would be the function you need. and as im sure you already have set, just covering my bases, verifications would obviously need to be chmod 777

something like:

$pathToVerifications = "/path/to/verifications/";
$site_name = $_GET['site_name'];
$newDir = $pathToVerifications . $site_name;
$makeDirectory = @mkdir($newDir, 0777);

[trueinvestor]

Thanks for the reply but still having trouble.

I have this here

$target_path = "verifications/";
$site_name = $GET['site'];
$newDir = $target_path . $site_name;
$makeDirectory = @mkdir($newDir, 0777);
$target_path = $target_path . basename( $FILES['up1']['name']);
if(move_uploaded_file($_FILES['up1']['tmp_name'], $target_path)) {
}

Which this does create the folder but it puts the file being uploaded into the verifications folder and not the folder that was create.

I have tried everything not sure what I am doing wrong. I hope you can help

Thanks
TI

[brbourdo]

trueinvestor;10893711 wrote:

Thanks for the reply but still having trouble.

I have this here

$target_path = "verifications/";
$site_name = $GET['site'];
$newDir = $target_path . $site_name;
$makeDirectory = @mkdir($newDir, 0777);
$target_path = $target_path . basename( $FILES['up1']['name']);
if(move_uploaded_file($_FILES['up1']['tmp_name'], $target_path)) {
}

Which this does create the folder but it puts the file being uploaded into the verifications folder and not the folder that was create.

I have tried everything not sure what I am doing wrong. I hope you can help

Thanks
TI

that would be because you are telling it to upload to '$target_path' which you have set to just "verifications/".

make this line:
$target_path = $target_path . basename( $_FILES['up1']['name']);

this:
$target_path = $newDir . basename( $_FILES['up1']['name']);

[trueinvestor]

That didnt work. however I am getting closer

I have this here

$target_path = "verifications/". $site_name;
$site_name = $GET['site']; //site name and folder being created
$newDir = $target_path . $site_name; //directory to go in
$makeDirectory = @mkdir($newDir, 0777);
$target_path1 = $target_path . basename( $FILES['up1']['name']);
if(move_uploaded_file($_FILES['up1']['tmp_name'], $target_path1)) {
}

This puts the file being uploaded into the verifications dir but not into the dir that was created. The other way you told me didnt work with that line.

Any other suggestions?

Thanks
TI

[djjjozsi]

lets think of this option:

<?php

if(isset($_GET['site']) AND !empty($_FILES["up1"]["name"]) )
{
	$rexp_string_filter="^[A-Za-z0-9]*$";
	$check=ereg($rexp_string_filter, $_GET['site']);
	if($check OR strlen($_GET['site'])>4){

			$target_path = "verifications/".$_GET['site'];
			$makeDirectory = @mkdir($target_path, 0777);
			$target_path = $newDir . basename( $_FILES['up1']['name']);
			if(move_uploaded_file($_FILES['up1']['tmp_name'], $target_path))
			{
				print "Succesfully uploaded";
			}
		}
	else
	die("Site name must longer then 4 character, or not supported characters found in your site name!(allowed:A-Z,a-z,0-9)");

}
else
die("Errors: Did not add a site name/upload a file...");
?>

[trueinvestor]

Thats not how i need to have it done b ut the upload code on that code didnt work either.

This is what i have

$target_path = "verifications/". $site_name;
$site_name = $GET['site']; //site name and folder being created
$newDir = $target_path . $site_name; //directory to go in
$makeDirectory = @mkdir($newDir, 0777);
$target_path1 = $target_path . basename( $FILES['up1']['name']);
if(move_uploaded_file($_FILES['up1']['tmp_name'], $target_path1)) {
}

I did var_dumps and its not putting a / between the created dir and the file being uploaded

Thanks

[djjjozsi]

and this?

$site_name = $GET['site']; //site name and folder being created
$target_path = "verifications/". $site_name;
$newDir = $target_path . $site_name; //directory to go in
$makeDirectory = @mkdir($newDir, 0777);
$target_path1 = $target_path . basename( $FILES['up1']['name']);
if(move_uploaded_file($_FILES['up1']['tmp_name'], $target_path1)) {
}

[trueinvestor]

That is what i have now which makes teh folder just doesnt put the uploaded file in the created directory.

you have any suggestions

Thanks
TI

[djjjozsi]

we put the site name twice...

<?
$site_name = $_GET['site']; //site name and folder being created
$target_path = "verifications/";
$newDir = $target_path . $site_name; //directory to go in
$makeDirectory = @mkdir($newDir, 0777);
$target_path1 = $newDir."/" . basename( $_FILES['up1']['name']);
if(move_uploaded_file($_FILES['up1']['tmp_name'], $target_path1)) 
{
print "Copied as : $target_path1";
}

?>

And here is another method, store the site names in database. If its already in the table, lets select its ID number, and put the files into that folder. It is a safer method.

<?php
	$hostname='***'; //// specify host, i.e. 'localhost'
	$user='****'; //// specify username
	$pass='****'; //// specify password
	$dbase='****'; //// specify database name
	$connection = mysql_connect("$hostname" , "$user" , "$pass")
or die ("Can't connect to MySQL");
	$db = mysql_select_db($dbase , $connection) or die ("Can't select database.");



function check_data($content,$table,$field)
{
	$sql="SELECT * FROM $table WHERE $field='".mysql_real_escape_string(stripslashes(trim($content)))."'";
	if (mysql_num_rows(mysql_query($sql))>0)
	{
		$rows=mysql_fetch_assoc($result);
		return($rows);

	}
	else
	return(false);
}

function insert($content,$table,$field)
{
	$sql="INSERT INTO $table ($field) VALUES ('".mysql_real_escape_string(stripslashes(trim($content)))."')";
	$result=mysql_query($sql);
	if($result)
	return mysql_insert_id();
	else
	return false;
}


if(isset($_FILES) AND isset($_GET['site']))
{
$rows=check_data($_GET['site'],"site_names","Site_Name");
if($rows==false)
	{
	$id=insert($_GET['site'],"site_names","Site_Name");
	mkdir("verifications/$id", 0777);
	}

else
$id=$rows["id"];

print("The directory (ID) is $id<br>");

	$target_path1 = "verifications/$id/" . basename( $_FILES['up1']['name']);
	if(move_uploaded_file($_FILES['up1']['tmp_name'], $target_path1))
	{
		print "Copied as : $target_path1";
	}
	else
	die("File upload Failed : $target_path1");
}


?>
And this query will make the Site names table, and you can store the site names in there!
Run that in phpmyadmin

CREATE TABLE `site_names` (
`id` int(6) NOT NULL auto_increment,`Site_Name` varchar(255) NOT NULL default ''
,PRIMARY KEY (`id`),
UNIQUE KEY `id` (`id`)
) TYPE=MyISAM AUTO_INCREMENT=1;

[trueinvestor]

WOW alot of code there... I would rather do it the other way though because I will be adding more code to this , just i have to get this part done first.

you have anyway to tell it to put it in the created directory with the upload code i posted?

Thanks
TI

[djjjozsi]

i think this is working:

<?
$site_name = $_GET['site']; //site name and folder being created
$target_path = "verifications/";
$newDir = $target_path . $site_name; //directory to go in
$makeDirectory = @mkdir($newDir, 0777);
$target_path1 = $newDir."/" . basename( $_FILES['up1']['name']);
if(move_uploaded_file($_FILES['up1']['tmp_name'], $target_path1))
{
print "Copied as : $target_path1";
}

?> 

[trueinvestor]

awesome thanks. That did work. I appriciate your help.All i can pay ya with is a Thanks but if you ever need free webhosting let me know.

Thanks
TI

[djjjozsi]

not at all.

but lets play with that functions,
which could use another programs as well.

and another advice:
if you add folders, and files without filtering them, your site
is not been safe from hacker attacks.

if i add a site name: ..\

and upload a file get.php: containing
<?
$fn ="index.php";
header("Content-type: application/octet-stream");
$filename = basename($fn);
header("Content-Disposition: attachment; filename=".$filename);

?>

then i got your main site, with all the php, and personal passwords. (if you store the mysql password there for example...)
so that's why i write you at least an eregi string check.

bye.