PHP Help??

IMP_TWI

Alright.. Basically i'm trying to count a row, then use an echo if the statement is true. So I want to count the fields in a table.. that part is working fine, but when I do the echo which is elseif ($count > $limit) echo " Example"; It echo's the example whether it's true or false. Here is the code:

 function buy ($city,$sec,$id,$player) {
	global $biz; // loads business information
	global $stats_array; // loads user information
	global $prefix;

$countlimit = ("SELECT COUNT(organization)
FROM city_fronts WHERE organization ='$stats_array[family]'"); 


if ($stats_array[cash] < $biz[value]) {
	echo "You do not have enough cash to purchase this business. You need a total of $".number_format($biz[value])."";
}
elseif ($biz[owner]!="") {
	echo "This business is no longer for sale.";
}
		elseif ($stats_array[family] == '') {
		echo "You must be in a family before you can buy a property.";
	}


                   elseif ($countlimit > $max_famprop) {
                     echo "Families are only allowed to control 2 cities worth of businesses.";

             }

else {
	echo "True";

IMP_TWI

The problem is where it says $countlimit > max_famprop.. It echo's that message whether it's true or false.. Any one know what I'm doing wrong?

laserlight

You need to indent your code and quote your string indices correctly, e.g.,

function buy($city, $sec, $id, $player) {
    global $biz; // loads business information
    global $stats_array; // loads user information
    global $prefix;

$countlimit = "SELECT COUNT(organization)
    FROM city_fronts WHERE organization='$stats_array[family]'";
if ($stats_array['cash'] < $biz['value']) {
    echo "You do not have enough cash to purchase this business. You need a total of $"
        . number_format($biz[value]);
}
elseif ($biz['owner'] != '') {
    echo "This business is no longer for sale.";
}
elseif ($stats_array['family'] == '') {
    echo "You must be in a family before you can buy a property.";
}
elseif ($countlimit > $max_famprop) {
    echo "Families are only allowed to control 2 cities worth of businesses.";
}
else {
    echo "True";
}
}

Now, I notice that $countlimit is a string. This string appears to be an SQL statement, but you never actually executed the SQL statement. $max_famprop appears to be undefined.

By the way, avoid global variables as they can lead to tight coupling: you would find it difficult to rename $stats_array, for example.

IMP_TWI

$max_famprop is predefined in the beginning.. I tried to redefine it in the code by adding it under $countlimit but it still only echos "Families ... " whether $max_famprop is more or less then $countlimit.

IMP_TWI

function buy ($city,$sec,$id,$player) {
	global $biz; // loads business information
	global $stats_array; // loads user information
	global $prefix;
        $countlimit = "SELECT COUNT(organization)
        FROM city_fronts WHERE organization='$stats_array[family]'";
   $countlimit = mysql_query($countlimit);
   $countlimit = mysql_fetch_array($countlimit);
        $max_famprop = "50";

laserlight

IMP_TWI wrote:
$max_famprop is predefined in the beginning

Since it is not a local variable nor was it declared global, it does not exist in the function.

Now that you have defined it in the function and actually executed the SQL statement, you are further along the right track. However, this makes $countlimit an array:

$countlimit = "SELECT COUNT(organization)
    FROM city_fronts WHERE organization='$stats_array[family]'";
$countlimit = mysql_query($countlimit);
$countlimit = mysql_fetch_array($countlimit);

You want $countlimit to be a single scalar value:

$sql = "SELECT COUNT(organization)
    FROM city_fronts WHERE organization='$stats_array[family]'";
$result = mysql_query($sql);
$countlimit = mysql_result($result, 0);

IMP_TWI

I fixed the problem, I just had to change the counting method and query.

IMP_TWI

So that it said "SELECT COUNT(organization AS cnt ... " etc and it worked fine 🙂