Urgent Help!

[IMP_TWI]

<?php




$display = mysql_query("SELECT * FROM quiz ORDER BY id");

if (!$submit) {


echo "<form method=post action=$PHP_SELF>";
echo "<table border=0>";

while ($row = mysql_fetch_array($display)) {

$id = $row["id"];
$question = $row["question"];
$opt1 = $row["opt1"];
$opt2 = $row["opt2"];
$opt3 = $row["opt3"];
    $opt4 = $row["opt4"];
$answer = $row["answer"];

echo "<tr><td colspan=3><br><b>$question</b></td></tr>";
echo "<center><tr><td>$opt1 <input type=radio name=q$id value=\"$opt1\"></td><td>$opt2 <input type=radio name=q$id value=\"$opt2\"></td><td>$opt3 <input type=radio name=q$id value=\"$opt3\"></td><td>$opt4 <input type=radio name=q$id value=\"$opt4\"></td></tr></center>";

}

echo "</table>";
echo "<input type='submit' value='Select Option' name='submit'>";
echo "</form>";

}

elseif ($submit) 

{

$score = 0;
$total = mysql_num_rows($display);
	while ($result = mysql_fetch_array($display)) 


	{

		$answer = $result["answer"];
		$q = $result["q"];

	if ($$q == $answer) 
	{
	$score++; 
	}

}

echo "<p align=center><b>You scored $score out of $total</b></p>";
echo "<p>";

if   ($score == $total) {
echo "Congratulations! You got every question right!";
}
elseif ($score/$total < 0.34) {
echo "Oh dear. Not the best score, but don't worry, it's only a quiz.";
}
elseif ($score/$total > 0.67) {
echo "Well done! You certainly know your stuff.";
}
else {
echo "Not bad - but there were a few that caught you out!";
}

echo "</p>";

echo "<p>Here are the answers:";

echo "<table border=0>";
$display = mysql_query("SELECT * FROM quiz ORDER BY id");
while ($row = mysql_fetch_array($display)) {

$question = $row["question"];
$answer = $row["answer"];
$$q = $row["q"];

echo "<tr><td><br>$question</td></tr>";

if ($q == $answer) 
		{
		echo "<tr><td>&raquo;you answered ${$q}, which is correct</td></tr>";
		}
elseif ($q == "") {
echo "<tr><td>&raquo;you didn't select an answer. The answer is $answer</td></tr>";
}
else {
echo "<tr><td>&raquo;you answered ${$q}. The answer is $answer</td></tr>";
}

}
echo "</table></p>";



}

?>

[IMP_TWI]

Ok Now that the code's posted. I need help with a few things, First would be If I have more then one "quiz" question.. they all show up on the page.. what I want is for it to only show 1 quiz question and if you get the answer correct then let you move to the next multiple choice and so on so forth. The next part of the problem is that I want to insert a value into DB (table user_characters) if they get it wrong. Say they get one question wrong it would take them back to main menu and insert -1 into table user_characters field percent.

Any help would be greatly appreciated.

[djjjozsi]

If i were you, i change the tables structure a little bit.

This option does not clash your ideas what you did till now.

Create a session variable, a simple counter.

If the user gets into your quiz, its value is 0

Then create that mysql query with an addition LIMIT:

$limit_value="LIMIT {$_SESSION["counter"]},1";
$display = mysql_query("SELECT * FROM quiz ORDER BY id $limit_value");

when the user gives you the answer, increment this counter.
If you have the chance to store this counter - sessionID - IP pairs in database, its a better solution.

Or create a registration for this quiz.

(i think you can find so many debates about IP - SESSION identification in this forum too )

If i close the browser this value lost if you use session.

Count how many rows you got as a result, and if its 0, go to the congratulation page.

[IMP_TWI]

So that post confused me a bit.. Maybe I should list the fields in db and how it's pulled first to see if there's a simpler way to do it. The fields in the Db under that table are "id" "q" "question" "opt1-opt4" and "answer".. So when you create a question, the value "q" ends up numbering it.. so the first question created will get a value q1.. next will get q2.. so on and so forth. So basically I'm wondering if there's a way to do it based off of that? Or should I add a "correct" field which would add up their correct value, and if they get it wrong set it back to 0. Also I'm having problems writing it into the code > A friend helped me with the prior code I posted, at least the part that actually displays the questions/answers.. which Is why I'm not sure of how to get it working or what I should do to start.

[brbourdo]

I'd still do it with sessions.

Like when a user first comes to the main menu set a question session to "q1". Then pull the record from the database using the value from the session.

session_start();
$_SESSION["questionNum"] = "q1";
$questionNum = $_SESSION["questionNum"];

 ....

$query = @mysql_query("SELECT * FROM `questions_table` WHERE `q` = '$questionNum'");

Then as the user submits the form with his or her answer choice, just up the session by 1. Change it to q2. Then when your SELECT statement runs again it will be on q2 and show the next question.

You could also score the quiz the same way. If you have a quiz session defined like this:

session_start();
$_SESSION["correctAnswers"] = 0;
$correctAnswers = $_SESSION["correctAnswers"];

Then you just raise the correctAnswers session if they get a right answer.

At the end then, you would just use the same style for determining the number of right answers, like you already have, but use the $correctAnswer out of $total.

You could also add that to the database at the end if you wanted to keep track of users scores.

[IMP_TWI]

So what would I change in my current code to add that in/pull the right data in that order?

[IMP_TWI]

<?php




$limit_value="LIMIT {$_SESSION["counter"]},1";
$display = mysql_query("SELECT * FROM quiz ORDER BY id $limit_value"); 

if (!$submit) {


echo "<form method=post action=$PHP_SELF>";
echo "<table border=0>";

while ($row = mysql_fetch_array($display)) {

session_start();
$_SESSION["questionNum"] = "q1";
$questionNum = $_SESSION["questionNum"];



$query = @mysql_query("SELECT * FROM `questions_table` WHERE `q` = '$questionNum'"); 

$id = $row["id"];
$question = $row["question"];
$opt1 = $row["opt1"];
$opt2 = $row["opt2"];
$opt3 = $row["opt3"];
    $opt4 = $row["opt4"];
$answer = $row["answer"];

echo "<tr><td colspan=3><br><b>$question</b></td></tr>";
echo "<center><tr><td>$opt1 <input type=radio name=q$id value=\"$opt1\"></td><td>$opt2 <input type=radio name=q$id value=\"$opt2\"></td><td>$opt3 <input type=radio name=q$id value=\"$opt3\"></td><td>$opt4 <input type=radio name=q$id value=\"$opt4\"></td></tr></center>";

}

echo "</table>";
echo "<input type='submit' value='Select Option' name='submit'>";
echo "</form>";

}

elseif ($submit) 



{

session_start();
$_SESSION["correctAnswers"] = 0;
$correctAnswers = $_SESSION["correctAnswers"]; 

$score = 0;
$total = mysql_num_rows($display);
	while ($result = mysql_fetch_array($display)) 


	{


		$answer = $result["answer"];
		$q = $result["q"];

	if ($$q == $answer) 
	{
	$score++; 
	}

}

echo "<p align=center><b>You scored $score out of $total</b></p>";
echo "<p>";

if   ($score == $total) {
echo "Congratulations! You got every question right!";
}
elseif ($score/$total < 0.34) {
echo "Oh dear. Not the best score, but don't worry, it's only a quiz.";
}
elseif ($score/$total > 0.67) {
echo "Well done! You certainly know your stuff.";
}
else {
echo "Not bad - but there were a few that caught you out!";
}

echo "</p>";

echo "<p>Here are the answers:";

echo "<table border=0>";
$display = mysql_query("SELECT * FROM quiz ORDER BY id");
while ($row = mysql_fetch_array($display)) {

$question = $row["question"];
$answer = $row["answer"];
$$q = $row["q"];

echo "<tr><td><br>$question</td></tr>";

if ($q == $answer) 
		{
		echo "<tr><td>&raquo;you answered ${$q}, which is correct</td></tr>";
		}
elseif ($q == "") {
echo "<tr><td>&raquo;you didn't select an answer. The answer is $answer</td></tr>";
}
else {
echo "<tr><td>&raquo;you answered ${$q}. The answer is $answer</td></tr>";
}

}
echo "</table></p>";



}

?>

So where do I go from here? It errors out

[laserlight]

IMP_TWI wrote:

So where do I go from here? It errors out

You need to properly indent your code, and then you need to tell us what exactly is the error message.

You should be calling session_start() before using any session variables, and you certainly should not call session_start() in a loop. $submit is undefined, though you are probably relying on register_globals to be on, but you should not rely on that at all.

[IMP_TWI]

<?php


session_start();
$_SESSION["questionNum"] = "q1";
$questionNum = $_SESSION["questionNum"];
$limit_value="LIMIT {$_SESSION["counter"]},1";
$display = mysql_query("SELECT * FROM quiz ORDER BY id $limit_value"); 
$query = @mysql_query("SELECT * FROM `questions_table` WHERE `q` = '$questionNum'"); 


if (!$submit) {


	echo "<form method=post action=$PHP_SELF>";
	echo "<table border=0>";

while ($row = mysql_fetch_array($display)) {







$id = $row["id"];
$question = $row["question"];
$opt1 = $row["opt1"];
$opt2 = $row["opt2"];
$opt3 = $row["opt3"];
    $opt4 = $row["opt4"];
$answer = $row["answer"];

echo "<tr><td colspan=3><br><b>$question</b></td></tr>";
echo "<center><tr><td>$opt1 <input type=radio name=q$id value=\"$opt1\"></td><td>$opt2 <input type=radio name=q$id value=\"$opt2\"></td><td>$opt3 <input type=radio name=q$id value=\"$opt3\"></td><td>$opt4 <input type=radio name=q$id value=\"$opt4\"></td></tr></center>";

}

echo "</table>";
echo "<input type='submit' value='Select Option' name='submit'>";
echo "</form>";

}

	elseif ($submit) 

session_start();
$_SESSION["correctAnswers"] = 0;
$correctAnswers = $_SESSION["correctAnswers"]; 

{



$score = 0;
$total = mysql_num_rows($display);
	while ($result = mysql_fetch_array($display)) 


	{


		$answer = $result["answer"];
		$q = $result["q"];

	if ($$q == $answer) 
	{
	$score++; 
	}

}

echo "<p align=center><b>You scored $score out of $total</b></p>";
echo "<p>";

	if   ($score == $total) {
echo "Congratulations! You got every question right!";
}
	elseif ($score/$total < 0.34) {
echo "Oh dear. Not the best score, but don't worry, it's only a quiz.";
}
	elseif ($score/$total > 0.67) {
echo "Well done! You certainly know your stuff.";
}
	else {
echo "Not bad - but there were a few that caught you out!";
}

echo "</p>";

echo "<p>Here are the answers:";

echo "<table border=0>";
$display = mysql_query("SELECT * FROM quiz ORDER BY id");
while ($row = mysql_fetch_array($display)) {

$question = $row["question"];
$answer = $row["answer"];
$$q = $row["q"];

echo "<tr><td><br>$question</td></tr>";

	if ($q == $answer) 
	{
echo "<tr><td>&raquo;you answered ${$q}, which is correct</td></tr>";
	}
	elseif ($q == "") {
echo "<tr><td>&raquo;you didn't select an answer. The answer is $answer</td></tr>";
}
	else {
echo "<tr><td>&raquo;you answered ${$q}. The answer is $answer</td></tr>";
}

}
	echo "</table></p>";



}

?>

Alright here's the code.. The errors are on line 18, 56 and 57. The error that comes up is : Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /home/tserv1l/public_html/original/files/quest.php followed by the line number. It's also displaying the echo's at the end of the code when those should be reserved for when the test is done.

[HalfaBee]

It means that this query is wrong.

$display = mysql_query("SELECT * FROM quiz ORDER BY id $limit_value");

most likely the session variable is not set.

[IMP_TWI]

I switched a bit of it around, also changed sessions since my game already has sessions.. so I axed it from the script.. But the problem now is that it still errors out on 3 different lines. The new code is"

<?php

$limit_value="LIMIT $counter,1";

$questionNum = "q1";
$display = mysql_query("SELECT * FROM quiz ORDER BY id $limit_value"); 
$query = @mysql_query("SELECT * FROM `question` WHERE `q` = '$questionNum'"); 


if (!$submit) {


	echo "<form method=post action=$PHP_SELF>";
	echo "<table border=0>";

while ($row = mysql_fetch_array($display)) {     //line 16







$id = $row["id"];
$question = $row["question"];
$opt1 = $row["opt1"];
$opt2 = $row["opt2"];
$opt3 = $row["opt3"];
    $opt4 = $row["opt4"];
$answer = $row["answer"];

echo "<tr><td colspan=3><br><b>$questionNum</b></td></tr>";
echo "<center><tr><td>$opt1 <input type=radio name=q$id value=\"$opt1\"></td><td>$opt2 <input type=radio name=q$id value=\"$opt2\"></td><td>$opt3 <input type=radio name=q$id value=\"$opt3\"></td><td>$opt4 <input type=radio name=q$id value=\"$opt4\"></td></tr></center>";

}

echo "</table>";
echo "<input type='submit' value='Select Option' name='submit'>";
echo "</form>";

}

elseif ($submit) 


$correctAnswers = 0;


{



$score = 0;     //line 54
$total = mysql_num_rows($display);      //line 55
	while ($result = mysql_fetch_array($display)) 


	{


		$answer = $result["answer"];
		$q = $result["q"];

	if ($$q == $answer) 
	{
	$score++; 
	}

}

echo "<p align=center><b>You scored $score out of $total</b></p>";
echo "<p>";

if   ($score == $total) {
echo "Congratulations! You got every question right!";
}
elseif ($score/$total < 0.34) {
echo "Oh dear. Not the best score, but don't worry, it's only a quiz.";
}
elseif ($score/$total > 0.67) {
echo "Well done! You certainly know your stuff.";
}
else {
echo "Not bad - but there were a few that caught you out!";
}

echo "</p>";

echo "<p>Here are the answers:";

echo "<table border=0>";
	$display = mysql_query("SELECT * FROM quiz ORDER BY id");
	while ($row = mysql_fetch_array($display)) {

$question = $row["question"];
$answer = $row["answer"];
$$q = $row["q"];

echo "<tr><td><br>$question</td></tr>";

if ($q == $answer) 
		{
		echo "<tr><td>&raquo;you answered ${$q}, which is correct</td></tr>";
		}
elseif ($q == "") {
echo "<tr><td>&raquo;you didn't select an answer. The answer is $answer</td></tr>";
}
else {
echo "<tr><td>&raquo;you answered ${$q}. The answer is $answer</td></tr>";
}

}
echo "</table></p>";



}

?>

The errors I get are these:

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /home/tserv1l/public_html/original/files/quest.php on line 16

Warning: mysql_num_rows(): supplied argument is not a valid MySQL result resource in /home/tserv1l/public_html/original/files/quest.php on line 54

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /home/tserv1l/public_html/original/files/quest.php on line 55

[laserlight]

You did not connect to the database server and select a database.

[IMP_TWI]

The index code automatically connects to the DB, it pulls the files into a frame with the config.php file from the db with all the server connection details.

[laserlight]

Well, if you are sure that the database server connection is okay and the correct database is selected, then since the SQL statements themselves look syntactically correct, the problem must be with incorrect table or column names (either in the database or in the SQL statement), or perhaps the quiz table does not even exist.

Oh, and remove this line:

$query = @mysql_query("SELECT * FROM `question` WHERE `q` = '$questionNum'");

You do not use $query, and perhaps it is causing an error that is hidden by the @ operator.

EDIT:
Oh, and where is the $counter variable defined?

Frankly, if you have your code setup such that this file is correctly included so database connections, variables, etc exist or are in scope, you should not use this code as an example. Instead, come up with the smallest and simplest (runnable) code that demonstrates the error. Otherwise, it becomes difficult to zero in on the actual problem.

[IMP_TWI]

I tried to change the "echo $questionNum to query, but it didn't change the errors. The table name is quiz, so the table is there, as well as the fields in it (q, question, answer, opt1, opt2, opt3, opt4) which contain the info being pulled. The display value is probably not getting pulled right but I've tried changing it a few different ways and it doesn't seem to do it right.

[IMP_TWI]

I also changed the query $query to Select * From quiz instead of question

[laserlight]

When you get a warning like "supplied argument is not a valid MySQL result resource", the problem is due to one or more these:

• Failed to connect to database server.

• Failed to select correct database.

• Failed to execute SQL statement.

Since you are sure of the first two, the problem must be with the third.

One possible problem is that $counter is not defined, so your SQL statement becomes:

SELECT * FROM quiz ORDER BY id ,1

and that should result in a failed execution of the SQL statement.

Another possible problem is that the problem actually lies in this SQL statement:

$query = @mysql_query("SELECT * FROM `question` WHERE `q` = '$questionNum'");

But since you suppress errors from that, you do not detect anything. (Though actually, I suspect that a failed SQL statement execution here should not affect $display, but I personally would finish up a SELECT statement before executing another SQL statement.)

To get a better idea what is wrong, change this:

$display = mysql_query("SELECT * FROM quiz ORDER BY id $limit_value");
$query = @mysql_query("SELECT * FROM `question` WHERE `q` = '$questionNum'");

To this:

$display = mysql_query("SELECT * FROM quiz ORDER BY id $limit_value")
    OR die(mysql_error());

Additionally, you need to set error_reporting to E_ALL (or to E_ALL | E_STRICT).

[IMP_TWI]

I used the code you told me to replace and got this as the error "You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '1' at line 1"

[IMP_TWI]

So it has to be the $counter part of the code, but what I was using before wasn't working either with 'counter'

[laserlight]

IMP_TWI wrote:

So it has to be the $counter part of the code, but what I was using before wasn't working either with 'counter'

As I noted, $counter does not exist. You need to define it.