foreach in php5

ShawnK

I know this is pretty much pure laziness on my part but does anyone know what all changed with the foreach function in php5.

I had some old scripts that had:

foreach($array)
{
   dostuff($p);
}

and now it doesn't work unless i do:

foreach($array as $array)
{
   dostuff($p);
}

Is there a workaround for this so I don't have to go through all of them and edit every single foreach command?

laserlight

ShawnK wrote:
I know this is pretty much pure laziness on my part but does anyone know what all changed with the foreach function in php5.

As far as I know, that first version of foreach either has never existed, or was a deprecated relic of PHP3 that was never documented for PHP4 and became obsolete in PHP5.

ShawnK wrote:
I had some old scripts that had:

How did this version of foreach work? What is the $p variable?

ShawnK wrote:
and now it doesn't work unless i do:

But that is weird. I would have expected something like this:

foreach ($array as $p)
{
    dostuff($p);
}

EDIT:
Right, I wanted to install PHP 4.4.9 to check if it works, but it seems that I would need to downgrade from Apache 2.2 to Apache 2.0, but I did not bother in the end.

ShawnK wrote:
Is there a workaround for this so I don't have to go through all of them and edit every single foreach command?

Not that I know of.

ShawnK

That was a bad example, some of them were email validation scripts.

foreach($emails)
{
$check = eregi(regex............);
if($check)
{ yes }
else
{ no }
}

A long those lines, granted this was a few years back maybe 4 years? I haven't touched PHP in a while so it may have been 3. Not too sure

laserlight

ShawnK wrote:
That was a bad example, some of them were email validation scripts.

Mind giving a complete example that works on your previous version of PHP? What version of PHP is that?

Again, how does this foreach loop work? I can see no connection between $emails and the body of the loop.

ShawnK wrote:
A long those lines, granted this was a few years back maybe 4 years? I haven't touched PHP in a while so it may have been 3.

From the time I started using PHP 4.0.6 in 2001 (or was it 2000?) till now, I have never seen that version of the foreach loop.

Weedpacket

It's a new one on me, as well; and I can rule out its being a deprecated relic of PHP 3, since I recall PHP 3 and it didn't have foreach() at all.

The only change for foreach() that PHP 5 has is that foreach($array as &$value) is allowed and works as you might expect.

Weedpacket

It's a new one on me, as well; and I can rule out its being a deprecated relic of PHP 3, since I recall PHP 3 and it didn't have foreach() at all.

The only change for foreach() that PHP 5 has is that foreach($array as &$value) is allowed and works as you might expect.

ShawnK

This was written in '03 but I'm not sure the PHP version, I just found it on an external zip drive i had

<?php
// *******************************************
// * CHANGE THESE VALUES TO YOUR PREFERANCES *
// *******************************************

// the default image when today isn't a special day
$default_bg = "background-leaves.jpg";

// these are the special days\
$backgrounds = array(
					"11-20|11-29" => "tgiving.jpg",
					"12-25|12-29" => "xmas.jpg",
					"01-01|01-01" => "newyear.jpg",
					"09-11|09-11" => "sep11.jpg",
					"11-11|11-11" => "vetsdayjpg",
					"03-17|03-17" => "stpats.jpg",
					"03-23|03-23" => "easter.jpg",
					);

// this gets todays date in the mm-dd format
$today = date("m-d");	

// for testing purposes it prints the date
// echo "Today is: ".$today."<br><br>";

// this checks to see if today is a special day
foreach($backgrounds)
{
	$dates = explode("|", $backgrounds[0]);
	$start_date = $dates[0];
	$end_date = $dates[1];

if($start_date == $today)
{
	$today_bg = $backgrounds[1];
	return;
}				
else
{
	$today_sin = str_replace("-","", $today);
	$start_date_sin = str_replace("-","", $start_date);
	$end_date_sin = str_replace("-","", $end_date);
	if(($today_sin <= $end_date_sin) && ($today_sin >= $start_date_sin))
	{
		$today_bg = $backgrounds[1];
		return;
	}
	else
	{
		$today_bg = $default_bg;	
	}
}
}

function css($f_cssfile)
{
	global $today_bg;
	$f_file = file_get_contents($f_cssfile);
	$f_file = str_replace("__BG", $today_bg, $f_file);
	echo "<style>";
	echo $f_file;
	echo "</style>";
}
?>

laserlight

ShawnK wrote:
This was written in '03 but I'm not sure the PHP version, I just found it on an external zip drive i had

My guess is that the code was never tested and does not work due to syntax errors, so you have to fix it anyway.

ShawnK

This isn't of major importance I was just on here today and figured I might as well ask, it's been a while since i even tried that script so it may not work. But as i recall they all worked correctly before...