Help getting file names from array

[sks1024]

I have a form where users upload up to 5 images at a time. My script loops for each file and resizes them and puts on a watermark. Works great. I then want to write the path to these files in my database. How do i get the unique filename that the script gave to the images to write to the 5 fields in the table.

Here is the way it is setup now.

foreach ($_FILES["userfile"]["error"] as $key => $error) {

if ($error == UPLOAD_ERR_OK) {

$imgfile_name = $_FILES['userfile']['name'][$key];

//This is how the filenames are done.
srand((double)microtime()*1000000);  

$unique_str = md5(rand(0,9999999)); 
$p = strrpos($imgfile_name, "." ); 
$new_name = substr($imgfile_name , 0 , $p ) . $unique_str . substr($imgfile_name , $p , ( strlen($imgfile_name ) - $p ) );

$new_name = str_replace(" ","_",$new_name);

//Other things here

INSERT INTO TableName (pic1,pic2,pic3,pic4,pic5)
values ('$new_name','$new_name','$new_name','$new_name','$new_name')";

}

This writes the same 1st filename to the table. What should I do.

Thanks

[HalfaBee]

you need to do the insert outside the loop

foreach ($_FILES["userfile"]["error"] as $key => $error) {

if ($error == UPLOAD_ERR_OK) {

$imgfile_name = $_FILES['userfile']['name'][$key];

//This is how the filenames are done.
srand((double)microtime()*1000000);  

$unique_str = md5(rand(0,9999999));
$p = strrpos($imgfile_name, "." );
$new_name = substr($imgfile_name , 0 , $p ) . $unique_str . substr($imgfile_name , $p , ( strlen($imgfile_name ) - $p ) );

$new_names[] = $new_name = str_replace(" ","_",$new_name);

//Other things here

}
$sql = "INSERT INTO TableName (pic1,pic2,pic3,pic4,pic5)
values ('$new_names[0]','$new_names[1]','$new_names[2]','$new_names[3]','$new_names[4]')";
//db stuff here

[sks1024]

I am getting and error when I use your code of this.

Fatal error: [] operator not supported for strings in /home/u2/seaera/html/admin/add_image.php on line 22

It is coming from this line.

$new_name[] = $new_name = str_replace(" ","_",$new_name);

Thanks

[sks1024]

I got that to work by adding $key

new_name[$key] =

to the var name instead of just

new_name[] =

but it writes P in the db field instead of the image name

[laserlight]

You need to make up your mind: is $new_name a string or an array of strings?

[sks1024]

It will be an array of strings since the user will upload more than one image and the images will all have different filenames.

Hope that helps ypu to help me

Thanks

[laserlight]

sks1024 wrote:

It will be an array of strings since the user will upload more than one image and the images will all have different filenames.

Good. However, I believe that is actually redundant. The reason is that there is a terrible design flaw in your database: each row stores the paths of 5 images. Rather, each row should store the path to exactly one image.

With such an approach you can write:

foreach ($_FILES["userfile"]["error"] as $key => $error) {
    if ($error == UPLOAD_ERR_OK) {
        $imgfile_name = $_FILES['userfile']['name'][$key];

    // Process the filenames.
    $unique_str = md5(rand(0,9999999));
    $p = strrpos($imgfile_name, "." );
    $new_name = substr($imgfile_name, 0, $p )
        . $unique_str
        . substr($imgfile_name, $p, strlen($imgfile_name ) - $p);

    $new_name = str_replace(" ", "_", $new_name);

    // Other things here

    // $new_name should be sanitised at this point.
    $sql = "INSERT INTO TableName (pic) VALUES ('$new_name')";
    // ...
}
}

Note that this executes one SQL statement per loop iteration, so to be more efficient you should either wrap everything in a database transaction and make use of prepared statements, or make use of a multiple insert statement if your database engine allows for it.

[sks1024]

The db insert stuff isnt inside the loop

Each row stores the image name of 5 images in seperate fields.

just like your example. When I do it this way all 5 fields get the same image name written.

i.e

"INSERT INTO TableName (pic1,pic2,pic3,pic4,pic5) 
values ('$new_name','$new_name','$new_name,'$new_name','$new_name)";

[laserlight]

sks1024 wrote:

The db insert stuff isnt inside the loop

No, it should be inside the loop, unless you make use of a multiple insert statement.

sks1024 wrote:

Each row stores the image name of 5 images in seperate fields.

Why?

Think about this very carefully: are you saying that the nature of the data is such that each row should contain 5 images? If that is the case, then what happens if the user submits less than 5 images? Is that an error? Now, suppose sometime next year you do a redesign of the site and decide that you want users to upload 8 images at a time... is that even possible, or are you forever stuck with this 5 image limit?

[sks1024]

The pic fileds are NULL, so no error (I HOPE). I want nothing to be written to the fileds that didnt have an image uploaded because my output script checks strlen and outputs an image if there is one. If the user wants to upload more pictures I would add X more fields to the table and name them pic6, pic7.....

Here is my table structure

CREATE TABLE IF NOT EXISTS tbl_reports (
id int(255) NOT NULL auto_increment,
fldname text,
fldsubject text,
fldmessage text,
pic1 text,
pic2 text,
pic3 text,
pic4 text,
pic5 text,
flddate text,
fldip text,
PRIMARY KEY (id)
) ENGINE=InnoDB DEFAULT CHARSET=utf8 AUTO_INCREMENT=32 ;

Thanks

[laserlight]

sks1024 wrote:

The pic fileds are NULL, so no error (I HOPE). I want nothing to be written to the fileds that didnt have an image uploaded because my output script checks strlen and outputs an image if there is one. If the user wants to upload more pictures I would add X more fields to the table and name them pic6, pic7.....

That is indeed the "terrible design flaw in your database" that I mentioned earlier.

The table of images should store just that. Each row should contain the data for one image. Looking at your current table, it is apparent that you want to have many columns for different images because these images are associated with some "fld" thing. The solution is to have two tables: one to store the "fld" specific data, and another to store the image specific data. The two tables will be related via the primary key of the "fld" table.

As such, you could do something like this:

CREATE TABLE IF NOT EXISTS `tbl_reports` (
    `id` int(255) NOT NULL auto_increment,
    `fldname` text,
    `fldsubject` text,
    `fldmessage` text,
    `flddate` text,
    `fldip` text,
    PRIMARY KEY (`id`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8 AUTO_INCREMENT=32 ;

CREATE TABLE IF NOT EXISTS `tbl_reports_pics` (
    `id` int(255) NOT NULL auto_increment,
    `fldid` int(255) NOT NULL REFERENCES `tbl_reports`(`id`),
    `pic` text,
    PRIMARY KEY (`id`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8 AUTO_INCREMENT=32 ;

There is a one to many relationship between tbl_reports and tbl_reports_pics.

[sks1024]

I will make the change but I still have the problem of getting all of the image names in the database.

[laserlight]

sks1024 wrote:

I will make the change but I still have the problem of getting all of the image names in the database.

Ah, but with this changed design it is easy:

SELECT pic FROM tbl_reports_pics

The above SQL statement will give you all the image names. If you want all the image names for a particular report, use a WHERE clause, e.g.,

SELECT pic FROM tbl_reports_pics WHERE fldid=$fldid

Or maybe you want all the images associated with reports for a particular date:

SELECT pic FROM tbl_reports_pics, tbl_reports
WHERE tbl_reports_pics.fldid=tbl_reports.id AND tbl_reports.flddate='$date'

[sks1024]

this databse is big and I cant change it now. When I do this in the future i will use this design. I am inserting not selecting. How can I get the unique image names that my script creates for each image to be added in the database the way I have it. I have to get this working soon.

Thanks again

[laserlight]

sks1024 wrote:

this databse is big and I cant change it now. When I do this in the future i will use this design. I am inserting not selecting. How can I get the unique image names that my script creates for each image to be added in the database the way I have it. I have to get this working soon.

When you insert, the database is going to get bigger. If I should be frank, your current database design is brain damaged, worthy of mention in The Daily WTF. Your best bet is to change it now.

[sks1024]

how can i move all of the data around to make it work like you have shown

[laserlight]

This could be tough. Firstly, what is the data currently in the database like? For example, are the current "fld" rows repeated (e.g., there are more than 5 images associated with some of them)?

[sks1024]

i have attached a sql file for you to see the data. the structure is shown above.

[laserlight]

Um, this is not all the data you have, right? I mean, if you only have test data at this point then just generate new test data. It is retrofitting an existing database that is difficult, and I would rather have a database expert advise you on that.

[sks1024]

This is all of the data. I have others clients that much more data than this.