[RESOLVED] Need help with download error please??

[Lee_W]

Hi guys,

I am progressing with making files available to open via a dropdown menu by using the following script as an include file: -

<?php

if (isset($POST['pricelist']))
{
$getfile = $POST['pricelist'];

// define error handling
$nogo = 'Sorry, download unavailable.';

if (!$getfile)
{
// go no further if filename not set
echo $nogo;
}
else
{
// define the pathname to the file
$filepath = 'C:/htdocs/panasonic_system_pricing/'.$getfile;
// check that it exists and is readable
if (file_exists($filepath) && is_readable($filepath))
{
// get the file's size and send the appropriate headers
$size = filesize($filepath);
header('Content-Type: application/octet-stream');
header('Content-Length: '.$size);
header('Content-Disposition: attachment; filename='.$getfile);
header('Content-Transfer-Encoding: binary');
// open the file in binary read-only mode
// suppress error messages if the file can't be opened
$file = @ fopen($filepath, 'rb');
if ($file)
{
// stream the file and exit the script when complete
fpassthru($file);
exit;
}
else
{
echo $nogo;
}
}
else
{
echo $nogo;
}
}
}
?>

Now, when I select a file from the dropdown list & click 'download' I get a box asking whether I want to save or open the file. If I click on open I get the following error: -

'Acrobat could not open 'Filename[1].pdf' because it is either not a supported file type or because the file has been corrupted (for example, it was sent as an email attachment and wasn't correctly decoded).'

Any idea's?

[HalfaBee]

Try changing the type to text and see what is being sent.

[Lee_W]

Thanks for the reply.

I tried changing the type to .txt but still no joy.

If I manually open the folder where all the uploaded files are stored & open the file by double clicking on it the file opens fine in it's original format so i know it's not a corrupt file.

It is obviously something to do with the download script.

One thing I have noticed is that when the download window opens where it says 'From' which is the directory of the file to be opened it just says 'Localhost' & not the full directory as I am testing this on my local PC so I don't know whether this could be anything to do with it.

Any help would be great.

[Lee_W]

Great news.

I have managed to get it working by putting the include file at the beginning of the script & it now opens PDF files no problem.

However, other files such as Excel & jpeg files it doesn't open.

If I try to open a jpeg file I just get a box with a red cross.

If I try to open an excel (xls) file it opens in excel but it displays all the information in symbols, etc.

This is my modified script: -

<?php

if (isset($POST['pricelist']))
{
$getfile = $POST['pricelist'];

// define error handling
$nogo = 'Sorry, download unavailable.';

if (!$getfile)
{
// go no further if filename not set
echo $nogo;
}
else
{
// define the pathname to the file
$filepath = 'c:/htdocs/panasonic_system_pricing/'.$getfile;
// check that it exists and is readable
if (file_exists($filepath) && is_readable($filepath))
{
// get the file's size and send the appropriate headers
$size = filesize($filepath);
header('Content-Type: application/pdf/jpg/jpeg/xls/doc');
header('Content-Length: '.$size);
header('Content-Disposition: attachment; filename='.$getfile);
header('Content-Transfer-Encoding: binary');
// open the file in binary read-only mode
// suppress error messages if the file can't be opened
$file = @ fopen($filepath, 'rb');
if ($file)
{
// stream the file and exit the script when complete
fpassthru($file);
exit;
}
else
{
echo $nogo;
}
}
else
{
echo $nogo;
}
}
}
?>