[RESOLVED] Need help opening files??

[Lee_W]

Hi guys,

I have designed a dropdown list of files which mainly contains PDF, Excel & Jpeg files.

Now, I can open the PDF files without any problems however, when I try to open an excel sheet in read only mode it opens but displays a load of trash as if it's not decoded properly.

If I try to open a jpeg file it fails completely & just leave an empty square with a red cross.

Heres my download script: -

<?php

if (isset($_POST['pricelist'])) 
{
	$getfile = $_POST['pricelist'];

// define error handling
$nogo = 'Sorry, download unavailable.';

if (!$getfile) 
{
	// go no further if filename not set
	echo $nogo;
}
else 
{
	// define the pathname to the file
	$filepath = 'c:/htdocs/panasonic_system_pricing/'.$getfile;
	// check that it exists and is readable
	if (file_exists($filepath) && is_readable($filepath)) 
	{
		// get the file's size and send the appropriate headers
		$size = filesize($filepath);
		header('Content-Type: application/pdf/jpg/jpeg/xls/doc/csv');
		header('Content-Length: '.$size);
		header('Content-Disposition: attachment; filename='.$getfile);
		header('Content-Transfer-Encoding: binary');
		// open the file in binary read-only mode
		// suppress error messages if the file can't be opened
		$file = @ fopen($filepath, 'rb');
		if ($file) 
		{
			// stream the file and exit the script when complete
			fpassthru($file);
			exit;
		}
		else 
		{
			echo $nogo;
		}
	}
	else 
	{
		echo $nogo;
	}
}
}
?>

Any idea's?

[ ModEdit - bpat1434 ] Please use [noparse]

[/noparse] tags when posting php code.

[bpat1434]

I'm pretty sure that the content type header is plain wrong. You need to put in a check to send the correct content type based upon the file requested.

[Lee_W]

Thanks for the reply.

Sorry can you elaborate on exactly how I would do this as I am completely new to this?

[bpat1434]

Use [man]substr/man and [man]strrpos/man to get the extension:

$ext = substr($filepath, strrpos($filepath, '.')+1);

Then create a switch statement to set the correct content-type:

switch($ext)
{
    case 'pdf':
        $type = 'application/pdf';
        break;

case 'jpg':
case 'jpeg':
    $type = 'image/jpeg';
    break;

case 'xls':
    $type = 'application/vnd.ms-excel';
    break;

case 'doc':
    $type = 'application/vnd.ms-word';
    break;

case 'csv':
    $type = 'text/csv';
    break;
}

header('Content-Type: '.$type);
header('Content-Length: '.$size);
header('Content-Disposition: attachment; filename='.$getfile);
header('Content-Transfer-Encoding: binary');

echo file_get_contents($filepath);

Hope that helps.

[Lee_W]

Thanks very much for your help.

I will try this later.

Once again your help is appreciated.

[Lee_W]

Hi,

I have taken your advice & changed the script to the following: -

<?php

if (isset($_POST['pricelist']))

  {
  $getfile = ($_POST['pricelist']);

  // define the pathname to the file
  $filepath = 'C:/htdocs/panasonic_system_pricing/'.$getfile;

  $ext = substr($filepath, strrpos($filepath, '.')+1);

  switch ($ext)
  {
    case 'pdf':
      $type = 'application/pdf';
      break;

case 'jpg':
case 'jpeg':
  $type = 'image/jpeg';
  break;

case 'xls':
  $type = 'application/vnd.ms-excel';
  break;
  }

  // check that it exists and is readable
  if (file_exists($filepath) && is_readable($filepath)) {

  // get the file's size and send the appropriate headers
    $size = filesize($filepath);
    header('Content-Type: '.$type);
    header('Content-Length: '.$size);
    header('Content-Disposition: attachment; filename=' .$getfile);
    header('Content-Transfer-Encoding: binary');

// open the file in binary read-only mode
// suppress error messages if the file can't be opened
$file = @ fopen($filepath, 'rb');
if ($file) {
  // stream the file and exit the script when complete
fpassthru($file);
exit;
  }
  }
  }

?>

The problem is that if for example I try to open an Excel file I get the following: -

Warning: Cannot modify header information - headers already sent by (output started at C:\htdocs\Panasonic_system_pricing.php:3) in C:\htdocs\includes\Panasonic_system_pricelist_download.inc.php on line 34

Warning: Cannot modify header information - headers already sent by (output started at C:\htdocs\Panasonic_system_pricing.php:3) in C:\htdocs\includes\Panasonic_system_pricelist_download.inc.php on line 35

Warning: Cannot modify header information - headers already sent by (output started at C:\htdocs\Panasonic_system_pricing.php:3) in C:\htdocs\includes\Panasonic_system_pricelist_download.inc.php on line 36

Warning: Cannot modify header information - headers already sent by (output started at C:\htdocs\Panasonic_system_pricing.php:3) in C:\htdocs\includes\Panasonic_system_pricelist_download.inc.php on line 37
ÐÏࡱá>þÿ æþÿÿÿþÿÿÿäåÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿ ©ÍÉÀá°Áâ\pLee Wolstencroft B°aÀ=º ThisWorkbookœ¯¼=xx¶:Ò8X@"·Ú1ÈÿoArial1ÈÿoArial1ÈÿoArial1ÈÿoArial1È$oArial1È oArial1È oArial1 ÿoArial1 oArial1ȐoArial1  oArial1 ¼oArial1  oArial1  oArial1È oArial1 ÿ¼oArial1  ¼oArial1 ¼oArial"£"#,##0;\-"£"#,##0"£"#,##0;[Red]\-"£"#,##0"£"#,##0.00;\-"£"#,##0.00#"£"#,##0.00;[Red]\-"£"#,##0.005*0_-"£"* #,##0_-;\-"£"* #,##0_-;_-"£"* "-"_-;_-@_-,)'_-* #,##0_-;\-* #,##0_-;_-* "-"_-;_-@_-=,8_-"£"* #,##0.00_-;\-"£"* #,##0.00_-;_-"£"* "-"??_-;_-@_-4+/_-* #,##0.00_-;\-* #,##0.00_-;_-* "-"??_-;_-@_-¤ "£"#,##0.00¥mmmm\ d\,\ yyyy ¦0.0%§"Yes";"Yes";"No"¨"True";"True";"False"©"On";"On";"Off"ª[$-809]dd\ mmmm

Any idea's?

[ Mod Edit - bpat1434 ] Please use [noparse]

and

[/noparse] tags around your php code and general code respectively.

[bpat1434]

Sounds like you either have white-space at the beginning of your php file, or one of your file function calls is failing before the header calls. You can fix this by adding:

if(headers_sent())
    die('Headers already sent!');

so you can track down the error(s).

[Lee_W]

Whereabouts would I put this in my script?

Also, what do you mean by whitespace?

[bpat1434]

Whitespace is white space.... spaces, tabs, a Byte Order Mark (BOM), new-line, etc. Something that is "there" but you can't see without looking at the html code.

Of course, you could also be trying to echo something for debugging above your header calls which doesn't echo anything; however, just the act of echoing sends response headers.

The if(headers_sent()) code I posted would go on the line or two before you first call header(). E.g.

<?php

if (isset($_POST['pricelist']))

  {
  $getfile = ($_POST['pricelist']);

  // define the pathname to the file
  $filepath = 'C:/htdocs/panasonic_system_pricing/'.$getfile;

  $ext = substr($filepath, strrpos($filepath, '.')+1);

  switch ($ext)
  {
    case 'pdf':
      $type = 'application/pdf';
      break;

case 'jpg':
case 'jpeg':
  $type = 'image/jpeg';
  break;

case 'xls':
  $type = 'application/vnd.ms-excel';
  break;
  }

  // check that it exists and is readable
  if (file_exists($filepath) && is_readable($filepath)) {

// get the file's size and send the appropriate headers
$size = filesize($filepath);

if(headers_sent())
  die('Headers already sent!'); 

header('Content-Type: '.$type);
header('Content-Length: '.$size);
header('Content-Disposition: attachment; filename=' .$getfile);
header('Content-Transfer-Encoding: binary');

// open the file in binary read-only mode
// suppress error messages if the file can't be opened
$file = @ fopen($filepath, 'rb');
if ($file) {
  // stream the file and exit the script when complete
  fpassthru($file);
  exit;
}
  }
}
?>

I notice that every time copy your code, there is a space at the end of the script after the "?>" tag. This is a good reason why many PHP scripts eliminate the ending ?> tag from all php-scripts. It reduces the risk of white-space being at the end of the document and mucking up sessions, and header calls.

[Lee_W]

Thanks very much for your help.

You are an absolute star.

I didn't even take you up on your last recommendation on killing the headers all I did was move the include file to the top of the main script eliminating any whitespace you were talking about & the files now open a treat.

Thanks again.