IF statement problem

[JammeH]

Hi PHP coders,

I've got a little problem here that I hope you'll be able to help me with:

The code displays two buttons depending on a users status. If a user has accessrow[20] enabled they can view one and if they have accessrow[21] enabled they can view the other.

However as well as the above criteria there is a further restriction where users with accessrow[5] equal to the EXACT value "CENTRAL" can view all buttons however users can only view the button where accessrow[5] equals row[5] which is taken from a different table.

Are my statements correct.

From my testing if a user is assigned to CENTRAL the script works, however if a user is assigned to (for example) Cayley - and row[5] = Cayley then the script doesn't display the button.

Here is a copy of some of the code, let me know if you need more code.

			echo "<tr>
					<td bgcolor='#FFFFFF'><span class='style19'>$row[0]</span></td> 		
					<td bgcolor='#FFFFFF'><span class='style19'>$row[1]</span></td>
					<td bgcolor='#FFFFFF'><span class='style19'>$row[2]</span></td> 		
					<td bgcolor='#FFFFFF'><span class='style19'><center>$row[3]</center></span></td> 
					<td>";

if($accessrow[20]=="on" && $row[5]=="$accessrow[5]")
echo "<a href='edithallnews.php?id=$row[0]'><img border='0' src='images/admin/editicon.jpg'></a> &nbsp; ";
if($accessrow[20]=="on" && $accessrow[5]=="CENTRAL")
echo "<a href='edithallnews.php?id=$row[0]'><img border='0' src="images/admin/editicon.jpg'></a> &nbsp; ";
if($accessrow[21]=="on" && $row[5]==$accessrow[5])
echo "<a href='deletehallnews.php?id=$row[0]'><img border='0' src='images/admin/deleteicon.jpg'></a></td>";
if($accessrow[21]=="on" && $accessrow[5]=="CENTRAL")
echo "<a href='deletehallnews.php?id=$row[0]'><img border='0' src='images/admin/deleteicon.jpg'></a></td>";
echo "</tr>";
$row = mysql_fetch_row($result);
echo "<tr>
<td background=images/tables/background2.jpg'><span class='style19'>$row[0]</span></td>
<td background='images/tables/background2.jpg'><span class='style19'>$row[1]</span></td>
<td background='images/tables/background2.jpg'><span class='style19'>$row[2]</span></td>
<td background='images/tables/background2.jpg'><span class='style19'><center>$row[3]</center></span></td>
<td>";
if($accessrow[20]=="on" && $row[5]=='$accessrow[5]')
echo "<a href='edithallnews.php?id=$row[0]'><img border='0' src='images/admin/editicon.jpg'></a> &nbsp; ";
if($accessrow[20]=="on" && $accessrow[5]=="CENTRAL")
echo "<a href='edithallnews.php?id=$row[0]'><img border='0' src='images/admin/editicon.jpg'></a> &nbsp; ";
if($accessrow[21]=="on" && $row[5]=='$accessrow[5]')
echo "<a href='deletehallnews.php?id=$row[0]'><img border='0' src='images/admin/deleteicon.jpg'></a></td>";
if($accessrow[21]=="on" && $accessrow[5]=="CENTRAL")
echo "<a href='deletehallnews.php?id=$row[0]'><img border='0' src='images/admin/deleteicon.jpg'></a></td>";
echo "</tr>";
}
}
}
?>
</body>
</html>

Many thanks in advance.

[walterquez]

The 1st "if" statement, why is the second parameter in double quotes?

if($accessrow[20]=="on" && $row[5]=="$accessrow[5]")

The same with the 5th "if" statement, the variable is in single quotes.

if($accessrow[20]=="on" && $row[5]=='$accessrow[5]')

The 3rd "if" statement; it has double quotes inside the <img> tag.

if($accessrow[20]=="on" && $accessrow[5]=="CENTRAL")
echo "<a href='edithallnews.php?id=$row[0]'><img border='0' src="images/admin/editicon.jpg'></a> &nbsp; ";

The code below, background is missing a starting single quote.

<td background=images/tables/background2.jpg'><span class='style19'>$row[0]</span></td>

[Weedpacket]

Here's the code again, using the forums &#91;php]...[/code] tags.

echo "<tr>
<td bgcolor='#FFFFFF'><span class='style19'>$row[0]</span></td>
<td bgcolor='#FFFFFF'><span class='style19'>$row[1]</span></td>
<td bgcolor='#FFFFFF'><span class='style19'>$row[2]</span></td>
<td bgcolor='#FFFFFF'><span class='style19'><center>$row[3]</center></span></td>
<td>";
if($accessrow[20]=="on" && $row[5]=="$accessrow[5]")
	echo "<a href='edithallnews.php?id=$row[0]'><img border='0' src='images/admin/editicon.jpg'></a> &nbsp; ";
if($accessrow[20]=="on" && $accessrow[5]=="CENTRAL")
	echo "<a href='edithallnews.php?id=$row[0]'><img border='0' src="images/admin/editicon.jpg'></a> &nbsp; ";
if($accessrow[21]=="on" && $row[5]==$accessrow[5])
	echo "<a href='deletehallnews.php?id=$row[0]'><img border='0' src='images/admin/deleteicon.jpg'></a></td>";
if($accessrow[21]=="on" && $accessrow[5]=="CENTRAL")
	echo "<a href='deletehallnews.php?id=$row[0]'><img border='0' src='images/admin/deleteicon.jpg'></a></td>";
echo "</tr>";
$row = mysql_fetch_row($result);
echo "<tr>
<td background=images/tables/background2.jpg'><span class='style19'>$row[0]</span></td>
<td background='images/tables/background2.jpg'><span class='style19'>$row[1]</span></td>
<td background='images/tables/background2.jpg'><span class='style19'>$row[2]</span></td>
<td background='images/tables/background2.jpg'><span class='style19'><center>$row[3]</center></span></td>
<td>";
if($accessrow[20]=="on" && $row[5]=='$accessrow[5]')
	echo "<a href='edithallnews.php?id=$row[0]'><img border='0' src='images/admin/editicon.jpg'></a> &nbsp; ";
if($accessrow[20]=="on" && $accessrow[5]=="CENTRAL")
	echo "<a href='edithallnews.php?id=$row[0]'><img border='0' src='images/admin/editicon.jpg'></a> &nbsp; ";
if($accessrow[21]=="on" && $row[5]=='$accessrow[5]')
	echo "<a href='deletehallnews.php?id=$row[0]'><img border='0' src='images/admin/deleteicon.jpg'></a></td>";
if($accessrow[21]=="on" && $accessrow[5]=="CENTRAL")
	echo "<a href='deletehallnews.php?id=$row[0]'><img border='0' src='images/admin/deleteicon.jpg'></a></td>";
echo "</tr>";
}
}
}
?>
</body>
</html>

(Notice how partway down the faulty quote walterquez pointed out causes the highlighting to go nuts.) And looking at it now it could be simplified somewhat. Why test the same thing over and over and over again?

echo "<tr>
<td bgcolor='#FFFFFF'><span class='style19'>$row[0]</span></td>
<td bgcolor='#FFFFFF'><span class='style19'>$row[1]</span></td>
<td bgcolor='#FFFFFF'><span class='style19'>$row[2]</span></td>
<td bgcolor='#FFFFFF'><span class='style19'><center>$row[3]</center></span></td>
<td>";
if($accessrow[5]=="CENTRAL" || $accessrow[5]==$row[5])
{
	if($accessrow[20]=="on")
		echo "<a href='edithallnews.php?id=$row[0]'><img border='0' src='images/admin/editicon.jpg'></a> &nbsp; ";
	if($accessrow[21]=="on")
		echo "<a href='deletehallnews.php?id=$row[0]'><img border='0' src='images/admin/deleteicon.jpg'></a></td>";
}
echo "</tr>";
$row = mysql_fetch_row($result);
echo "<tr>
<td background=images/tables/background2.jpg'><span class='style19'>$row[0]</span></td>
<td background='images/tables/background2.jpg'><span class='style19'>$row[1]</span></td>
<td background='images/tables/background2.jpg'><span class='style19'>$row[2]</span></td>
<td background='images/tables/background2.jpg'><span class='style19'><center>$row[3]</center></span></td>
<td>";
if($accessrow[5]=="CENTRAL" || $accessrow[5]==$row[5])
{
	if($accessrow[20]=="on")
		echo "<a href='edithallnews.php?id=$row[0]'><img border='0' src='images/admin/editicon.jpg'></a> &nbsp; ";
	if($accessrow[21]=="on")
		echo "<a href='deletehallnews.php?id=$row[0]'><img border='0' src='images/admin/deleteicon.jpg'></a></td>";
	echo "</tr>";
}
}
}
}
?>
</body>
</html>

It looks like there's more repetition in there which could probably be eliminated by doing a bit of programming. Fewer lines of code means fewer places for bugs to hide.

And have you considered referring to the result columns by name instead of number? The former would be more descriptive and robust should the query change ("can_edit_news" would also be much easier to search for than "20"). And what's "style19" supposed to mean?

[walterquez]

Don't forget the single and double quotes. If it starts with a quote, make sure it ends with the same quote. Or if it ends with a quote, make sure it starts with the same type of quote, single or double.

A missing quote can cause a lot a of chaos. You can quote me on that.😃